0ee3e514f2dead811a4bcbefc6d46ba5f1df40a7
Files Diff
- Added: 24
- Removed: 6
- Renamed: 0
- Modified: 15
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 7 | ||
| Change Parameter Type iterator : Iterator<Map.Entry<String,Member>> to iterator : Iterator<Map.Entry<String,Member<T>>> in method private findSuitableMember(commandMessage CommandMessage, iterator Iterator<Map.Entry<String,Member<T>>>) : Member<T> in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Change Parameter Type commandMessage : CommandMessage<C> to command : CommandMessage<? extends C> in method public send(destination Address, command CommandMessage<? extends C>) : void in class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector | From | To | |
| Change Parameter Type commandType : String to commandMessage : CommandMessage in method public getMember(routingKey String, commandMessage CommandMessage) : T in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Change Parameter Type connector : CommandBusConnector to connector : CommandBusConnector<D> in method public DistributedCommandBus(localCommandBus CommandBus, serviceRegistry ServiceRegistry<D>, connector CommandBusConnector<D>, routingStrategy RoutingStrategy) in class org.axonframework.commandhandling.distributed.DistributedCommandBus | From | To | |
| Change Parameter Type hashed : SortedMap<String,Member> to hashed : SortedMap<String,Member<T>> in method private ConsistentHash(hashed SortedMap<String,Member<T>>) in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Change Parameter Type connector : CommandBusConnector to connector : CommandBusConnector<D> in method public DistributedCommandBus(localCommandBus CommandBus, serviceRegistry ServiceRegistry<D>, connector CommandBusConnector<D>) in class org.axonframework.commandhandling.distributed.DistributedCommandBus | From | To | |
| Change Parameter Type nodeName : String to node : T in method public Member(node T, segmentCount int, commandFilter Predicate<CommandMessage>) in class org.axonframework.commandhandling.distributed.ConsistentHash.Member | From | To | |
| Move Method | 3 | ||
| Move Method public getState(ostream OutputStream) : void from class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector.MessageReceiver to public getState(ostream OutputStream) : void from class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector | From | To | |
| Move Method public receive(msg Message) : void from class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector.MessageReceiver to public receive(msg Message) : void from class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector | From | To | |
| Move Method public equals(o Object) : boolean from class org.axonframework.commandhandling.distributed.ConsistentHash to public equals(o Object) : boolean from class org.axonframework.commandhandling.distributed.commandfilter.CommandNameFilter | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private address : Address from class org.axonframework.commandhandling.distributed.jgroups.support.callbacks.ReplyingCallback to private address : Address from class org.axonframework.commandhandling.distributed.jgroups.JoinMessage | From | To | |
| Move Attribute private currentView : View from class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector.MessageReceiver to private currentView : View from class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector | From | To | |
| Extract Class | 1 | ||
| Extract Class org.axonframework.commandhandling.distributed.CommandCallbackRepository from class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector | From | To | |
| Extract Variable | 1 | ||
| Extract Variable localSegment : SimpleCommandBus in method public main(args String[]) : void from class org.axonframework.commandhandling.distributed.jgroups.JGroupsCommandBusRunner | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type headIterator : Iterator<Map.Entry<String,Member>> to headIterator : Iterator<Map.Entry<String,Member<T>>> in method public getMember(routingKey String, commandMessage CommandMessage) : T in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Change Variable Type tailIterator : Iterator<Map.Entry<String,Member>> to tailIterator : Iterator<Map.Entry<String,Member<T>>> in method public getMember(routingKey String, commandMessage CommandMessage) : T in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Change Variable Type tailMap : SortedMap<String,Member> to tailMap : SortedMap<String,Member<T>> in method public getMember(routingKey String, commandMessage CommandMessage) : T in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Change Variable Type foundMember : Member to foundMember : Member<T> in method public getMember(routingKey String, commandMessage CommandMessage) : T in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Change Variable Type entry : Map.Entry<String,Member> to entry : Map.Entry<String,Member<T>> in method private findSuitableMember(commandMessage CommandMessage, iterator Iterator<Map.Entry<String,Member<T>>>) : Member<T> in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Split Attribute | 1 | ||
| Split Attribute connector1 : JGroupsConnector to [members1 : Set<ServiceMember<Address>>, members2 : Set<ServiceMember<Address>>] in class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnectorTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable foundMember : Member in method private findSuitableMember(commandType String, iterator Iterator<Map.Entry<String,Member>>) : Member from class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Rename Method | 1 | ||
| Rename Method private sendMembershipUpdate(dest Address) : void renamed to public publish(address Address, loadFactor int, commandFilter Predicate<CommandMessage>) : void in class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector | From | To | |
| Inline Method | 3 | ||
| Inline Method public readFrom(in DataInput) : void inlined to public readExternal(in ObjectInput) : void in class org.axonframework.commandhandling.distributed.jgroups.JoinMessage | From | To | |
| Inline Method private waitForConnectorSync(timeoutInSeconds int) : void inlined to public testConnectorRecoversWhenGossipRouterReconnects() : void in class org.axonframework.commandhandling.distributed.jgroups.JgroupsConnectorTest_Gossip | From | To | |
| Inline Method public writeTo(out DataOutput) : void inlined to public writeExternal(out ObjectOutput) : void in class org.axonframework.commandhandling.distributed.jgroups.JoinMessage | From | To | |
| Change Return Type | 3 | ||
| Change Return Type Set<Member> to Set<T> in method public getMembers() : Set<T> in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Change Return Type Member to Member<T> in method private findSuitableMember(commandMessage CommandMessage, iterator Iterator<Map.Entry<String,Member<T>>>) : Member<T> in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Change Return Type String to T in method public getMember(routingKey String, commandMessage CommandMessage) : T in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable dest : Address to destination : Address in method public send(destination Address, command CommandMessage<? extends C>) : void in class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector | From | To | |
| Parameterize Variable hash : String to routingKey : String in method public getMember(routingKey String, commandMessage CommandMessage) : T in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.axonframework.commandhandling.distributed.registry.AbstractServiceRegistry from classes [org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute currentLoadFactor : int to loadFactor : int in class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector | From | To | |
| Rename Attribute supportedCommandTypes : Set<String> to commandFilter : Predicate<CommandMessage> in class org.axonframework.commandhandling.distributed.ConsistentHash.Member | From | To | |
| Rename Attribute nodeName : String to node : T in class org.axonframework.commandhandling.distributed.ConsistentHash.Member | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type supportedCommandTypes : Set<String> to commandFilter : Predicate<CommandMessage> in class org.axonframework.commandhandling.distributed.ConsistentHash.Member | From | To | |
| Change Attribute Type nodeName : String to node : T in class org.axonframework.commandhandling.distributed.ConsistentHash.Member | From | To | |
| Change Attribute Type hashToMember : SortedMap<String,Member> to hashToMember : SortedMap<String,Member<T>> in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Change Attribute Type serializer : MessageSerializer to serializer : Serializer in class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector | From | To | |
| Change Attribute Type connector : CommandBusConnector to connector : CommandBusConnector<D> in class org.axonframework.commandhandling.distributed.DistributedCommandBus | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter commandMessage : CommandMessage<C> to command : CommandMessage<? extends C> in method public send(destination Address, command CommandMessage<? extends C>) : void in class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector | From | To | |
| Rename Parameter dest : Address to address : Address in method public publish(address Address, loadFactor int, commandFilter Predicate<CommandMessage>) : void in class org.axonframework.commandhandling.distributed.jgroups.JGroupsConnector | From | To | |
| Rename Parameter item : String to routingKey : String in method public getMember(routingKey String, commandMessage CommandMessage) : T in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Rename Parameter commandType : String to commandMessage : CommandMessage in method public getMember(routingKey String, commandMessage CommandMessage) : T in class org.axonframework.commandhandling.distributed.ConsistentHash | From | To | |
| Rename Parameter nodeName : String to node : T in method public Member(node T, segmentCount int, commandFilter Predicate<CommandMessage>) in class org.axonframework.commandhandling.distributed.ConsistentHash.Member | From | To |