424b6bdfb8767ac048fc58eed364969532db6094
Files Diff
- Added: 10
- Removed: 2
- Renamed: 0
- Modified: 21
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public percentageWithTwoCharacters(number double, maximum double) : String renamed to public percentage(number double, maximum double) : double in class me.corriekay.pokegoutil.utils.Utilities | From | To | |
| Rename Method public weaveDPS(p Pokemon, additionalDelay Integer) : double renamed to public hasStab(p Pokemon, primary boolean) : boolean in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Rename Method public ChangeTableData(pokes List<Pokemon>) : void renamed to public updateTableData(pokes List<Pokemon>) : void in class me.corriekay.pokegoutil.utils.windows.PokemonTableModel | From | To | |
| Rename Method public dpsForMove(p Pokemon, primary boolean) : double renamed to public hasStab(pokemonId PokemonId, move PokemonMove) : boolean in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type additionalDelay : Integer to primary : boolean in method public hasStab(p Pokemon, primary boolean) : boolean in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Inline Method | 1 | ||
| Inline Method private dpsForMove(p Pokemon, move PokemonMove, primary boolean) : double inlined to public hasStab(pokemonId PokemonId, move PokemonMove) : boolean in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Move Method | 6 | ||
| Move Method public getLocalPokeName(pokemon Pokemon) : String from class me.corriekay.pokegoutil.utils.pokemon.PokeHandler to public getLocalPokeName(pokemon Pokemon) : String from class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Move Method public ivRating(p Pokemon) : double from class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils to public ivRating(p Pokemon) : double from class me.corriekay.pokegoutil.utils.pokemon.PokemonCalculationUtils | From | To | |
| Move Method public duelAbility(p Pokemon, useIV boolean) : long from class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils to public duelAbility(pokemonId PokemonId, move1 PokemonMove, move2 PokemonMove, attackIV int, defenseIV int, staminaIV int) : long from class me.corriekay.pokegoutil.utils.pokemon.PokemonCalculationUtils | From | To | |
| Move Method public gymDefense(p Pokemon, useIV boolean) : long from class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils to public gymDefense(pokemonId PokemonId, move1 PokemonMove, move2 PokemonMove, attackIV int, defenseIV int, staminaIV int) : long from class me.corriekay.pokegoutil.utils.pokemon.PokemonCalculationUtils | From | To | |
| Move Method public gymOffense(p Pokemon, useIV boolean) : double from class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils to public gymOffense(p Pokemon) : double from class me.corriekay.pokegoutil.utils.pokemon.PokemonCalculationUtils | From | To | |
| Move Method public getLocalPokeName(id int) : String from class me.corriekay.pokegoutil.utils.pokemon.PokeHandler to public getLocalPokeName(id int) : String from class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Rename Variable | 3 | ||
| Rename Variable entry : SimpleEntry<String,ArrayList> to column : PokeColumn in method private ClearTable() : void in class me.corriekay.pokegoutil.utils.windows.PokemonTableModel | From | To | |
| Rename Variable move : PokemonMove to meta : PokemonMeta in method public hasStab(pokemonId PokemonId, move PokemonMove) : boolean in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Rename Variable rounded : long to percentage : double in method public percentageWithTwoCharacters(decimalNumber double) : String in class me.corriekay.pokegoutil.utils.Utilities | From | To | |
| Change Return Type | 3 | ||
| Change Return Type String to double in method public percentage(number double, maximum double) : double in class me.corriekay.pokegoutil.utils.Utilities | From | To | |
| Change Return Type double to boolean in method public hasStab(pokemonId PokemonId, move PokemonMove) : boolean in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Change Return Type double to boolean in method public hasStab(p Pokemon, primary boolean) : boolean in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Move Attribute | 3 | ||
| Move Attribute public MOVE2_CHARGE_DELAY_MS : int from class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils to public MOVE2_CHARGE_DELAY_MS : int from class me.corriekay.pokegoutil.utils.pokemon.PokemonCalculationUtils | From | To | |
| Move Attribute public CRIT_DAMAGE_BONUS : double from class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils to public CRIT_DAMAGE_BONUS : double from class me.corriekay.pokegoutil.utils.pokemon.PokemonCalculationUtils | From | To | |
| Move Attribute private STAB_MULTIPLIER : double from class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils to public STAB_MULTIPLIER : double from class me.corriekay.pokegoutil.utils.pokemon.PokemonCalculationUtils | From | To | |
| Extract Class | 1 | ||
| Extract Class me.corriekay.pokegoutil.utils.pokemon.PokemonCalculationUtils from class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute public PERCENTAGE_FACTOR : int in class me.corriekay.pokegoutil.utils.Utilities | From | To | |
| Move Class | 1 | ||
| Move Class me.corriekay.pokegoutil.utils.windows.DefaultCellRenderer moved to me.corriekay.pokegoutil.utils.windows.renderer.DefaultCellRenderer | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type move : PokemonMove to meta : PokemonMeta in method public hasStab(pokemonId PokemonId, move PokemonMove) : boolean in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Change Variable Type rounded : long to percentage : double in method public percentageWithTwoCharacters(decimalNumber double) : String in class me.corriekay.pokegoutil.utils.Utilities | From | To | |
| Change Variable Type entry : SimpleEntry<String,ArrayList> to column : PokeColumn in method private ClearTable() : void in class me.corriekay.pokegoutil.utils.windows.PokemonTableModel | From | To | |
| Extract Method | 1 | ||
| Extract Method public setNativeLookAndFeel(table JTable, isSelected boolean) : void extracted from public getTableCellRendererComponent(table JTable, value Object, isSelected boolean, hasFocus boolean, rowIndex int, columnIndex int) : Component in class me.corriekay.pokegoutil.utils.windows.renderer.DefaultCellRenderer | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter additionalDelay : Integer to primary : boolean in method public hasStab(p Pokemon, primary boolean) : boolean in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To |