7b7038c5c4f00b614821b1824e7903aa775db353
Files Diff
- Added: 7
- Removed: 1
- Renamed: 0
- Modified: 21
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method package onPTCLoginBtnClicked(event ActionEvent) : void renamed to private onPtcLoginBtnClicked(ignored ActionEvent) : void in class me.corriekay.pokegoutil.gui.controller.LoginController | From | To | |
| Rename Method public getWindow() : PokemonGoMainWindow renamed to public getInstance() : PokemonGoMainWindow in class me.corriekay.pokegoutil.windows.PokemonGoMainWindow | From | To | |
| Rename Method private onAutoRelogChanged(actionEvent ActionEvent) : void renamed to private onSaveAuthChkbxChanged(actionEvent ActionEvent) : void in class me.corriekay.pokegoutil.gui.controller.LoginController | From | To | |
| Rename Method private onGetToken(actionEvent ActionEvent) : void renamed to private ongetTokenBtnClicked(ignored ActionEvent) : void in class me.corriekay.pokegoutil.gui.controller.LoginController | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type console : Console to smartscroll : boolean in method public PokemonGoMainWindow(pkmngo PokemonGo, smartscroll boolean) in class me.corriekay.pokegoutil.windows.PokemonGoMainWindow | From | To | |
| Pull Up Attribute | 11 | ||
| Pull Up Attribute private rootScene : Scene from class me.corriekay.pokegoutil.gui.controller.LoginController to public rootScene : Scene from class me.corriekay.pokegoutil.gui.controller.BaseController | From | To | |
| Pull Up Attribute private rootScene : Scene from class me.corriekay.pokegoutil.gui.controller.MainWindowController to public rootScene : Scene from class me.corriekay.pokegoutil.gui.controller.BaseController | From | To | |
| Pull Up Attribute private classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.ChooseGuiWindowController to public classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.BaseController | From | To | |
| Pull Up Attribute private classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.LuckyEggGrinderController to public classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.BaseController | From | To | |
| Pull Up Attribute private classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.MainWindowController to public classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.BaseController | From | To | |
| Pull Up Attribute private rootScene : Scene from class me.corriekay.pokegoutil.gui.controller.LuckyEggGrinderController to public rootScene : Scene from class me.corriekay.pokegoutil.gui.controller.BaseController | From | To | |
| Pull Up Attribute private classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.OperationConfirmationController to public classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.BaseController | From | To | |
| Pull Up Attribute private rootScene : Scene from class me.corriekay.pokegoutil.gui.controller.ChooseGuiWindowController to public rootScene : Scene from class me.corriekay.pokegoutil.gui.controller.BaseController | From | To | |
| Pull Up Attribute private rootScene : Scene from class me.corriekay.pokegoutil.gui.controller.OperationConfirmationController to public rootScene : Scene from class me.corriekay.pokegoutil.gui.controller.BaseController | From | To | |
| Pull Up Attribute private classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.LoginController to public classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.BaseController | From | To | |
| Pull Up Attribute private classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.PokemonTableController to public classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.BaseController | From | To | |
| Move Attribute | 1 | ||
| Move Attribute public jsp : JScrollPane from class me.corriekay.pokegoutil.utils.ui.Console to public jsp : JScrollPane from class me.corriekay.pokegoutil.windows.PokemonGoMainWindow | From | To | |
| Extract Attribute | 4 | ||
| Extract Attribute private TABLE_HEIGHT_PADDING : int in class me.corriekay.pokegoutil.gui.controller.PokemonTableController | From | To | |
| Extract Attribute private SLASH : String in class me.corriekay.pokegoutil.gui.controller.MainWindowController | From | To | |
| Extract Attribute private DASH : String in class me.corriekay.pokegoutil.gui.controller.PokemonTableController | From | To | |
| Extract Attribute private newLine : String in class me.corriekay.pokegoutil.utils.logging.ConsoleOutStream | From | To | |
| Move Class | 1 | ||
| Move Class me.corriekay.pokegoutil.utils.ui.Console.ConsoleOutStream moved to me.corriekay.pokegoutil.utils.logging.ConsoleOutStream | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass me.corriekay.pokegoutil.gui.controller.BaseController from classes [me.corriekay.pokegoutil.gui.controller.ChooseGuiWindowController, me.corriekay.pokegoutil.gui.controller.LoginController, me.corriekay.pokegoutil.gui.controller.LuckyEggGrinderController, me.corriekay.pokegoutil.gui.controller.MainWindowController, me.corriekay.pokegoutil.gui.controller.OperationConfirmationController, me.corriekay.pokegoutil.gui.controller.PokemonTableController] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute window : PokemonGoMainWindow to instance : PokemonGoMainWindow in class me.corriekay.pokegoutil.windows.PokemonGoMainWindow | From | To | |
| Extract Method | 1 | ||
| Extract Method public initializeController() : void extracted from public PokemonTableController(pane GridPane) in class me.corriekay.pokegoutil.gui.controller.PokemonTableController | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public getMaxCpComperator() : Comparator<PokemonMeta> extracted from public ChangeTableData(pokes List<Pokemon>) : void in class me.corriekay.pokegoutil.utils.windows.PokemonTableModel & moved to class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Extract And Move Method public getEeveeEvolutions() : List<PokemonMeta> extracted from public ChangeTableData(pokes List<Pokemon>) : void in class me.corriekay.pokegoutil.utils.windows.PokemonTableModel & moved to class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter event : ActionEvent to ignored : ActionEvent in method private onPtcLoginBtnClicked(ignored ActionEvent) : void in class me.corriekay.pokegoutil.gui.controller.LoginController | From | To | |
| Rename Parameter console : Console to smartscroll : boolean in method public PokemonGoMainWindow(pkmngo PokemonGo, smartscroll boolean) in class me.corriekay.pokegoutil.windows.PokemonGoMainWindow | From | To | |
| Rename Parameter pane : GridPane to gridPane : GridPane in method public PokemonTableController(gridPane GridPane) in class me.corriekay.pokegoutil.gui.controller.PokemonTableController | From | To | |
| Rename Parameter event : ActionEvent to ignored : ActionEvent in method private onGoogleAuthBtnClicked(ignored ActionEvent) : void in class me.corriekay.pokegoutil.gui.controller.LoginController | From | To | |
| Rename Parameter actionEvent : ActionEvent to ignored : ActionEvent in method private ongetTokenBtnClicked(ignored ActionEvent) : void in class me.corriekay.pokegoutil.gui.controller.LoginController | From | To |