8f5aa8700ba5fbf99f143c605e5d02c43642215e
Files Diff
- Added: 13
- Removed: 50
- Renamed: 0
- Modified: 30
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 6 | ||
| Rename Method private buildPanelForOperation(operation BatchOperation, pokes ArrayList<Pokemon>) : JPanel renamed to private _buildPanelForOperation(operation String, pokes ArrayList<Pokemon>) : JPanel in class me.corriekay.pokegoutil.windows.PokemonTab | From | To | |
| Rename Method public PokemonTable(go PokemonGo) renamed to private constructNewTableModel(go PokemonGo, pokes List<Pokemon>) : void in class me.corriekay.pokegoutil.windows.PokemonTab.PokemonTable | From | To | |
| Rename Method public getName() : String renamed to public name() : String in class me.corriekay.pokegoutil.utils.ConfigNew.FindResult | From | To | |
| Rename Method public gymDefense(p Pokemon, useIV boolean) : long renamed to public gymOffense(p Pokemon) : long in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Rename Method public getNode() : JSONObject renamed to public node() : JSONObject in class me.corriekay.pokegoutil.utils.ConfigNew.FindResult | From | To | |
| Rename Method public duelAbility(p Pokemon, useIV boolean) : long renamed to public gymDefense(p Pokemon) : long in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Change Parameter Type | 6 | ||
| Change Parameter Type operation : BatchOperation to operation : String in method private confirmOperation(operation String, pokes ArrayList<Pokemon>) : boolean in class me.corriekay.pokegoutil.windows.PokemonTab | From | To | |
| Change Parameter Type configKey : ConfigKey to path : String in method public getJSONObject(path String, defaultValue JSONObject) : JSONObject in class me.corriekay.pokegoutil.utils.ConfigNew | From | To | |
| Change Parameter Type milliseconds : int to milliseconds : long in method public sleep(milliseconds long) : void in class me.corriekay.pokegoutil.utils.Utilities | From | To | |
| Change Parameter Type configKey : ConfigKey to path : String in method public setJSONObject(path String, value JSONObject) : void in class me.corriekay.pokegoutil.utils.ConfigNew | From | To | |
| Change Parameter Type type : Type to cls : Class<T> in method private ConfigKey(keyName String, defaultValue Object, cls Class<T>) in class me.corriekay.pokegoutil.utils.ConfigKey | From | To | |
| Change Parameter Type operation : BatchOperation to operation : String in method private _buildPanelForOperation(operation String, pokes ArrayList<Pokemon>) : JPanel in class me.corriekay.pokegoutil.windows.PokemonTab | From | To | |
| Move Method | 1 | ||
| Move Method private setDefaultSelectionColors(table JTable, isSelected boolean, tcr JLabel) : void from class me.corriekay.pokegoutil.utils.windows.MoveSetRankingRenderer to private setDefaultSelectionColors(table JTable, isSelected boolean, tcr JLabel) : void from class me.corriekay.pokegoutil.windows.PokemonTab | From | To | |
| Rename Variable | 4 | ||
| Rename Variable hasSavedCredentials : boolean to saveCredentials : boolean in method private initialize() : void in class me.corriekay.pokegoutil.GUI.controller.LoginController | From | To | |
| Rename Variable event : KeyEvent to e : KeyEvent in method public PokemonTab(go PokemonGo) in class me.corriekay.pokegoutil.windows.PokemonTab | From | To | |
| Rename Variable cInt : Comparator<Integer> to c : Comparator<Integer> in method private constructNewTableModel(go PokemonGo, pokes List<Pokemon>) : void in class me.corriekay.pokegoutil.windows.PokemonTab.PokemonTable | From | To | |
| Rename Variable duelAbility : double to gymDefense : double in method public gymDefense(p Pokemon) : long in class me.corriekay.pokegoutil.utils.pokemon.PokemonUtils | From | To | |
| Inline Method | 4 | ||
| Inline Method public ChangeTableData(pokes List<Pokemon>) : void inlined to private PokemonTableModel(go PokemonGo, pokes List<Pokemon>, pt PokemonTable) in class me.corriekay.pokegoutil.windows.PokemonTab.PokemonTableModel | From | To | |
| Inline Method public getRandom(minMilliseconds int, maxMilliseconds int) : int inlined to public sleepRandom(minMilliseconds int, maxMilliseconds int) : void in class me.corriekay.pokegoutil.utils.Utilities | From | To | |
| Inline Method private tryLogin(loginData LoginData) : void inlined to package onGoogleAuthBtnClicked(event ActionEvent) : void in class me.corriekay.pokegoutil.GUI.controller.LoginController | From | To | |
| Inline Method private tryLogin(loginData LoginData) : void inlined to package onPTCLoginBtnClicked(event ActionEvent) : void in class me.corriekay.pokegoutil.GUI.controller.LoginController | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.PokemonTableController to private classLoader : ClassLoader from class me.corriekay.pokegoutil.BlossomsPoGoManager | From | To | |
| Move Attribute private classLoader : ClassLoader from class me.corriekay.pokegoutil.gui.controller.OperationConfirmationController to private classLoader : ClassLoader from class me.corriekay.pokegoutil.BlossomsPoGoManager | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class me.corriekay.pokegoutil.data.enums.OperationError moved and renamed to me.corriekay.pokegoutil.DATA.models.PokemonBag | From | To | |
| Move Class | 12 | ||
| Move Class me.corriekay.pokegoutil.utils.windows.PokemonTableModel moved to me.corriekay.pokegoutil.windows.PokemonTab.PokemonTableModel | From | To | |
| Move Class me.corriekay.pokegoutil.data.enums.LoginType moved to me.corriekay.pokegoutil.DATA.managers.AccountController.LoginType | From | To | |
| Move Class me.corriekay.pokegoutil.data.managers.AccountManager moved to me.corriekay.pokegoutil.DATA.managers.AccountManager | From | To | |
| Move Class me.corriekay.pokegoutil.data.models.Inventory moved to me.corriekay.pokegoutil.DATA.models.Inventory | From | To | |
| Move Class me.corriekay.pokegoutil.utils.windows.PokemonTable moved to me.corriekay.pokegoutil.windows.PokemonTab.PokemonTable | From | To | |
| Move Class me.corriekay.pokegoutil.gui.controller.LuckyEggGrinderController moved to me.corriekay.pokegoutil.GUI.controller.LuckyEggGrinderController | From | To | |
| Move Class me.corriekay.pokegoutil.gui.controller.ChooseGuiWindowController moved to me.corriekay.pokegoutil.GUI.controller.ChooseGuiWindowController | From | To | |
| Move Class me.corriekay.pokegoutil.data.managers.ProfileManager moved to me.corriekay.pokegoutil.DATA.managers.ProfileManager | From | To | |
| Move Class me.corriekay.pokegoutil.gui.controller.MainWindowController moved to me.corriekay.pokegoutil.GUI.controller.MainWindowController | From | To | |
| Move Class me.corriekay.pokegoutil.gui.controller.LoginController moved to me.corriekay.pokegoutil.GUI.controller.LoginController | From | To | |
| Move Class me.corriekay.pokegoutil.data.managers.AccountController moved to me.corriekay.pokegoutil.DATA.managers.AccountController | From | To | |
| Move Class me.corriekay.pokegoutil.data.managers.InventoryManager moved to me.corriekay.pokegoutil.DATA.managers.InventoryManager | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type result : ReleasePokemonResponse.Result to result : ReleasePokemonResponseOuterClass.ReleasePokemonResponse.Result in method private evolveSelected() : void in class me.corriekay.pokegoutil.windows.PokemonTab | From | To | |
| Change Variable Type favoriteResult : SetFavoritePokemonResponse.Result to favoriteResult : SetFavoritePokemonResponseOuterClass.SetFavoritePokemonResponse.Result in method private toggleFavorite() : void in class me.corriekay.pokegoutil.windows.PokemonTab | From | To | |
| Change Variable Type transferResult : ReleasePokemonResponse.Result to transferResult : ReleasePokemonResponseOuterClass.ReleasePokemonResponse.Result in method private transferSelected() : void in class me.corriekay.pokegoutil.windows.PokemonTab | From | To | |
| Change Variable Type upgradeResult : UpgradePokemonResponse.Result to upgradeResult : UpgradePokemonResponseOuterClass.UpgradePokemonResponse.Result in method private powerUpSelected() : void in class me.corriekay.pokegoutil.windows.PokemonTab | From | To | |
| Extract Variable | 2 | ||
| Extract Variable newObj : JSONObject in method private findNode(path String, create boolean) : FindResult from class me.corriekay.pokegoutil.utils.ConfigNew | From | To | |
| Extract Variable locale : String in method public PokemonTab(go PokemonGo) from class me.corriekay.pokegoutil.windows.PokemonTab | From | To | |
| Change Package | 2 | ||
| Change Package me.corriekay.pokegoutil.gui to me.corriekay.pokegoutil.GUI | From | To | |
| Change Package me.corriekay.pokegoutil.data to me.corriekay.pokegoutil.DATA | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type noTransferLowerThanRadioBtn : CheckBox to noTransferLowerThanRadioBtn : RadioButton in class me.corriekay.pokegoutil.GUI.controller.LuckyEggGrinderController | From | To | |
| Change Attribute Type transferFavRadioBtn : CheckBox to transferFavRadioBtn : RadioButton in class me.corriekay.pokegoutil.GUI.controller.LuckyEggGrinderController | From | To | |
| Change Attribute Type caterpieRadioBtn1 : CheckBox to caterpieRadioBtn1 : RadioButton in class me.corriekay.pokegoutil.GUI.controller.LuckyEggGrinderController | From | To | |
| Change Attribute Type weedleRadioBtn1 : CheckBox to weedleRadioBtn1 : RadioButton in class me.corriekay.pokegoutil.GUI.controller.LuckyEggGrinderController | From | To | |
| Change Attribute Type pidgeyRadioBtn1 : CheckBox to pidgeyRadioBtn1 : RadioButton in class me.corriekay.pokegoutil.GUI.controller.LuckyEggGrinderController | From | To | |
| Rename Parameter | 6 | ||
| Rename Parameter configKey : ConfigKey to path : String in method public getJSONObject(path String, defaultValue JSONObject) : JSONObject in class me.corriekay.pokegoutil.utils.ConfigNew | From | To | |
| Rename Parameter configKey : ConfigKey to path : String in method public setJSONObject(path String, value JSONObject) : void in class me.corriekay.pokegoutil.utils.ConfigNew | From | To | |
| Rename Parameter type : Type to cls : Class<T> in method private ConfigKey(keyName String, defaultValue Object, cls Class<T>) in class me.corriekay.pokegoutil.utils.ConfigKey | From | To | |
| Rename Parameter deleteSaveAuth : boolean to justCleanup : boolean in method private deleteLoginData(type LoginType, justCleanup boolean) : void in class me.corriekay.pokegoutil.DATA.managers.AccountManager | From | To | |
| Rename Parameter shouldSave : boolean to save : boolean in method public setSaveLogin(save boolean) : void in class me.corriekay.pokegoutil.DATA.managers.AccountManager | From | To | |
| Rename Parameter event : KeyEvent to e : KeyEvent in method public keyPressed(e KeyEvent) : void in class me.corriekay.pokegoutil.windows.PokemonTab.PokemonTab.addKeyListener | From | To |