64c865ee598a92d474020e0d09b965a85e4eb305
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method public doDynamic(req StaplerRequest, rsp StaplerResponse) : void renamed to public getDynamic(token String, req StaplerRequest, rsp StaplerResponse) : Object in class com.groupon.jenkins.buildsetup.GithubReposController | From | To | |
Change Return Type | 3 | ||
Change Return Type void to Object in method public getDynamic(token String, req StaplerRequest, rsp StaplerResponse) : Object in class com.groupon.jenkins.buildsetup.GithubReposController | From | To | |
Change Return Type Iterable<ProjectConfigInfo> to Iterator<ProjectConfigInfo> in method public getRepositories() : Iterator<ProjectConfigInfo> in class com.groupon.jenkins.buildsetup.GithubReposController | From | To | |
Change Return Type Map<String,GHRepository> to Iterable<GHRepository> in method public getRepositories(orgName String) : Iterable<GHRepository> in class com.groupon.jenkins.github.services.GithubCurrentUserService | From | To | |
Parameterize Variable | 1 | ||
Parameterize Variable leadToken : String to token : String in method public getDynamic(token String, req StaplerRequest, rsp StaplerResponse) : Object in class com.groupon.jenkins.buildsetup.GithubReposController | From | To | |
Change Variable Type | 1 | ||
Change Variable Type ghRepos : Map<String,GHRepository> to ghRepos : Iterable<GHRepository> in method public getRepositories() : Iterator<ProjectConfigInfo> in class com.groupon.jenkins.buildsetup.GithubReposController | From | To | |
Extract Variable | 2 | ||
Extract Variable repoWithoutAdminAcess : GHRepository in method public should_show_repos_with_admin_access_only() : void from class com.groupon.jenkins.buildsetup.GithubReposControllerTest | From | To | |
Extract Variable currentOrg : String in method public getRepositories() : Iterator<ProjectConfigInfo> from class com.groupon.jenkins.buildsetup.GithubReposController | From | To |