a5d12f121a2a57fa1af76e145045d45a8f817a6f
Files Diff
- Added: 5
- Removed: 2
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 4 | ||
| Move And Rename Method private quitMethodDriver(sharedWebDriver SharedWebDriver) : void from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl to public quitDriver(sharedWebDriver SharedWebDriver) : void from class org.fluentlenium.adapter.sharedwebdriver.MethodDriver | From | To | |
| Move And Rename Method private quitJvmDriver(driver SharedWebDriver) : void from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl to public quitDriver(driver SharedWebDriver) : void from class org.fluentlenium.adapter.sharedwebdriver.JvmDriver | From | To | |
| Move And Rename Method private quitClassDriver(sharedWebDriver SharedWebDriver) : void from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl to public quitDriver(sharedWebDriver SharedWebDriver) : void from class org.fluentlenium.adapter.sharedwebdriver.ClassDriver | From | To | |
| Move And Rename Method private quitThreadDriver(driver SharedWebDriver) : void from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl to public quitDriver(driver SharedWebDriver) : void from class org.fluentlenium.adapter.sharedwebdriver.ThreadDriver | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type item : Entry<ClassAndTestNameWithThreadId,SharedWebDriver> to item : Map.Entry<ClassAndTestNameWithThreadId,SharedWebDriver> in method private closeThreadDriver(sharedWebDriver SharedWebDriver, item Map.Entry<ClassAndTestNameWithThreadId,SharedWebDriver>) : void in class org.fluentlenium.adapter.sharedwebdriver.ThreadDriver | From | To | |
| Move Method | 3 | ||
| Move Method private getThreadDriversToClose(driver SharedWebDriver) : List<Entry<ClassAndTestNameWithThreadId,SharedWebDriver>> from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl to private getThreadDriversToClose(driver SharedWebDriver) : List<Map.Entry<ClassAndTestNameWithThreadId,SharedWebDriver>> from class org.fluentlenium.adapter.sharedwebdriver.ThreadDriver | From | To | |
| Move Method private closeThreadDriver(sharedWebDriver SharedWebDriver, item Entry<ClassAndTestNameWithThreadId,SharedWebDriver>) : void from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl to private closeThreadDriver(sharedWebDriver SharedWebDriver, item Map.Entry<ClassAndTestNameWithThreadId,SharedWebDriver>) : void from class org.fluentlenium.adapter.sharedwebdriver.ThreadDriver | From | To | |
| Move Method private quitDriver(sharedWebDriver SharedWebDriver, testDriver SharedWebDriver) : void from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl to public quitDriver(sharedWebDriver SharedWebDriver, testDriver SharedWebDriver) : void from class org.fluentlenium.adapter.sharedwebdriver.FluentLeniumWebDriver | From | To | |
| Change Return Type | 1 | ||
| Change Return Type List<Entry<ClassAndTestNameWithThreadId,SharedWebDriver>> to List<Map.Entry<ClassAndTestNameWithThreadId,SharedWebDriver>> in method private getThreadDriversToClose(driver SharedWebDriver) : List<Map.Entry<ClassAndTestNameWithThreadId,SharedWebDriver>> in class org.fluentlenium.adapter.sharedwebdriver.ThreadDriver | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private threadDrivers : Map<ClassAndTestNameWithThreadId,SharedWebDriver> from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl to private threadDrivers : Map<ClassAndTestNameWithThreadId,SharedWebDriver> from class org.fluentlenium.adapter.sharedwebdriver.ThreadDriver | From | To | |
| Move Attribute private classDrivers : Map<Class<?>,SharedWebDriver> from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl to private classDrivers : Map<Class<?>,SharedWebDriver> from class org.fluentlenium.adapter.sharedwebdriver.ClassDriver | From | To | |
| Move Attribute private jvmDriver : SharedWebDriver from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl to private jvmDriver : SharedWebDriver from class org.fluentlenium.adapter.sharedwebdriver.JvmDriver | From | To | |
| Move Attribute private methodDrivers : Map<ClassAndTestName,SharedWebDriver> from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl to private methodDrivers : Map<ClassAndTestName,SharedWebDriver> from class org.fluentlenium.adapter.sharedwebdriver.MethodDriver | From | To | |
| Extract Class | 4 | ||
| Extract Class org.fluentlenium.adapter.sharedwebdriver.JvmDriver from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl | From | To | |
| Extract Class org.fluentlenium.adapter.sharedwebdriver.ClassDriver from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl | From | To | |
| Extract Class org.fluentlenium.adapter.sharedwebdriver.ThreadDriver from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl | From | To | |
| Extract Class org.fluentlenium.adapter.sharedwebdriver.MethodDriver from class org.fluentlenium.adapter.sharedwebdriver.SharedWebdriverSingletonImpl | From | To | |
| Move Class | 2 | ||
| Move Class org.fluentlenium.adapter.sharedwebdriver.ClassAndTestName moved to org.fluentlenium.adapter.sharedwebdriver.MethodDriver.ClassAndTestName | From | To | |
| Move Class org.fluentlenium.adapter.sharedwebdriver.ClassAndTestNameWithThreadId moved to org.fluentlenium.adapter.sharedwebdriver.ThreadDriver.ClassAndTestNameWithThreadId | From | To | |
| Extract Method | 3 | ||
| Extract Method private createDriver(parameters EffectiveParameters<?>, executorService ExecutorService) : Future<SharedWebDriver> extracted from protected getSharedWebDriver(parameters EffectiveParameters<?>, webDriverExecutor ExecutorService) : SharedWebDriver in class org.fluentlenium.adapter.FluentTestRunnerAdapter | From | To | |
| Extract Method private didNotExitGracefully(executorService ExecutorService) : boolean extracted from protected getSharedWebDriver(parameters EffectiveParameters<?>, webDriverExecutor ExecutorService) : SharedWebDriver in class org.fluentlenium.adapter.FluentTestRunnerAdapter | From | To | |
| Extract Method private shutDownExecutor(executorService ExecutorService) : void extracted from protected getSharedWebDriver(parameters EffectiveParameters<?>, webDriverExecutor ExecutorService) : SharedWebDriver in class org.fluentlenium.adapter.FluentTestRunnerAdapter | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter webDriverExecutor : ExecutorService to executorService : ExecutorService in method private shutDownExecutor(executorService ExecutorService) : void in class org.fluentlenium.adapter.FluentTestRunnerAdapter | From | To |