FluentLenium ab163e30bb865748f3b90db88c8c35e01af00416

ab163e30bb865748f3b90db88c8c35e01af00416

Files Diff

Added: 12
Removed: 3
Renamed: 0
Modified: 39

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Inline Method	2
Move And Inline Method public createComponent(locator ElementLocator, componentClass Class<T>, instantiator ComponentInstantiator) : T moved from class org.fluentlenium.core.proxy.LocatorProxies to class org.fluentlenium.core.inject.FluentInjector & inlined to private initFieldAsElement(locator ElementLocator, container Object, field Field, hookDefinitions List<HookDefinition<?>>) : Object	From	To
Move And Inline Method public createComponent(locator ElementLocator, componentClass Class<T>, instantiator ComponentInstantiator) : T moved from class org.fluentlenium.core.proxy.LocatorProxies to class org.fluentlenium.core.axes.Axes & inlined to public parent() : FluentWebElement	From	To
Change Parameter Type	2
Change Parameter Type proxy : WebElement to proxy : T in method public setProxy(proxy T) : void in class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Change Parameter Type proxy : Object to proxy : T in method public setProxy(proxy T) : void in class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Method	10
Move Method public getLocator() : ElementLocator from class org.fluentlenium.core.proxy.AbstractListHandler to public getLocator() : ElementLocator from class org.fluentlenium.core.proxy.ListHandler	From	To
Move Method public equals(o Object) : boolean from class org.fluentlenium.core.proxy.ComponentHandler to public equals(o Object) : boolean from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Method public getLocator() : ElementLocator from class org.fluentlenium.core.proxy.ComponentHandler to public getLocator() : ElementLocator from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Method public setProxy(proxy WebElement) : void from class org.fluentlenium.core.proxy.ComponentHandler to public setProxy(proxy T) : void from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Method private getMethod(declaringClass Class<?>, name String, types Class...) : Method from class org.fluentlenium.core.proxy.ComponentHandler to protected getMethod(declaringClass Class<?>, name String, types Class...) : Method from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Method public hashCode() : int from class org.fluentlenium.core.proxy.ComponentHandler to public hashCode() : int from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Method public now() : void from class org.fluentlenium.core.proxy.ComponentHandler to public now() : void from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Method public reset() : void from class org.fluentlenium.core.proxy.ComponentHandler to public reset() : void from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Method public setHooks(hookChainBuilder HookChainBuilder, hookDefinitions List<HookDefinition<?>>) : void from class org.fluentlenium.core.proxy.ComponentHandler to public setHooks(hookChainBuilder HookChainBuilder, hookDefinitions List<HookDefinition<?>>) : void from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Method public setProxy(proxy Object) : void from class org.fluentlenium.core.domain.FluentListImpl to public setProxy(proxy T) : void from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Pull Up Attribute	9
Pull Up Attribute private instantiator : ComponentInstantiator from class org.fluentlenium.core.domain.FluentListImpl to protected instantiator : ComponentInstantiator from class org.fluentlenium.core.domain.ComponentList	From	To
Pull Up Attribute private TO_STRING : Method from class org.fluentlenium.core.proxy.AbstractListHandler to private TO_STRING : Method from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Pull Up Attribute private hookDefinitions : List<HookDefinition<?>> from class org.fluentlenium.core.proxy.AbstractListHandler to protected hookDefinitions : List<HookDefinition<?>> from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Pull Up Attribute private hookChainBuilder : HookChainBuilder from class org.fluentlenium.core.proxy.AbstractListHandler to protected hookChainBuilder : HookChainBuilder from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Pull Up Attribute private fluentControl : FluentControl from class org.fluentlenium.core.domain.FluentWebElement to protected fluentControl : FluentControl from class org.fluentlenium.core.domain.Component	From	To
Pull Up Attribute private HASH_CODE : Method from class org.fluentlenium.core.proxy.AbstractListHandler to private HASH_CODE : Method from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Pull Up Attribute private webElement : WebElement from class org.fluentlenium.core.domain.FluentWebElement to protected webElement : WebElement from class org.fluentlenium.core.domain.Component	From	To
Pull Up Attribute private EQUALS : Method from class org.fluentlenium.core.proxy.AbstractListHandler to private EQUALS : Method from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Pull Up Attribute private instantiator : ComponentInstantiator from class org.fluentlenium.core.domain.FluentWebElement to protected instantiator : ComponentInstantiator from class org.fluentlenium.core.domain.Component	From	To
Move Attribute	6
Move Attribute private locator : ElementLocator from class org.fluentlenium.core.proxy.ComponentHandler to protected locator : ElementLocator from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Attribute private EQUALS : Method from class org.fluentlenium.core.proxy.ComponentHandler to private EQUALS : Method from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Attribute private hooks : List<FluentHook> from class org.fluentlenium.core.proxy.ComponentHandler to private hooks : List<FluentHook> from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Attribute private HASH_CODE : Method from class org.fluentlenium.core.proxy.ComponentHandler to private HASH_CODE : Method from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move Attribute private element : WebElement from class org.fluentlenium.core.proxy.ComponentHandler to private element : WebElement from class org.fluentlenium.core.proxy.ElementLocatorAdapter	From	To
Move Attribute private TO_STRING : Method from class org.fluentlenium.core.proxy.ComponentHandler to private TO_STRING : Method from class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Move And Rename Attribute	1
Move And Rename Attribute private element : WebElement renamed to protected result : T and moved from class org.fluentlenium.core.proxy.ComponentHandler to class org.fluentlenium.core.proxy.AbstractLocatorHandler	From	To
Change Variable Type	6
Change Variable Type select : FluentList<FluentWebElement> to select : List<WebElement> in method public find(selector String, filters Filter...) : FluentList<FluentWebElement> in class org.fluentlenium.core.search.Search	From	To
Change Variable Type elements : FluentListImpl<FluentWebElement> to elements : FluentList<FluentWebElement> in method protected find() : FluentList<FluentWebElement> in class org.fluentlenium.core.wait.FluentWaitElementMatcher	From	To
Change Variable Type elements : FluentListImpl<FluentWebElement> to elements : FluentList<FluentWebElement> in method protected find() : FluentList<FluentWebElement> in class org.fluentlenium.core.wait.FluentWaitElementListMatcher	From	To
Change Variable Type preFiltered : FluentList<FluentWebElement> to select : List<WebElement> in method public find(locator By, filters Filter...) : FluentList<FluentWebElement> in class org.fluentlenium.core.search.Search	From	To
Change Variable Type elements : FluentListImpl<FluentWebElement> to elements : FluentList<FluentWebElement> in method protected find() : FluentList<FluentWebElement> in class org.fluentlenium.core.wait.FluentWaitSupplierMatcher	From	To
Change Variable Type list : FluentListImpl<FluentWebElement> to list : FluentList<FluentWebElement> in method public testFromToElements() : void in class org.fluentlenium.core.domain.FluentListImplTest	From	To
Extract Method	1
Extract Method private register(element WebElement, component T) : void extracted from public newComponent(componentClass Class<T>, element WebElement) : T in class org.fluentlenium.core.components.ComponentsManager	From	To
Rename Method	2
Rename Method public createComponentList(locator ElementLocator, componentClass Class<T>, instantiator ComponentInstantiator, hookChainBuilder HookChainBuilder) : List<T> renamed to public createWebElementList(locator ElementLocator) : List<WebElement> in class org.fluentlenium.core.proxy.LocatorProxies	From	To
Rename Method public getLocatorResult() : WebElement renamed to public getLocatorResultImpl() : WebElement in class org.fluentlenium.core.proxy.ComponentHandler	From	To
Inline Method	2
Inline Method public el(element WebElement) : FluentWebElement inlined to public testFillList() : void in class org.fluentlenium.core.action.FillSelectTest	From	To
Inline Method public el(element WebElement) : FluentWebElement inlined to public testFillCss() : void in class org.fluentlenium.core.action.FillSelectTest	From	To
Rename Variable	2
Rename Variable preFiltered : FluentList<FluentWebElement> to select : List<WebElement> in method public find(locator By, filters Filter...) : FluentList<FluentWebElement> in class org.fluentlenium.core.search.Search	From	To
Rename Variable proxy : Object to component : Object in method private initFieldAsElement(locator ElementLocator, container Object, field Field, hookDefinitions List<HookDefinition<?>>) : Object in class org.fluentlenium.core.inject.FluentInjector	From	To
Change Return Type	5
Change Return Type List<?> to ComponentList<?> in method private initFieldAsList(locator ElementLocator, container Object, field Field, hookDefinitions List<HookDefinition<?>>) : ComponentList<?> in class org.fluentlenium.core.inject.FluentInjector	From	To
Change Return Type FluentList<FluentWebElement> to List<WebElement> in method private selectList(locator By) : List<WebElement> in class org.fluentlenium.core.search.Search	From	To
Change Return Type FluentList<FluentWebElement> to List<WebElement> in method private selectList(cssSelector String) : List<WebElement> in class org.fluentlenium.core.search.Search	From	To
Change Return Type List<T> to List<WebElement> in method public createWebElementList(locator ElementLocator) : List<WebElement> in class org.fluentlenium.core.proxy.LocatorProxies	From	To
Change Return Type FluentListImpl<FluentWebElement> to FluentList<FluentWebElement> in method public fromElements(instantiator ComponentInstantiator, hookChainBuilder HookChainBuilder, elements WebElement...) : FluentList<FluentWebElement> in class org.fluentlenium.core.domain.FluentListImpl	From	To
Extract Superclass	3
Extract Superclass org.fluentlenium.core.domain.ComponentList from classes [org.fluentlenium.core.domain.FluentListImpl]	From	To
Extract Superclass org.fluentlenium.core.domain.Component from classes [org.fluentlenium.core.domain.FluentWebElement]	From	To
Extract Superclass org.fluentlenium.core.components.AbstractComponentInstantiator from classes [org.fluentlenium.core.components.ComponentsManager, org.fluentlenium.core.components.DefaultComponentInstantiator]	From	To
Change Attribute Type	1
Change Attribute Type instantiator : ComponentInstantiator to instantiator : DefaultComponentInstantiator in class org.fluentlenium.core.components.ComponentsManager	From	To

ab163e30bb865748f3b90db88c8c35e01af00416

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: