JGroups 29c255d6f3bafbf3549fd3a9af9a78f3d8a9109d

29c255d6f3bafbf3549fd3a9af9a78f3d8a9109d

Files Diff

Added: 5
Removed: 2
Renamed: 0
Modified: 36

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	3
Rename Method protected generatePubKey(encodedKey byte[]) : PublicKey renamed to protected makePublicKey(encodedKey byte[]) : PublicKey in class org.jgroups.protocols.ASYM_ENCRYPT	From	To
Rename Method protected handleUpEvent(msg Message, hdr EncryptHeader) : Object renamed to protected processEncryptMessage(msg Message, hdr EncryptHeader, retval boolean) : boolean in class org.jgroups.protocols.ASYM_ENCRYPT	From	To
Rename Method protected setKeys(sender Address, key SecretKey, version byte[]) : void renamed to protected installSharedGroupKey(sender Address, key SecretKey, version byte[]) : void in class org.jgroups.protocols.ASYM_ENCRYPT	From	To
Pull Up Method	19
Pull Up Method protected setViewHandler(vh ViewHandler<GmsImpl.Request>, gms GMS) : void from class org.jgroups.tests.LeaveTest to protected setViewHandler(vh ViewHandler<GmsImpl.Request>, gms GMS) : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testConcurrentLeaves2() : void from class org.jgroups.tests.LeaveTest to public testConcurrentLeaves2() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method protected testLeaveOfFirstNMembers(comp Comparator<GmsImpl.Request>, leavers int) : void from class org.jgroups.tests.LeaveTest to protected testLeaveOfFirstNMembers(comp Comparator<GmsImpl.Request>, leavers int) : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testLeaveOfCoordAndNext8() : void from class org.jgroups.tests.LeaveTest to public testLeaveOfCoordAndNext8() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testLeaveOfNextAndCoord() : void from class org.jgroups.tests.LeaveTest to public testLeaveOfNextAndCoord() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method protected setup(num int) : void from class org.jgroups.tests.LeaveTest to protected setup(num int) : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testLeaveOfNext8AndCoord() : void from class org.jgroups.tests.LeaveTest to public testLeaveOfNext8AndCoord() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method protected testConcurrentLeaves(num_leavers int) : void from class org.jgroups.tests.LeaveTest to protected testConcurrentLeaves(num_leavers int) : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testLeaveOfSingletonCoord() : void from class org.jgroups.tests.LeaveTest to public testLeaveOfSingletonCoord() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testParticipantLeave() : void from class org.jgroups.tests.LeaveTest to public testParticipantLeave() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testCoordLeave() : void from class org.jgroups.tests.LeaveTest to public testCoordLeave() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testLeaveOfCoordAndNextWithOnly2Members() : void from class org.jgroups.tests.LeaveTest to public testLeaveOfCoordAndNextWithOnly2Members() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testSequentialLeavesOfCoordinators() : void from class org.jgroups.tests.LeaveTest to public testSequentialLeavesOfCoordinators() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testConcurrentLeaves8() : void from class org.jgroups.tests.LeaveTest to public testConcurrentLeaves8() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testGracefulLeave() : void from class org.jgroups.protocols.ASYM_ENCRYPT_LeaveTest to public testGracefulLeave() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testLeaveOfSecondHalfWithCoordLeaving() : void from class org.jgroups.tests.LeaveTest to public testLeaveOfSecondHalfWithCoordLeaving() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method public testLeaveOfCoordAndNext() : void from class org.jgroups.tests.LeaveTest to public testLeaveOfCoordAndNext() : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method protected setup() : void from class org.jgroups.protocols.ASYM_ENCRYPT_LeaveTest to protected setup(num int) : void from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Method protected testConcurrentLeaves(leavers int...) : void from class org.jgroups.tests.LeaveTest to protected testConcurrentLeaves(leavers int...) : void from class org.jgroups.tests.BaseLeaveTest	From	To
Inline Method	1
Inline Method protected handleUpMessage(msg Message) : Object inlined to public up(msg Message) : Object in class org.jgroups.protocols.Encrypt	From	To
Rename Variable	5
Rename Variable sender : Address to key_server : Address in method protected processEncryptMessage(msg Message, hdr EncryptHeader, retval boolean) : boolean in class org.jgroups.protocols.ASYM_ENCRYPT	From	To
Rename Variable decoding_ciphers : BlockingQueue<Cipher> to tmp_decoding_ciphers : BlockingQueue<Cipher> in method protected initSymCiphers(algorithm String, secret Key) : void in class org.jgroups.protocols.Encrypt	From	To
Rename Variable sym_version : byte[] to tmp_sym_version : byte[] in method protected initSymCiphers(algorithm String, secret Key) : void in class org.jgroups.protocols.Encrypt	From	To
Rename Variable encoding_ciphers : BlockingQueue<Cipher> to tmp_encoding_ciphers : BlockingQueue<Cipher> in method protected initSymCiphers(algorithm String, secret Key) : void in class org.jgroups.protocols.Encrypt	From	To
Rename Variable encrypt : SYM_ENCRYPT to encr : SYM_ENCRYPT in method protected create(name String) : JChannel in class org.jgroups.protocols.SYM_ENCRYPT_Test	From	To
Pull Up Attribute	4
Pull Up Attribute protected NUM : int from class org.jgroups.tests.LeaveTest to protected NUM : int from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Attribute protected channels : JChannel[] from class org.jgroups.tests.LeaveTest to protected channels : JChannel[] from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Attribute protected channels : JChannel[] from class org.jgroups.protocols.ASYM_ENCRYPT_LeaveTest to protected channels : JChannel[] from class org.jgroups.tests.BaseLeaveTest	From	To
Pull Up Attribute protected NUM : int from class org.jgroups.protocols.ASYM_ENCRYPT_LeaveTest to protected NUM : int from class org.jgroups.tests.BaseLeaveTest	From	To
Change Return Type	1
Change Return Type Object to boolean in method protected processEncryptMessage(msg Message, hdr EncryptHeader, retval boolean) : boolean in class org.jgroups.protocols.ASYM_ENCRYPT	From	To
Move Class	1
Move Class org.jgroups.tests.LeaveTest.MyViewHandler moved to org.jgroups.tests.BaseLeaveTest.MyViewHandler	From	To
Extract Superclass	1
Extract Superclass org.jgroups.tests.BaseLeaveTest from classes [org.jgroups.protocols.ASYM_ENCRYPT_LeaveTest, org.jgroups.tests.LeaveTest]	From	To
Rename Attribute	3
Rename Attribute FETCH_SECRET_KEY : int to INSTALL_MERGE_VIEW : int in class org.jgroups.Event	From	To
Rename Attribute SECRET_KEY_REQ : byte to FETCH_SHARED_KEY : byte in class org.jgroups.protocols.EncryptHeader	From	To
Rename Attribute SECRET_KEY_RSP : byte to INSTALL_KEYS : byte in class org.jgroups.protocols.EncryptHeader	From	To
Extract Method	5
Extract Method protected encrypt(msg Message) : Message extracted from protected encryptAndSend(msg Message) : void in class org.jgroups.protocols.Encrypt	From	To
Extract Method protected dropMulticastMessageFromNonMember(msg Message) : boolean extracted from public up(batch MessageBatch) : void in class org.jgroups.protocols.ASYM_ENCRYPT	From	To
Extract Method protected dropMulticastMessageFromNonMember(msg Message) : boolean extracted from public up(msg Message) : Object in class org.jgroups.protocols.ASYM_ENCRYPT	From	To
Extract Method protected skipDownMessage(msg Message) : Processing extracted from public down(msg Message) : Object in class org.jgroups.protocols.ASYM_ENCRYPT	From	To
Extract Method protected cacheGroupKey(version byte[]) : void extracted from protected setKeys(sender Address, key SecretKey, version byte[]) : void in class org.jgroups.protocols.ASYM_ENCRYPT	From	To

29c255d6f3bafbf3549fd3a9af9a78f3d8a9109d

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: