JGroups e75fb5998c1cfd07287d718005131877b8544244

e75fb5998c1cfd07287d718005131877b8544244

Files Diff

Added: 26
Removed: 10
Renamed: 0
Modified: 23

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method public RingBuffer(capacity int, offset long) from class org.jgroups.util.RingBuffer to public RingBufferSeqno(capacity int, offset long) from class org.jgroups.util.RingBufferSeqno	From	To
Change Parameter Type	10
Change Parameter Type buf : RingBuffer<T> to buf : RingBufferSeqno<T> in method protected assertIndices(buf RingBufferSeqno<T>, low long, hd long, hr long) : void in class org.jgroups.tests.RingBufferSeqnoTest	From	To
Change Parameter Type target : Address to target : Object in method public Sender(id short, latch CountDownLatch, sent_msgs AtomicInteger, target Object) in class org.jgroups.tests.RoundTrip.Sender	From	To
Change Parameter Type buf : RingBufferLockless<Message> to buf : RingBufferSeqnoLockless<Message> in method public Adder(buf RingBufferSeqnoLockless<Message>, latch CountDownLatch, num AtomicInteger) in class org.jgroups.tests.RingBufferLocklessStressTest.Adder	From	To
Change Parameter Type buf : RingBuffer<Message> to buf : RingBufferSeqno<Message> in method public Adder(buf RingBufferSeqno<Message>, latch CountDownLatch, num AtomicInteger) in class org.jgroups.tests.RingBufferStressTest.Adder	From	To
Change Parameter Type buf : RingBufferLockless<Integer> to buf : RingBufferSeqnoLockless<Integer> in method public Adder(seqno int, buf RingBufferSeqnoLockless<Integer>, block boolean) in class org.jgroups.tests.byteman.RingBufferSeqnoTest.Adder	From	To
Change Parameter Type buf : RingBuffer<Integer> to buf : RingBufferSeqno<Integer> in method public Adder(latch CountDownLatch, seqno int, buf RingBufferSeqno<Integer>) in class org.jgroups.tests.RingBufferSeqnoTest.Adder	From	To
Change Parameter Type buf : RingBuffer<Message> to buf : RingBufferSeqno<Message> in method public Remover(buf RingBufferSeqno<Message>, latch CountDownLatch) in class org.jgroups.tests.RingBufferStressTest.Remover	From	To
Change Parameter Type buf : RingBufferLockless<Message> to buf : RingBufferSeqnoLockless<Message> in method public Remover(buf RingBufferSeqnoLockless<Message>, latch CountDownLatch) in class org.jgroups.tests.RingBufferLocklessStressTest.Remover	From	To
Change Parameter Type buf : RingBufferLockless<Integer> to buf : RingBufferSeqnoLockless<Integer> in method public Remover(buf RingBufferSeqnoLockless<Integer>, num int) in class org.jgroups.tests.byteman.RingBufferSeqnoTest.Remover	From	To
Change Parameter Type buf : RingBufferLockless<T> to buf : RingBufferSeqnoLockless<T> in method protected assertIndices(buf RingBufferSeqnoLockless<T>, low long, hd long, hr long) : void in class org.jgroups.tests.byteman.RingBufferSeqnoTest	From	To
Move Method	50
Move Method public setHighestDelivered(hd long) : void from class org.jgroups.util.RingBuffer to public setHighestDelivered(hd long) : void from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public get(from long, to long) : List<T> from class org.jgroups.util.RingBuffer to public get(from long, to long) : List<T> from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public testAddMissing() : void from class org.jgroups.tests.RingBufferTest to public testAddMissing() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testGetMissing2() : void from class org.jgroups.tests.RingBufferTest to public testGetMissing2() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testGetMissing() : void from class org.jgroups.tests.RingBufferTest to public testGetMissing() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testGetList() : void from class org.jgroups.tests.RingBufferTest to public testGetList() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testConcurrentAddAndRemove() : void from class org.jgroups.tests.RingBufferTest to public testConcurrentAddAndRemove() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testSaturation() : void from class org.jgroups.tests.RingBufferTest to public testSaturation() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method protected assertIndices(buf RingBuffer<T>, low long, hd long, hr long) : void from class org.jgroups.tests.RingBufferTest to protected assertIndices(buf RingBufferSeqno<T>, low long, hd long, hr long) : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testRemovedPastHighestReceived() : void from class org.jgroups.tests.RingBufferTest to public testRemovedPastHighestReceived() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method protected index(seqno long) : int from class org.jgroups.util.RingBuffer to protected index(seqno long) : int from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public add(seqno long, element T) : boolean from class org.jgroups.util.RingBuffer to public add(seqno long, element T) : boolean from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public testBlockingAddAndDestroy() : void from class org.jgroups.tests.RingBufferTest to public testBlockingAddAndDestroy() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testRemove() : void from class org.jgroups.tests.RingBufferTest to public testRemove() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public remove(nullify boolean) : T from class org.jgroups.util.RingBuffer to public remove(nullify boolean) : T from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public remove() : T from class org.jgroups.util.RingBuffer to public remove() : T from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public getProcessing() : AtomicBoolean from class org.jgroups.util.RingBuffer to public getProcessing() : AtomicBoolean from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public saturation() : double from class org.jgroups.util.RingBuffer to public saturation() : double from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public add(seqno long, element T, block boolean) : boolean from class org.jgroups.util.RingBuffer to public add(seqno long, element T, block boolean) : boolean from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public testAddBeyondCapacity() : void from class org.jgroups.tests.RingBufferTest to public testAddBeyondCapacity() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testAddWithWrapAround() : void from class org.jgroups.tests.RingBufferTest to public testAddWithWrapAround() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testIndex() : void from class org.jgroups.tests.RingBufferTest to public testIndex() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public getDigest() : long[] from class org.jgroups.util.RingBuffer to public getDigest() : long[] from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public viewAccepted(view View) : void from class org.jgroups.tests.RoundTrip to public viewAccepted(view View) : void from class org.jgroups.tests.rt.transports.JGroupsTransport	From	To
Move Method public getHighestReceived() : long from class org.jgroups.util.RingBuffer to public getHighestReceived() : long from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public receive(msg Message) : void from class org.jgroups.tests.RoundTrip to public receive(msg Message) : void from class org.jgroups.tests.rt.transports.JGroupsTransport	From	To
Move Method public testBlockingAddAndStable() : void from class org.jgroups.tests.RingBufferTest to public testBlockingAddAndStable() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public getMissing() : SeqnoList from class org.jgroups.util.RingBuffer to public getMissing() : SeqnoList from class org.jgroups.util.RingBufferSeqno	From	To
Move Method protected count(missing boolean) : int from class org.jgroups.util.RingBuffer to protected count(missing boolean) : int from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public testAddWithInvalidSeqno() : void from class org.jgroups.tests.RingBufferTest to public testAddWithInvalidSeqno() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testStable() : void from class org.jgroups.tests.RingBufferTest to public testStable() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public removeMany(nullify boolean, max_results int) : List<T> from class org.jgroups.util.RingBuffer to public removeMany(nullify boolean, max_results int) : List<T> from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public testGet() : void from class org.jgroups.tests.RingBufferTest to public testGet() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public getLow() : long from class org.jgroups.util.RingBuffer to public getLow() : long from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public testConcurrentAdd() : void from class org.jgroups.tests.RingBufferTest to public testConcurrentAdd() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public _get(seqno long) : T from class org.jgroups.util.RingBuffer to public _get(seqno long) : T from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public testRemoveMany() : void from class org.jgroups.tests.RingBufferTest to public testRemoveMany() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public spaceUsed() : int from class org.jgroups.util.RingBuffer to public spaceUsed() : int from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public testRemoveManyWithNulling() : void from class org.jgroups.tests.RingBufferTest to public testRemoveManyWithNulling() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testAddWithWrapAroundAndRemoveMany() : void from class org.jgroups.tests.RingBufferTest to public testAddWithWrapAroundAndRemoveMany() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testIterator() : void from class org.jgroups.tests.RingBufferTest to public testIterator() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public testAdd() : void from class org.jgroups.tests.RingBufferTest to public testAdd() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public removeMany(processing AtomicBoolean, nullify boolean, max_results int) : List<T> from class org.jgroups.util.RingBuffer to public removeMany(processing AtomicBoolean, nullify boolean, max_results int) : List<T> from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public testIndexWithRemoveMany() : void from class org.jgroups.tests.RingBufferTest to public testIndexWithRemoveMany() : void from class org.jgroups.tests.RingBufferSeqnoTest	From	To
Move Method public get(seqno long) : T from class org.jgroups.util.RingBuffer to public get(seqno long) : T from class org.jgroups.util.RingBufferSeqno	From	To
Move Method protected block(seqno long) : boolean from class org.jgroups.util.RingBuffer to protected block(seqno long) : boolean from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public iterator() : Iterator<T> from class org.jgroups.util.RingBuffer to public iterator() : Iterator<T> from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public destroy() : void from class org.jgroups.util.RingBuffer to public destroy() : void from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public getHighestDelivered() : long from class org.jgroups.util.RingBuffer to public getHighestDelivered() : long from class org.jgroups.util.RingBufferSeqno	From	To
Move Method public stable(seqno long) : void from class org.jgroups.util.RingBuffer to public stable(seqno long) : void from class org.jgroups.util.RingBufferSeqno	From	To
Move Attribute	11
Move Attribute protected oob : boolean from class org.jgroups.tests.RoundTrip to protected oob : boolean from class org.jgroups.tests.rt.transports.JGroupsTransport	From	To
Move Attribute protected avg : AverageMinMax from class org.jgroups.tests.RoundTrip.Sender to protected avg : AverageMinMax from class org.jgroups.util.Profiler	From	To
Move Attribute protected offset : long from class org.jgroups.util.RingBuffer to protected offset : long from class org.jgroups.util.RingBufferSeqno	From	To
Move Attribute package sock : DatagramSocket from class org.jgroups.tests.RoundTripMulticast.ReceiverThread to protected sock : DatagramSocket from class org.jgroups.tests.rt.transports.UdpTransport	From	To
Move Attribute protected running : boolean from class org.jgroups.util.RingBuffer to protected running : boolean from class org.jgroups.util.RingBufferSeqno	From	To
Move Attribute protected hr : long from class org.jgroups.util.RingBuffer to protected hr : long from class org.jgroups.util.RingBufferSeqno	From	To
Move Attribute protected buffer_full : Condition from class org.jgroups.util.RingBuffer to protected buffer_full : Condition from class org.jgroups.util.RingBufferSeqno	From	To
Move Attribute protected dont_bundle : boolean from class org.jgroups.tests.RoundTrip to protected dont_bundle : boolean from class org.jgroups.tests.rt.transports.JGroupsTransport	From	To
Move Attribute protected hd : long from class org.jgroups.util.RingBuffer to protected hd : long from class org.jgroups.util.RingBufferSeqno	From	To
Move Attribute protected low : long from class org.jgroups.util.RingBuffer to protected low : long from class org.jgroups.util.RingBufferSeqno	From	To
Move Attribute protected processing : AtomicBoolean from class org.jgroups.util.RingBuffer to protected processing : AtomicBoolean from class org.jgroups.util.RingBufferSeqno	From	To
Extract Class	5
Extract Class org.jgroups.tests.RingBufferSeqnoTest from class org.jgroups.tests.RingBufferTest	From	To
Extract Class org.jgroups.util.RingBufferSeqno from class org.jgroups.util.RingBuffer	From	To
Extract Class org.jgroups.tests.rt.transports.UdpTransport from class org.jgroups.tests.RoundTripMulticast.ReceiverThread	From	To
Extract Class org.jgroups.tests.rt.transports.TcpTransport from class org.jgroups.tests.RoundTripMulticast.ReceiverThread	From	To
Extract Class org.jgroups.tests.rt.transports.JGroupsTransport from class org.jgroups.tests.RoundTrip	From	To
Rename Class	2
Rename Class org.jgroups.util.RingBufferLockless renamed to org.jgroups.util.RingBufferSeqnoLockless	From	To
Rename Class org.jgroups.tests.byteman.RingBufferTest renamed to org.jgroups.tests.byteman.RingBufferSeqnoTest	From	To
Move And Rename Class	1
Move And Rename Class org.jgroups.tests.RoundTripMulticast.ReceiverThread moved and renamed to org.jgroups.util.Runner	From	To
Move Class	5
Move Class org.jgroups.tests.RoundTripNio.Receiver moved to org.jgroups.tests.rt.transports.NioTransport.Receiver	From	To
Move Class org.jgroups.tests.RoundTripTcp.Receiver moved to org.jgroups.tests.rt.transports.TcpTransport.Receiver	From	To
Move Class org.jgroups.util.RingBuffer.RingBufferIterator moved to org.jgroups.util.RingBufferSeqno.RingBufferIterator	From	To
Move Class org.jgroups.tests.RoundTripServer.Sender moved to org.jgroups.tests.BundlerStressTest.Sender	From	To
Move Class org.jgroups.tests.RingBufferTest.Adder moved to org.jgroups.tests.RingBufferSeqnoTest.Adder	From	To
Change Variable Type	6
Change Variable Type buf : RingBuffer<Message> to buf : RingBufferSeqno<Message> in method public main(args String[]) : void in class org.jgroups.tests.RingBufferStressTest	From	To
Change Variable Type buf : RingBufferLockless<Integer> to buf : RingBufferSeqnoLockless<Integer> in method public testRemoveAndConcurrentAdd2() : void in class org.jgroups.tests.byteman.RingBufferSeqnoTest	From	To
Change Variable Type view : View to mbrs : List in method protected sendRequests() : void in class org.jgroups.tests.RoundTrip	From	To
Change Variable Type buf : RingBufferLockless<Integer> to buf : RingBufferSeqnoLockless<Integer> in method public testRemoveAndConcurrentAdd() : void in class org.jgroups.tests.byteman.RingBufferSeqnoTest	From	To
Change Variable Type buf : RingBufferLockless<Message> to buf : RingBufferSeqnoLockless<Message> in method public main(args String[]) : void in class org.jgroups.tests.RingBufferLocklessStressTest	From	To
Change Variable Type buf : RingBuffer to rb : RingBuffer<Integer> in method public testEmpty() : void in class org.jgroups.tests.RingBufferTest	From	To
Extract Variable	1
Extract Variable tmp : State in method protected checkClosedOrNotConnected() : JChannel from class org.jgroups.JChannel	From	To
Inline Variable	1
Inline Variable ch_name : AsciiString in method protected passBatchUp(batch MessageBatch, perform_cluster_name_matching boolean, discard_own_mcast boolean) : void from class org.jgroups.protocols.TP	From	To
Extract Method	4
Extract Method protected submitToThreadPool(thread_pool Executor, task Runnable) : void extracted from protected removeAndDispatchNonBundledMessages(oob_batches MessageBatch...) : void in class org.jgroups.protocols.TP	From	To
Extract Method protected _sendBundledMessages() : void extracted from protected sendBundledMessages() : void in class org.jgroups.protocols.SimplifiedTransferQueueBundler	From	To
Extract Method protected submitToThreadPool(thread_pool Executor, task Runnable) : void extracted from protected handleSingleMessage(sender Address, data byte[], offset int, length int) : void in class org.jgroups.protocols.TP	From	To
Extract Method protected submitToThreadPool(thread_pool Executor, task Runnable) : void extracted from protected handleMessageBatch(sender Address, data byte[], offset int, length int) : void in class org.jgroups.protocols.TP	From	To
Rename Method	3
Rename Method public testConstructor() : void renamed to public testEmpty() : void in class org.jgroups.tests.RingBufferTest	From	To
Rename Method public missing() : int renamed to public countLockLockless() : int in class org.jgroups.util.RingBuffer	From	To
Rename Method protected numMessages() : int renamed to public size() : int in class org.jgroups.protocols.BaseBundler	From	To
Rename Variable	6
Rename Variable buf : RingBuffer to rb : RingBuffer<Integer> in method public testEmpty() : void in class org.jgroups.tests.RingBufferTest	From	To
Rename Variable rsp_buf : ByteBuffer to buf : ByteBuffer in method public run() : void in class org.jgroups.tests.rt.transports.NioTransport.Receiver	From	To
Rename Variable time : long to time_ns : long in method public run() : void in class org.jgroups.tests.BundlerStressTest.Sender	From	To
Rename Variable num : int to idx : int in method public run() : void in class org.jgroups.tests.BundlerStressTest.Sender	From	To
Rename Variable props : String to tp : String in method public main(args String[]) : void in class org.jgroups.tests.RoundTrip	From	To
Rename Variable view : View to mbrs : List in method protected sendRequests() : void in class org.jgroups.tests.RoundTrip	From	To
Change Return Type	1
Change Return Type Collection<Address> to void in method private pickAnycastTargets(anycast_targets List<Address>) : void in class org.jgroups.tests.perf.UPerf.Invoker	From	To
Rename Attribute	2
Rename Attribute avg : AverageMinMax to rtt : AverageMinMax in class org.jgroups.tests.RoundTrip.Sender	From	To
Rename Attribute avg : AverageMinMax to send : AverageMinMax in class org.jgroups.tests.BundlerStressTest.Sender	From	To
Change Attribute Type	8
Change Attribute Type buf : RingBufferLockless<Message> to buf : RingBufferSeqnoLockless<Message> in class org.jgroups.tests.RingBufferLocklessStressTest.Remover	From	To
Change Attribute Type buf : RingBuffer<Message> to buf : RingBufferSeqno<Message> in class org.jgroups.tests.RingBufferStressTest.Adder	From	To
Change Attribute Type buf : RingBufferLockless<Integer> to buf : RingBufferSeqnoLockless<Integer> in class org.jgroups.tests.byteman.RingBufferSeqnoTest.Remover	From	To
Change Attribute Type buf : RingBuffer<Integer> to buf : RingBufferSeqno<Integer> in class org.jgroups.tests.RingBufferSeqnoTest.Adder	From	To
Change Attribute Type buf : RingBufferLockless<Message> to buf : RingBufferSeqnoLockless<Message> in class org.jgroups.tests.RingBufferLocklessStressTest.Adder	From	To
Change Attribute Type buf : RingBuffer<Message> to buf : RingBufferSeqno<Message> in class org.jgroups.tests.RingBufferStressTest.Remover	From	To
Change Attribute Type buf : RingBufferLockless<Integer> to buf : RingBufferSeqnoLockless<Integer> in class org.jgroups.tests.byteman.RingBufferSeqnoTest.Adder	From	To
Change Attribute Type target : Address to target : Object in class org.jgroups.tests.RoundTrip.Sender	From	To

e75fb5998c1cfd07287d718005131877b8544244

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: