Lealone d050b681d2b00ccb6d4674db1ff5f4a4bd6566ad

d050b681d2b00ccb6d4674db1ff5f4a4bd6566ad

Files Diff

Added: 4
Removed: 0
Renamed: 0
Modified: 11

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	1
Extract Subclass org.lealone.net.TransferConnection from class org.lealone.net.AsyncConnection	From	To
Change Parameter Type	4
Change Parameter Type c : AsyncConnection to c : TcpConnection in method public addConnection(c TcpConnection) : void in class org.lealone.net.CommandHandler	From	To
Change Parameter Type conn : AsyncConnection to conn : TransferConnection in method public Transfer(conn TransferConnection, writableChannel WritableChannel, inBuffer NetBuffer) in class org.lealone.net.Transfer	From	To
Change Parameter Type conn : AsyncConnection to conn : TransferConnection in method public Transfer(conn TransferConnection, writableChannel WritableChannel, session Session) in class org.lealone.net.Transfer	From	To
Change Parameter Type c : AsyncConnection to c : TcpConnection in method public removeConnection(c TcpConnection) : void in class org.lealone.net.CommandHandler	From	To
Move Method	20
Move Method private writeBatchResult(transfer Transfer, session Session, id int, result int[]) : void from class org.lealone.net.AsyncConnection to private writeBatchResult(transfer Transfer, session Session, id int, result int[]) : void from class org.lealone.net.TcpConnection	From	To
Move Method private createSession(transfer Transfer, originalURL String, dbName String, userName String) : Session from class org.lealone.net.AsyncConnection to private createSession(transfer Transfer, originalURL String, dbName String, userName String) : Session from class org.lealone.net.TcpConnection	From	To
Move Method private writeColumn(transfer Transfer, result Result, i int) : void from class org.lealone.net.AsyncConnection to private writeColumn(transfer Transfer, result Result, i int) : void from class org.lealone.net.TcpConnection	From	To
Move Method protected processRequest(transfer Transfer, id int, operation int) : void from class org.lealone.net.AsyncConnection to protected processRequest(transfer Transfer, id int, operation int) : void from class org.lealone.net.TcpConnection	From	To
Move Method private closeSession(session Session) : void from class org.lealone.net.AsyncConnection to private closeSession(session Session) : void from class org.lealone.net.TcpConnection	From	To
Move Method public addSession(sessionId int, session Session) : void from class org.lealone.net.AsyncConnection to public addSession(sessionId int, session Session) : void from class org.lealone.net.TcpConnection	From	To
Move Method private getStatus(session Session) : int from class org.lealone.net.AsyncConnection to private getStatus(session Session) : int from class org.lealone.net.TcpConnection	From	To
Move Method private readInitPacket(transfer Transfer, id int, sessionId int) : void from class org.lealone.net.AsyncConnection to private readInitPacket(transfer Transfer, id int, sessionId int) : void from class org.lealone.net.TcpConnection	From	To
Move Method private setParameters(transfer Transfer, command PreparedStatement) : void from class org.lealone.net.AsyncConnection to private setParameters(transfer Transfer, command PreparedStatement) : void from class org.lealone.net.TcpConnection	From	To
Move Method private writeResponseHeader(transfer Transfer, session Session, id int) : void from class org.lealone.net.AsyncConnection to private writeResponseHeader(transfer Transfer, session Session, id int) : void from class org.lealone.net.TcpConnection	From	To
Move Method private executeQueryAsync(transfer Transfer, session Session, sessionId int, id int, command PreparedStatement, operation int, objectId int, maxRows int, fetchSize int) : void from class org.lealone.net.AsyncConnection to private executeQueryAsync(transfer Transfer, session Session, sessionId int, id int, command PreparedStatement, operation int, objectId int, maxRows int, fetchSize int) : void from class org.lealone.net.TcpConnection	From	To
Move Method public getNextId() : int from class org.lealone.net.AsyncConnection to public getNextId() : int from class org.lealone.net.TcpConnection	From	To
Move Method public createTransfer(session Session) : Transfer from class org.lealone.net.AsyncConnection to public createTransfer(session Session) : Transfer from class org.lealone.net.TcpConnection	From	To
Move Method public removeSession(sessionId int) : void from class org.lealone.net.AsyncConnection to public removeSession(sessionId int) : void from class org.lealone.net.TcpConnection	From	To
Move Method private executeUpdateAsync(transfer Transfer, session Session, sessionId int, id int, command PreparedStatement, operation int) : void from class org.lealone.net.AsyncConnection to private executeUpdateAsync(transfer Transfer, session Session, sessionId int, id int, command PreparedStatement, operation int) : void from class org.lealone.net.TcpConnection	From	To
Move Method public writeInitPacket(session Session, transfer Transfer, ci ConnectionInfo) : void from class org.lealone.net.AsyncConnection to public writeInitPacket(session Session, transfer Transfer, ci ConnectionInfo) : void from class org.lealone.net.TcpConnection	From	To
Move Method private addPreparedCommandToQueue(pc PreparedCommand, sessionId int) : void from class org.lealone.net.AsyncConnection to private addPreparedCommandToQueue(pc PreparedCommand, sessionId int) : void from class org.lealone.net.TcpConnection	From	To
Move Method private writeParameterMetaData(transfer Transfer, p CommandParameter) : void from class org.lealone.net.AsyncConnection to private writeParameterMetaData(transfer Transfer, p CommandParameter) : void from class org.lealone.net.TcpConnection	From	To
Move Method public setBaseDir(baseDir String) : void from class org.lealone.net.AsyncConnection to public setBaseDir(baseDir String) : void from class org.lealone.net.TcpConnection	From	To
Move Method private writeRow(transfer Transfer, result Result, count int) : void from class org.lealone.net.AsyncConnection to private writeRow(transfer Transfer, result Result, count int) : void from class org.lealone.net.TcpConnection	From	To
Pull Up Attribute	3
Pull Up Attribute package writableChannel : WritableChannel from class org.lealone.net.Transfer.ResettableBufferOutputStream to protected writableChannel : WritableChannel from class org.lealone.net.NetBufferOutputStream	From	To
Pull Up Attribute package buffer : NetBuffer from class org.lealone.net.Transfer.ResettableBufferOutputStream to protected buffer : NetBuffer from class org.lealone.net.NetBufferOutputStream	From	To
Pull Up Attribute package initialSizeHint : int from class org.lealone.net.Transfer.ResettableBufferOutputStream to protected initialSizeHint : int from class org.lealone.net.NetBufferOutputStream	From	To
Push Down Attribute	2
Push Down Attribute private lastBuffer : NetBuffer from class org.lealone.net.AsyncConnection to private lastBuffer : NetBuffer from class org.lealone.net.TransferConnection	From	To
Push Down Attribute private callbackMap : ConcurrentHashMap<Integer,AsyncCallback<?>> from class org.lealone.net.AsyncConnection to protected callbackMap : ConcurrentHashMap<Integer,AsyncCallback<?>> from class org.lealone.net.TransferConnection	From	To
Move Attribute	8
Move Attribute private sessions : ConcurrentHashMap<Integer,Session> from class org.lealone.net.AsyncConnection to private sessions : ConcurrentHashMap<Integer,Session> from class org.lealone.net.TcpConnection	From	To
Move Attribute private cache : SmallMap from class org.lealone.net.AsyncConnection to private cache : SmallMap from class org.lealone.net.TcpConnection	From	To
Move Attribute private nextId : AtomicInteger from class org.lealone.net.AsyncConnection to private nextId : AtomicInteger from class org.lealone.net.TcpConnection	From	To
Move Attribute private lobs : SmallLRUCache<Long,CachedInputStream> from class org.lealone.net.AsyncConnection to private lobs : SmallLRUCache<Long,CachedInputStream> from class org.lealone.net.TcpConnection	From	To
Move Attribute package sessionInfoMap : ConcurrentHashMap<Integer,SessionInfo> from class org.lealone.net.AsyncConnection to package sessionInfoMap : ConcurrentHashMap<Integer,SessionInfo> from class org.lealone.net.TcpConnection	From	To
Move Attribute private logger : Logger from class org.lealone.net.AsyncConnection to private logger : Logger from class org.lealone.net.TcpConnection	From	To
Move Attribute private netClient : NetClient from class org.lealone.net.AsyncConnection to private netClient : NetClient from class org.lealone.net.TcpConnection	From	To
Move Attribute private baseDir : String from class org.lealone.net.AsyncConnection to private baseDir : String from class org.lealone.net.TcpConnection	From	To
Extract Class	1
Extract Class org.lealone.net.TcpConnection from class org.lealone.net.AsyncConnection	From	To
Move And Rename Class	1
Move And Rename Class org.lealone.net.Transfer.BufferInputStream moved and renamed to org.lealone.net.NetBufferInputStream	From	To
Move Class	2
Move Class org.lealone.net.AsyncConnection.CachedInputStream moved to org.lealone.net.TcpConnection.CachedInputStream	From	To
Move Class org.lealone.net.AsyncConnection.SessionInfo moved to org.lealone.net.TcpConnection.SessionInfo	From	To
Change Variable Type	1
Change Variable Type ac : AsyncConnection to conn : TcpConnection in method public createConnection(writableChannel WritableChannel, isServer boolean) : AsyncConnection in class org.lealone.server.TcpServer	From	To
Extract Variable	2
Extract Variable buff : ByteBuf in method public channelRead(ctx ChannelHandlerContext, msg Object) : void from class org.lealone.net.netty.NettyNetServerHandler	From	To
Extract Variable buff : ByteBuf in method public channelRead(ctx ChannelHandlerContext, msg Object) : void from class org.lealone.net.netty.NettyNetClient.NettyClientHandler	From	To
Rename Method	2
Rename Method package getAsyncConnection() : AsyncConnection renamed to package getTcpConnection() : TcpConnection in class org.lealone.client.ClientSession	From	To
Rename Method public getAsyncConnection() : AsyncConnection renamed to public getTransferConnection() : TransferConnection in class org.lealone.net.Transfer	From	To
Push Down Method	7
Push Down Method private parseError(transfer Transfer) : DbException from class org.lealone.net.AsyncConnection to protected parseError(transfer Transfer) : DbException from class org.lealone.net.TransferConnection	From	To
Push Down Method private processResponse(transfer Transfer, id int) : void from class org.lealone.net.AsyncConnection to protected processResponse(transfer Transfer, id int, status int) : void from class org.lealone.net.TransferConnection	From	To
Push Down Method public getAsyncCallback(id int) : AsyncCallback<?> from class org.lealone.net.AsyncConnection to public getAsyncCallback(id int) : AsyncCallback<?> from class org.lealone.net.TransferConnection	From	To
Push Down Method public addAsyncCallback(id int, ac AsyncCallback<?>) : void from class org.lealone.net.AsyncConnection to public addAsyncCallback(id int, ac AsyncCallback<?>) : void from class org.lealone.net.TransferConnection	From	To
Push Down Method private parsePacket(transfer Transfer) : void from class org.lealone.net.AsyncConnection to private parsePacket(transfer Transfer) : void from class org.lealone.net.TransferConnection	From	To
Push Down Method public handle(buffer NetBuffer) : void from class org.lealone.net.AsyncConnection to public handle(buffer NetBuffer) : void from class org.lealone.net.TransferConnection	From	To
Push Down Method protected sendError(transfer Transfer, id int, t Throwable) : void from class org.lealone.net.AsyncConnection to protected sendError(transfer Transfer, id int, t Throwable) : void from class org.lealone.net.TransferConnection	From	To
Pull Up Method	2
Pull Up Method public write(b int) : void from class org.lealone.net.Transfer.ResettableBufferOutputStream to public write(b int) : void from class org.lealone.net.NetBufferOutputStream	From	To
Pull Up Method public write(b byte[], off int, len int) : void from class org.lealone.net.Transfer.ResettableBufferOutputStream to public write(b byte[], off int, len int) : void from class org.lealone.net.NetBufferOutputStream	From	To
Rename Variable	1
Rename Variable ac : AsyncConnection to conn : TcpConnection in method public createConnection(writableChannel WritableChannel, isServer boolean) : AsyncConnection in class org.lealone.server.TcpServer	From	To
Change Return Type	2
Change Return Type AsyncConnection to TcpConnection in method package getTcpConnection() : TcpConnection in class org.lealone.client.ClientSession	From	To
Change Return Type AsyncConnection to TransferConnection in method public getTransferConnection() : TransferConnection in class org.lealone.net.Transfer	From	To
Extract Superclass	2
Extract Superclass org.lealone.net.TransferConnection from classes [org.lealone.p2p.net.P2pConnection]	From	To
Extract Superclass org.lealone.net.NetBufferOutputStream from classes [org.lealone.net.Transfer.ResettableBufferOutputStream]	From	To
Rename Attribute	2
Rename Attribute COMMAND_STORAGE_MESSAGE : int to COMMAND_P2P_MESSAGE : int in class org.lealone.db.Session	From	To
Rename Attribute asyncConnection : AsyncConnection to tcpConnection : TcpConnection in class org.lealone.client.ClientSession	From	To
Change Attribute Type	3
Change Attribute Type connections : LinkedList<AsyncConnection> to connections : LinkedList<TcpConnection> in class org.lealone.net.CommandHandler	From	To
Change Attribute Type conn : AsyncConnection to conn : TransferConnection in class org.lealone.net.Transfer	From	To
Change Attribute Type asyncConnection : AsyncConnection to tcpConnection : TcpConnection in class org.lealone.client.ClientSession	From	To
Extract And Move Method	1
Extract And Move Method public flush() : void extracted from public flush() : void in class org.lealone.net.Transfer & moved to class org.lealone.net.Transfer.ResettableBufferOutputStream	From	To
Rename Parameter	1
Rename Parameter factory : NettyNetClient to nettyNetClient : NettyNetClient in method private openClient(nettyNetClient NettyNetClient, prop Properties) : void in class org.lealone.net.netty.NettyNetClient	From	To

d050b681d2b00ccb6d4674db1ff5f4a4bd6566ad

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: