OpenTripPlanner 98510d481295baa565755a0435464b37334d586c

98510d481295baa565755a0435464b37334d586c

Files Diff

Added: 6
Removed: 3
Renamed: 0
Modified: 27

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private overlappingPlainStreetEdges(u Vertex, v Vertex) : Set<StreetEdge> renamed to private overlappingStreetEdges(u Vertex, v Vertex) : Set<StreetEdge> in class org.opentripplanner.routing.core.RoutingContext	From	To
Move And Rename Method	1
Move And Rename Method public createStreetLocation(graph Graph, label String, name String, edges Iterable<StreetEdge>, nearestPoint Coordinate) : StreetLocation from class org.opentripplanner.routing.location.StreetLocation to public createTemporaryStreetLocation(graph Graph, label String, name String, edges Iterable<StreetEdge>, nearestPoint Coordinate, endVertex boolean) : TemporaryStreetLocation from class org.opentripplanner.routing.impl.StreetVertexIndexServiceImpl	From	To
Change Parameter Type	3
Change Parameter Type other : Vertex to endVertex : boolean in method public getVertexForLocation(loc GenericLocation, options RoutingRequest, endVertex boolean) : Vertex in class org.opentripplanner.routing.impl.StreetVertexIndexServiceImpl	From	To
Change Parameter Type base : StreetLocation to base : TemporaryStreetLocation in method private createHalfLocation(base TemporaryStreetLocation, name String, nearestPoint Coordinate, street StreetEdge, endVertex boolean) : void in class org.opentripplanner.routing.impl.StreetVertexIndexServiceImpl	From	To
Change Parameter Type other : Vertex to endVertex : boolean in method public getVertexForLocation(place GenericLocation, options RoutingRequest, endVertex boolean) : Vertex in class org.opentripplanner.routing.services.StreetVertexIndexService	From	To
Move Method	3
Move Method private createHalfLocation(graph Graph, base StreetLocation, label String, name String, nearestPoint Coordinate, street StreetEdge) : void from class org.opentripplanner.routing.location.StreetLocation to private createHalfLocation(base TemporaryStreetLocation, name String, nearestPoint Coordinate, street StreetEdge, endVertex boolean) : void from class org.opentripplanner.routing.impl.StreetVertexIndexServiceImpl	From	To
Move Method private getGeometry(e StreetEdge, nearestPoint Coordinate) : P2<LineString> from class org.opentripplanner.routing.location.StreetLocation to private getGeometry(e StreetEdge, nearestPoint Coordinate) : P2<LineString> from class org.opentripplanner.routing.impl.StreetVertexIndexServiceImpl	From	To
Move Method private joinPaths(paths List<GraphPath>) : GraphPath from class org.opentripplanner.routing.impl.TravelingSalesmanPathService to private joinPaths(paths List<GraphPath>) : GraphPath from class org.opentripplanner.api.resource.PlanGenerator	From	To
Rename Variable	10
Rename Variable fromLocation : StreetLocation to from : TemporaryStreetLocation in method public testBackExtraEdges() : void in class org.opentripplanner.routing.algorithm.AStarTest	From	To
Rename Variable extras : List<Edge> to edges : Collection<Edge> in method public testStreetLocationFinder() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Rename Variable fromLocation : StreetLocation to from : TemporaryStreetLocation in method public testForwardExtraEdges() : void in class org.opentripplanner.routing.algorithm.AStarTest	From	To
Rename Variable extra : Edge to edge : Edge in method public testStreetLocationFinder() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Rename Variable toLocation : StreetLocation to to : TemporaryStreetLocation in method public testForwardExtraEdges() : void in class org.opentripplanner.routing.algorithm.AStarTest	From	To
Rename Variable extra : List<Edge> to edges : Collection<Edge> in method public testRouteToSameEdgeBackwards() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Rename Variable extra : List<Edge> to edges : Collection<Edge> in method public testRouteToSameEdge() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Rename Variable restriction : TurnRestriction to turnRestriction : TurnRestriction in method public canTurnOnto(e Edge, state State, mode TraverseMode) : boolean in class org.opentripplanner.routing.edgetype.StreetEdge	From	To
Rename Variable toLocation : StreetLocation to to : TemporaryStreetLocation in method public testBackExtraEdges() : void in class org.opentripplanner.routing.algorithm.AStarTest	From	To
Rename Variable extra : List<Edge> to edges : Collection<Edge> in method public testHalfEdges() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Change Return Type	2
Change Return Type StreetLocation to TemporaryStreetLocation in method public createTemporaryStreetLocation(graph Graph, label String, name String, edges Iterable<StreetEdge>, nearestPoint Coordinate, endVertex boolean) : TemporaryStreetLocation in class org.opentripplanner.routing.impl.StreetVertexIndexServiceImpl	From	To
Change Return Type int to void in method public destroy() : void in class org.opentripplanner.routing.core.RoutingContext	From	To
Rename Attribute	1
Rename Attribute highlightedVertex : Vertex to highlightedCoordinate : Coordinate in class org.opentripplanner.visualizer.ShowGraph	From	To
Change Variable Type	15
Change Variable Type extra : List<Edge> to edges : Collection<Edge> in method public testHalfEdges() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Change Variable Type location : StreetLocation to location : TemporaryStreetLocation in method public testStreetLocationFinder() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Change Variable Type toStreetVertex : StreetVertex to toStreetVertex : TemporaryStreetLocation in method private RoutingContext(routingRequest RoutingRequest, graph Graph, from Vertex, to Vertex, findPlaces boolean) in class org.opentripplanner.routing.core.RoutingContext	From	To
Change Variable Type fromLocation : StreetLocation to from : TemporaryStreetLocation in method public testForwardExtraEdges() : void in class org.opentripplanner.routing.algorithm.AStarTest	From	To
Change Variable Type extra : List<Edge> to edges : Collection<Edge> in method public testRouteToSameEdgeBackwards() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Change Variable Type end : StreetLocation to end : TemporaryStreetLocation in method public testStreetLocationFinder() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Change Variable Type extra : List<Edge> to edges : Collection<Edge> in method public testRouteToSameEdge() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Change Variable Type toLocation : StreetLocation to to : TemporaryStreetLocation in method public testBackExtraEdges() : void in class org.opentripplanner.routing.algorithm.AStarTest	From	To
Change Variable Type some : StreetLocation to some : TemporaryStreetLocation in method public testStreetLocationFinder() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Change Variable Type start : StreetLocation to start : TemporaryStreetLocation in method public testStreetLocationFinder() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Change Variable Type fromLocation : StreetLocation to from : TemporaryStreetLocation in method public testBackExtraEdges() : void in class org.opentripplanner.routing.algorithm.AStarTest	From	To
Change Variable Type extras : List<Edge> to edges : Collection<Edge> in method public testStreetLocationFinder() : void in class org.opentripplanner.routing.TestHalfEdges	From	To
Change Variable Type closestStreet : StreetLocation to closestStreet : TemporaryStreetLocation in method private getClosestVertex(location GenericLocation, options RoutingRequest, extraEdges List<Edge>, endVertex boolean) : Vertex in class org.opentripplanner.routing.impl.StreetVertexIndexServiceImpl	From	To
Change Variable Type toLocation : StreetLocation to to : TemporaryStreetLocation in method public testForwardExtraEdges() : void in class org.opentripplanner.routing.algorithm.AStarTest	From	To
Change Variable Type fromStreetVertex : StreetVertex to fromStreetVertex : TemporaryStreetLocation in method private RoutingContext(routingRequest RoutingRequest, graph Graph, from Vertex, to Vertex, findPlaces boolean) in class org.opentripplanner.routing.core.RoutingContext	From	To
Change Attribute Type	1
Change Attribute Type highlightedVertex : Vertex to highlightedCoordinate : Coordinate in class org.opentripplanner.visualizer.ShowGraph	From	To
Extract Method	3
Extract Method private drawCoordinate(c Coordinate, r double) : void extracted from private drawVertex(v Vertex, r double) : void in class org.opentripplanner.visualizer.ShowGraph	From	To
Extract Method protected getTurnRestrictions(graph Graph) : List<TurnRestriction> extracted from public canTurnOnto(e Edge, state State, mode TraverseMode) : boolean in class org.opentripplanner.routing.edgetype.StreetEdge	From	To
Extract Method public highlightCoordinate(c Coordinate) : void extracted from public highlightVertex(v Vertex) : void in class org.opentripplanner.visualizer.ShowGraph	From	To
Rename Parameter	2
Rename Parameter other : Vertex to endVertex : boolean in method public getVertexForLocation(place GenericLocation, options RoutingRequest, endVertex boolean) : Vertex in class org.opentripplanner.routing.services.StreetVertexIndexService	From	To
Rename Parameter other : Vertex to endVertex : boolean in method public getVertexForLocation(loc GenericLocation, options RoutingRequest, endVertex boolean) : Vertex in class org.opentripplanner.routing.impl.StreetVertexIndexServiceImpl	From	To

98510d481295baa565755a0435464b37334d586c

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: