072daf559667b7265bf10ae6138f3343c68dc579
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public taskHistoryUpdateEvent(taskUpdate SingularityTaskHistoryUpdate) : void renamed to public taskWebhook(taskWebhook SingularityTaskWebhook) : void in class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Rename Method public taskHistoryUpdateEvent(taskUpdate SingularityTaskHistoryUpdate) : void renamed to public taskWebhookEvent(taskWebhook SingularityTaskWebhook) : void in class com.hubspot.singularity.data.ZkWebhookQueue | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type taskUpdate : SingularityTaskHistoryUpdate to taskWebhook : SingularityTaskWebhook in method public taskWebhook(taskWebhook SingularityTaskWebhook) : void in class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Change Parameter Type eventListeners : Set<SingularityEventListener> to eventListeners : Set<SingularityEventSender> in method package SingularityEventController(taskHistoryHelper TaskHistoryHelper, eventListeners Set<SingularityEventSender>, configuration SingularityConfiguration, scheduledExecutorServiceFactory SingularityManagedScheduledExecutorServiceFactory) in class com.hubspot.singularity.event.SingularityEventController | From | To | |
| Change Parameter Type taskUpdate : SingularityTaskHistoryUpdate to taskWebhook : SingularityTaskWebhook in method public taskWebhookEvent(taskWebhook SingularityTaskWebhook) : void in class com.hubspot.singularity.data.ZkWebhookQueue | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private taskHistoryHelper : TaskHistoryHelper from class com.hubspot.singularity.hooks.SnsWebhookManager to private taskHistoryHelper : TaskHistoryHelper from class com.hubspot.singularity.hooks.SnsWebhookRetryer | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type eventListener : SingularityEventListener to eventListener : SingularityEventSender in method public taskHistoryUpdateEvent(singularityTaskHistoryUpdate SingularityTaskHistoryUpdate) : void in class com.hubspot.singularity.event.SingularityEventController | From | To | |
| Change Variable Type eventListeners : Multibinder<SingularityEventListener> to eventListeners : Multibinder<SingularityEventSender> in method public configure(binder Binder) : void in class com.hubspot.singularity.event.SingularityEventModule | From | To | |
| Change Variable Type eventListener : SingularityEventListener to eventListener : SingularityEventSender in method public deployHistoryEvent(singularityDeployUpdate SingularityDeployUpdate) : void in class com.hubspot.singularity.event.SingularityEventController | From | To | |
| Change Variable Type eventListener : SingularityEventListener to eventListener : SingularityEventSender in method public requestHistoryEvent(singularityRequestHistory SingularityRequestHistory) : void in class com.hubspot.singularity.event.SingularityEventController | From | To | |
| Extract Interface | 1 | ||
| Extract Interface com.hubspot.singularity.event.SingularityEventSender from classes [com.hubspot.singularity.data.ZkWebhookQueue, com.hubspot.singularity.hooks.SnsWebhookQueue] | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type eventListeners : Set<SingularityEventListener> to eventListeners : Set<SingularityEventSender> in class com.hubspot.singularity.event.SingularityEventController | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter taskUpdate : SingularityTaskHistoryUpdate to taskWebhook : SingularityTaskWebhook in method public taskWebhookEvent(taskWebhook SingularityTaskWebhook) : void in class com.hubspot.singularity.data.ZkWebhookQueue | From | To | |
| Rename Parameter taskUpdate : SingularityTaskHistoryUpdate to taskWebhook : SingularityTaskWebhook in method public taskWebhook(taskWebhook SingularityTaskWebhook) : void in class com.hubspot.singularity.hooks.SnsWebhookManager | From | To |