0a2c91fc28cf326e9929b13dee5eecd4476920b1
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type deployHealthHelper : SingularityDeployHealthHelper to requestHelper : RequestHelper in method public TaskResource(taskRequestManager TaskRequestManager, taskManager TaskManager, slaveManager SlaveManager, mesosClient MesosClient, taskMetadataConfiguration SingularityTaskMetadataConfiguration, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>, requestManager RequestManager, validator SingularityValidator, disasterManager DisasterManager, httpClient AsyncHttpClient, leaderLatch LeaderLatch, objectMapper ObjectMapper, requestHelper RequestHelper) in class com.hubspot.singularity.resources.TaskResource | From | To | |
| Change Parameter Type recentHistory : List<SingularityRequestHistory> to recentHistory : Optional<SingularityRequestHistory> in method public SingularityPendingRequestParent(request SingularityRequest, state RequestState, requestDeployState Optional<SingularityRequestDeployState>, activeDeploy Optional<SingularityDeploy>, pendingDeploy Optional<SingularityDeploy>, pendingDeployState Optional<SingularityPendingDeploy>, pendingRequest SingularityPendingRequest, expiringBounce Optional<SingularityExpiringBounce>, expiringPause Optional<SingularityExpiringPause>, expiringScale Optional<SingularityExpiringScale>, expiringSkipHealthchecks Optional<SingularityExpiringSkipHealthchecks>, taskIds Optional<SingularityTaskIdsByStatus>, recentHistory Optional<SingularityRequestHistory>) in class com.hubspot.singularity.SingularityPendingRequestParent | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute deployHealthHelper : SingularityDeployHealthHelper to requestHelper : RequestHelper in class com.hubspot.singularity.resources.TaskResource | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type deployHealthHelper : SingularityDeployHealthHelper to requestHelper : RequestHelper in class com.hubspot.singularity.resources.TaskResource | From | To | |
| Inline Variable | 1 | ||
| Inline Variable deployState : Optional<SingularityRequestDeployState> in method public fillDataForRequestsAndFilter(requests List<SingularityRequestWithState>, user Optional<SingularityUser>, filterRelevantForUser Boolean, includeTaskIds Boolean, includeLastHistory Boolean, limit Optional<Integer>) : List<SingularityRequestParent> from class com.hubspot.singularity.helpers.RequestHelper | From | To | |
| Extract Method | 1 | ||
| Extract Method private getTaskIdsByStatusForRequest(requestWithState SingularityRequestWithState) : Optional<SingularityTaskIdsByStatus> extracted from public getTaskIdsByStatusForRequest(requestId String) : Optional<SingularityTaskIdsByStatus> in class com.hubspot.singularity.helpers.RequestHelper | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter includeTaskIds : Boolean to includeFullRequestData : Boolean in method public fillDataForRequestsAndFilter(requests List<SingularityRequestWithState>, user Optional<SingularityUser>, filterRelevantForUser Boolean, includeFullRequestData Boolean, limit Optional<Integer>) : List<SingularityRequestParent> in class com.hubspot.singularity.helpers.RequestHelper | From | To | |
| Rename Parameter deployHealthHelper : SingularityDeployHealthHelper to requestHelper : RequestHelper in method public TaskResource(taskRequestManager TaskRequestManager, taskManager TaskManager, slaveManager SlaveManager, mesosClient MesosClient, taskMetadataConfiguration SingularityTaskMetadataConfiguration, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>, requestManager RequestManager, validator SingularityValidator, disasterManager DisasterManager, httpClient AsyncHttpClient, leaderLatch LeaderLatch, objectMapper ObjectMapper, requestHelper RequestHelper) in class com.hubspot.singularity.resources.TaskResource | From | To |