0cd0c0e28a628a24e7b1110a70d48734266cc151
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 2
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public SnsWebhookQueue(objectMapper ObjectMapper, configuration SingularityConfiguration, executorServiceFactory SingularityManagedScheduledExecutorServiceFactory, managedCachedThreadPoolFactory SingularityManagedCachedThreadPoolFactory, webhookManager WebhookManager) from class com.hubspot.singularity.hooks.SnsWebhookQueue to public SnsWebhookManager(objectMapper ObjectMapper, configuration SingularityConfiguration, executorServiceFactory SingularityManagedScheduledExecutorServiceFactory, managedCachedThreadPoolFactory SingularityManagedCachedThreadPoolFactory, webhookManager WebhookManager) from class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Move Method | 3 | ||
| Move Method private getOrCreateSnsTopic(type WebhookType) : String from class com.hubspot.singularity.hooks.SnsWebhookQueue to private getOrCreateSnsTopic(type WebhookType) : String from class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Move Method private publish(type WebhookType, content T) : CompletableFuture<Void> from class com.hubspot.singularity.hooks.SnsWebhookQueue to package publish(type WebhookType, content T) : CompletableFuture<Void> from class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Move Method public checkWebhooks() : void from class com.hubspot.singularity.hooks.SnsWebhookQueue to public checkWebhooks() : void from class com.hubspot.singularity.hooks.SnsWebhookRetryer | From | To | |
| Move Attribute | 8 | ||
| Move Attribute private snsClient : AmazonSNS from class com.hubspot.singularity.hooks.SnsWebhookQueue to private snsClient : AmazonSNS from class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Move Attribute private publishSemaphore : AsyncSemaphore<Void> from class com.hubspot.singularity.hooks.SnsWebhookQueue to private publishSemaphore : AsyncSemaphore<Void> from class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Move Attribute private publishExecutor : ExecutorService from class com.hubspot.singularity.hooks.SnsWebhookQueue to private publishExecutor : ExecutorService from class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Move Attribute private LOG : Logger from class com.hubspot.singularity.hooks.SnsWebhookQueue to private LOG : Logger from class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Move Attribute private objectMapper : ObjectMapper from class com.hubspot.singularity.hooks.SnsWebhookQueue to private objectMapper : ObjectMapper from class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Move Attribute private webhookConf : WebhookQueueConfiguration from class com.hubspot.singularity.hooks.SnsWebhookQueue to private webhookConf : WebhookQueueConfiguration from class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Move Attribute private typeToArn : Map<WebhookType,String> from class com.hubspot.singularity.hooks.SnsWebhookQueue to private typeToArn : Map<WebhookType,String> from class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Move Attribute private webhookManager : WebhookManager from class com.hubspot.singularity.hooks.SnsWebhookQueue to private webhookManager : WebhookManager from class com.hubspot.singularity.hooks.SnsWebhookManager | From | To | |
| Extract Class | 1 | ||
| Extract Class com.hubspot.singularity.hooks.SnsWebhookManager from class com.hubspot.singularity.hooks.SnsWebhookQueue | From | To |