0e3c3065425c4ae39b1b5d8630ae8a33fcfe35a8
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public getTimestamp() : double renamed to public getTimestampSeconds() : double in class com.hubspot.mesos.json.MesosTaskStatisticsObject | From | To | |
| Rename Method public getTimestamp() : double renamed to public getTimestampSeconds() : double in class com.hubspot.singularity.SingularityTaskUsage | From | To | |
| Rename Variable | 1 | ||
| Rename Variable minMillisApart : long to minSecondsApart : long in method package clearOldUsage(taskUsages List<SingularityTaskUsage>, taskId String) : void in class com.hubspot.singularity.scheduler.SingularityUsagePoller | From | To | |
| Parameterize Variable | 3 | ||
| Parameterize Variable taskUsages : int to actualTaskUsages : int in method private testUtilization(utilization SingularityClusterUtilization, expectedTaskUsages int, actualTaskUsages int, cpuReserved double, memMbReserved double, expectedRequestsWithOverUtilizedCpu int, expectedRequestsWithUnderUtilizedCpu int, expectedRequestsWithUnderUtilizedMemBytes int, expectedAvgOverUtilizedCpu double, expectedAvgUnderUtilizedCpu double, expectedAvgUnderUtilizedMemBytes double, expectedMaxOverUtilizedCpu double, expectedMaxUnderUtilizedCpu double, expectedMaxUnderUtilizedMemBytes long, expectedMinOverUtilizedCpu double, expectedMinUnderUtilizedCpu double, expectedMinUnderUtilizedMemBytes long) : void in class com.hubspot.singularity.scheduler.SingularityUsageTest | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute timestamp : double to timestampSeconds : double in class com.hubspot.singularity.SingularityTaskUsage | From | To | |
| Rename Attribute timestamp : double to timestampSeconds : double in class com.hubspot.mesos.json.MesosTaskStatisticsObject | From | To | |
| Extract Method | 3 | ||
| Extract Method private testUtilization(utilization SingularityClusterUtilization, expectedTaskUsages int, actualTaskUsages int, cpuReserved double, memMbReserved double, expectedRequestsWithOverUtilizedCpu int, expectedRequestsWithUnderUtilizedCpu int, expectedRequestsWithUnderUtilizedMemBytes int, expectedAvgOverUtilizedCpu double, expectedAvgUnderUtilizedCpu double, expectedAvgUnderUtilizedMemBytes double, expectedMaxOverUtilizedCpu double, expectedMaxUnderUtilizedCpu double, expectedMaxUnderUtilizedMemBytes long, expectedMinOverUtilizedCpu double, expectedMinUnderUtilizedCpu double, expectedMinUnderUtilizedMemBytes long) : void extracted from public itTracksClusterUtilizationSimple() : void in class com.hubspot.singularity.scheduler.SingularityUsageTest | From | To | |
| Extract Method private testUtilization(utilization SingularityClusterUtilization, expectedTaskUsages int, actualTaskUsages int, cpuReserved double, memMbReserved double, expectedRequestsWithOverUtilizedCpu int, expectedRequestsWithUnderUtilizedCpu int, expectedRequestsWithUnderUtilizedMemBytes int, expectedAvgOverUtilizedCpu double, expectedAvgUnderUtilizedCpu double, expectedAvgUnderUtilizedMemBytes double, expectedMaxOverUtilizedCpu double, expectedMaxUnderUtilizedCpu double, expectedMaxUnderUtilizedMemBytes long, expectedMinOverUtilizedCpu double, expectedMinUnderUtilizedCpu double, expectedMinUnderUtilizedMemBytes long) : void extracted from public itDoesntIncludePerfectlyUtilizedRequestsInClusterUtilization() : void in class com.hubspot.singularity.scheduler.SingularityUsageTest | From | To | |
| Extract Method private testUtilization(utilization SingularityClusterUtilization, expectedTaskUsages int, actualTaskUsages int, cpuReserved double, memMbReserved double, expectedRequestsWithOverUtilizedCpu int, expectedRequestsWithUnderUtilizedCpu int, expectedRequestsWithUnderUtilizedMemBytes int, expectedAvgOverUtilizedCpu double, expectedAvgUnderUtilizedCpu double, expectedAvgUnderUtilizedMemBytes double, expectedMaxOverUtilizedCpu double, expectedMaxUnderUtilizedCpu double, expectedMaxUnderUtilizedMemBytes long, expectedMinOverUtilizedCpu double, expectedMinUnderUtilizedCpu double, expectedMinUnderUtilizedMemBytes long) : void extracted from public itTracksOverusedCpuInClusterUtilization() : void in class com.hubspot.singularity.scheduler.SingularityUsageTest | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter timestamp : double to timestampSeconds : double in method public SingularityTaskUsage(memoryTotalBytes long, timestampSeconds double, cpuSeconds double) in class com.hubspot.singularity.SingularityTaskUsage | From | To | |
| Rename Parameter timestamp : long to timestampSeconds : long in method private getTaskMonitor(id String, cpuSecs double, timestampSeconds long, memBytes int) : MesosTaskMonitorObject in class com.hubspot.singularity.scheduler.SingularityUsageTest | From | To | |
| Rename Parameter timestamp : double to timestampSeconds : double in method public MesosTaskStatisticsObject(cpusLimit int, cpusNrPeriods long, cpusNrThrottled long, cpusSystemTimeSecs double, cpusThrottledTimeSecs double, cpusUserTimeSecs double, memAnonBytes long, memFileBytes long, memLimitBytes long, memMappedFileBytes long, memRssBytes long, memTotalBytes long, timestampSeconds double) in class com.hubspot.mesos.json.MesosTaskStatisticsObject | From | To |