Singularity 11899c4c617fed41ee6ee9c4f33f06f0db245982

11899c4c617fed41ee6ee9c4f33f06f0db245982

Files Diff

Added: 0
Removed: 6
Renamed: 0
Modified: 6

Link to commit

Dependency Action

Refactorings reported:

	Refactoring Name	Occurences
	Move And Inline Method	1
	Move And Inline Method public getLabelsList() : List<SingularityMesosTaskLabel> moved from class com.hubspot.singularity.SingularityDeploy to class com.hubspot.singularity.mesos.SingularityMesosTaskBuilder & inlined to public buildTask(offer Protos.Offer, availableResources List<Resource>, taskRequest SingularityTaskRequest, desiredTaskResources Resources, desiredExecutorResources Resources) : SingularityTask	From	To
	Change Parameter Type	3
	Change Parameter Type labels : Optional<SingularityMesosTaskLabels> to labels : Optional<Map<String,String>> in method public SingularityDeploy(requestId String, id String, command Optional<String>, arguments Optional<List<String>>, containerInfo Optional<SingularityContainerInfo>, customExecutorCmd Optional<String>, customExecutorId Optional<String>, customExecutorSource Optional<String>, customExecutorResources Optional<Resources>, customExecutorUser Optional<String>, resources Optional<Resources>, env Optional<Map<String,String>>, taskEnv Optional<Map<Integer,Map<String,String>>>, uris Optional<List<String>>, metadata Optional<Map<String,String>>, executorData Optional<ExecutorData>, version Optional<String>, timestamp Optional<Long>, labels Optional<Map<String,String>>, taskLabels Optional<Map<Integer,Map<String,String>>>, deployHealthTimeoutSeconds Optional<Long>, healthcheckUri Optional<String>, healthcheckIntervalSeconds Optional<Long>, healthcheckTimeoutSeconds Optional<Long>, healthcheckPortIndex Optional<Integer>, healthcheckMaxRetries Optional<Integer>, healthcheckMaxTotalTimeoutSeconds Optional<Long>, serviceBasePath Optional<String>, loadBalancerGroups Optional<Set<String>>, loadBalancerPortIndex Optional<Integer>, considerHealthyAfterRunningForSeconds Optional<Long>, loadBalancerOptions Optional<Map<String,Object>>, loadBalancerDomains Optional<Set<String>>, loadBalancerAdditionalRoutes Optional<List<String>>, loadBalancerTemplate Optional<String>, skipHealthchecksOnDeploy Optional<Boolean>, healthcheckProtocol Optional<HealthcheckProtocol>, deployInstanceCountPerStep Optional<Integer>, deployStepWaitTimeMs Optional<Integer>, autoAdvanceDeploySteps Optional<Boolean>, maxTaskRetries Optional<Integer>, shell Optional<Boolean>) in class com.hubspot.singularity.SingularityDeploy	From	To
	Change Parameter Type parameters : Optional<SingularityDockerParameters> to parameters : Optional<Map<String,String>> in method public SingularityDockerInfo(image String, privileged boolean, network SingularityDockerNetworkType, portMappings Optional<List<SingularityDockerPortMapping>>, forcePullImage Optional<Boolean>, parameters Optional<Map<String,String>>) in class com.hubspot.mesos.SingularityDockerInfo	From	To
	Change Parameter Type labels : Optional<SingularityMesosTaskLabels> to labels : Optional<Map<String,String>> in method public setLabels(labels Optional<Map<String,String>>) : SingularityDeployBuilder in class com.hubspot.singularity.SingularityDeployBuilder	From	To
	Rename Variable	1
	Rename Variable dockerParameter : SingularityDockerParameter to entry : Map.Entry<String,String> in method private prepareContainerInfo(offer Offer, taskId SingularityTaskId, bldr TaskInfo.Builder, containerInfo SingularityContainerInfo, ports Optional<long[]>) : void in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilder	From	To
	Change Return Type	3
	Change Return Type Optional<SingularityMesosTaskLabels> to Optional<Map<String,String>> in method public getLabels() : Optional<Map<String,String>> in class com.hubspot.singularity.SingularityDeployBuilder	From	To
	Change Return Type Optional<SingularityDockerParameters> to Map<String,String> in method public getParameters() : Map<String,String> in class com.hubspot.mesos.SingularityDockerInfo	From	To
	Change Return Type Optional<SingularityMesosTaskLabels> to Optional<Map<String,String>> in method public getLabels() : Optional<Map<String,String>> in class com.hubspot.singularity.SingularityDeploy	From	To
	Change Variable Type	1
	Change Variable Type dockerParameter : SingularityDockerParameter to entry : Map.Entry<String,String> in method private prepareContainerInfo(offer Offer, taskId SingularityTaskId, bldr TaskInfo.Builder, containerInfo SingularityContainerInfo, ports Optional<long[]>) : void in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilder	From	To
	Change Attribute Type	3
	Change Attribute Type parameters : Optional<SingularityDockerParameters> to parameters : Map<String,String> in class com.hubspot.mesos.SingularityDockerInfo	From	To
	Change Attribute Type labels : Optional<SingularityMesosTaskLabels> to labels : Optional<Map<String,String>> in class com.hubspot.singularity.SingularityDeploy	From	To
	Change Attribute Type labels : Optional<SingularityMesosTaskLabels> to labels : Optional<Map<String,String>> in class com.hubspot.singularity.SingularityDeployBuilder	From	To