12011a0156c7c6b86bf67627d1dca426dd888a05
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 2
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Return Type | 1 | ||
| Change Return Type long to Optional<Long> in method private getRunningAt(updates Collection<SingularityTaskHistoryUpdate>) : Optional<Long> in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type runningAt : long to runningAt : Optional<Long> in method private getHealthcheckedTaskFailure(deploy SingularityDeploy, taskUpdates Map<SingularityTaskId,List<SingularityTaskHistoryUpdate>>, healthcheckResult SingularityTaskHealthcheckResult, taskId SingularityTaskId) : Optional<SingularityDeployFailure> in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method private getRunningAt(updates Collection<SingularityTaskHistoryUpdate>) : Optional<Long> extracted from public getTaskHealth(deploy SingularityDeploy, isDeployPending boolean, healthcheckResult Optional<SingularityTaskHealthcheckResult>, taskId SingularityTaskId) : DeployHealth in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper & moved to class com.hubspot.singularity.scheduler.SingularityHealthchecker | From | To | |
| Extract And Move Method private getRunningAt(updates Collection<SingularityTaskHistoryUpdate>) : Optional<Long> extracted from private healthchecksSkipped(taskId SingularityTaskId, requestHistories List<SingularityRequestHistory>, deploy SingularityDeploy) : boolean in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper & moved to class com.hubspot.singularity.scheduler.SingularityHealthchecker | From | To |