177cfae5046ed7b0e9ba48f23a5882dd6fe2830d
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 1
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 2 | ||
Rename Method public getInactiveDeployTasks(user SingularityUser, requestId String, deployId String, count Integer, page Integer) : List<SingularityTaskIdHistory> renamed to public getInactiveDeployTasksWithMetadata(user SingularityUser, requestId String, deployId String, count Integer, page Integer, skipZk Boolean) : SingularityPaginatedResponse<SingularityTaskIdHistory> in class com.hubspot.singularity.resources.HistoryResource | From | To | |
Rename Method public getInactiveDeployTasksWithMetadata(user SingularityUser, requestId String, deployId String, count Integer, page Integer) : SingularityPaginatedResponse<SingularityTaskIdHistory> renamed to public getRequestHistoryForRequestWithMetadata(user SingularityUser, requestId String, count Integer, page Integer, skipZk Boolean) : SingularityPaginatedResponse<SingularityRequestHistory> in class com.hubspot.singularity.resources.HistoryResource | From | To | |
Change Return Type | 2 | ||
Change Return Type List<SingularityTaskIdHistory> to SingularityPaginatedResponse<SingularityTaskIdHistory> in method public getInactiveDeployTasksWithMetadata(user SingularityUser, requestId String, deployId String, count Integer, page Integer, skipZk Boolean) : SingularityPaginatedResponse<SingularityTaskIdHistory> in class com.hubspot.singularity.resources.HistoryResource | From | To | |
Change Return Type SingularityPaginatedResponse<SingularityTaskIdHistory> to SingularityPaginatedResponse<SingularityRequestHistory> in method public getRequestHistoryForRequestWithMetadata(user SingularityUser, requestId String, count Integer, page Integer, skipZk Boolean) : SingularityPaginatedResponse<SingularityRequestHistory> in class com.hubspot.singularity.resources.HistoryResource | From | To | |
Change Variable Type | 1 | ||
Change Variable Type data : List<SingularityTaskIdHistory> to data : List<SingularityRequestHistory> in method public getRequestHistoryForRequestWithMetadata(user SingularityUser, requestId String, count Integer, page Integer, skipZk Boolean) : SingularityPaginatedResponse<SingularityRequestHistory> in class com.hubspot.singularity.resources.HistoryResource | From | To | |
Extract Variable | 2 | ||
Extract Variable canSkipZk : boolean in method public getInactiveDeployTasksWithMetadata(user SingularityUser, requestId String, deployId String, count Integer, page Integer, skipZk Boolean) : SingularityPaginatedResponse<SingularityTaskIdHistory> from class com.hubspot.singularity.resources.HistoryResource | From | To | |
Extract Variable canSkipZk : boolean in method public getRequestHistoryForRequestWithMetadata(user SingularityUser, requestId String, count Integer, page Integer, skipZk Boolean) : SingularityPaginatedResponse<SingularityRequestHistory> from class com.hubspot.singularity.resources.HistoryResource | From | To |