Singularity 198df4e01597bd3dff48dbeb822d0a5cea103043

198df4e01597bd3dff48dbeb822d0a5cea103043

Files Diff

Added: 12
Removed: 9
Renamed: 0
Modified: 40

Link to commit

Dependency Action
Added
	io.dropwizard:dropwizard-validation:0.7.1
	io.dropwizard:dropwizard-configuration:0.7.1
Updated
	From com.fasterxml.jackson.module:jackson-module-guice 2.4.2 To 2.3.3
	From com.fasterxml.jackson.module:jackson-module-parameter-names 2.3.3 To 2.4.2
	From com.fasterxml.jackson.jaxrs:jackson-jaxrs-smile-provider 2.4.2 To 2.3.3
	From com.fasterxml.jackson.core:jackson-core 2.4.2 To 2.3.3
	From com.fasterxml.jackson.dataformat:jackson-dataformat-yaml 2.4.2 To 2.3.3
	From com.fasterxml.jackson.datatype:jackson-datatype-joda 2.3.3 To 2.4.2
	From com.fasterxml.jackson.module:jackson-module-afterburner 2.3.3 To 2.4.2
	From com.fasterxml.jackson.module:jackson-module-jsonSchema 2.4.2 To 2.3.3
	From com.fasterxml.jackson.datatype:jackson-datatype-hibernate4 2.4.2 To 2.3.3
	From com.fasterxml.jackson.dataformat:jackson-dataformat-cbor 2.4.2 To 2.3.3
	From com.fasterxml.jackson.module:jackson-module-paranamer 2.3.3 To 2.4.2
	From com.fasterxml.jackson.jaxrs:jackson-jaxrs-xml-provider 2.4.2 To 2.3.3
	From com.fasterxml.jackson.module:jackson-module-mrbean 2.3.3 To 2.4.2
	From com.fasterxml.jackson.module:jackson-module-kotlin 2.4.2 To 2.3.3
	From com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider 2.4.2 To 2.3.3
	From com.fasterxml.jackson.module:jackson-module-scala_2.10 2.3.3 To 2.4.2
	From com.fasterxml.jackson.datatype:jackson-datatype-jsr353 2.3.3 To 2.4.2
	From com.fasterxml.jackson.datatype:jackson-datatype-jdk8 2.4.2 To 2.3.3
	From com.fasterxml.jackson.core:jackson-annotations 2.3.3 To 2.4.2
	From com.fasterxml.jackson.datatype:jackson-datatype-jsr310 2.3.3 To 2.4.2
	From com.fasterxml.jackson.datatype:jackson-datatype-jdk7 2.3.3 To 2.4.2
	From com.fasterxml.jackson.dataformat:jackson-dataformat-cbor 2.3.3 To 2.4.2
	From com.fasterxml.jackson.jaxrs:jackson-jaxrs-cbor-provider 2.3.3 To 2.4.2
	From com.fasterxml.jackson.core:jackson-core 2.3.3 To 2.4.2
	From com.fasterxml.jackson.core:jackson-databind 2.4.2 To 2.3.3
	From com.fasterxml.jackson.module:jackson-module-paranamer 2.4.2 To 2.3.3
	From com.fasterxml.jackson.datatype:jackson-datatype-hppc 2.3.3 To 2.4.2
	From com.fasterxml.jackson.datatype:jackson-datatype-json-org 2.4.2 To 2.3.3
	From com.fasterxml.jackson.dataformat:jackson-dataformat-avro 2.3.3 To 2.4.2
	From com.fasterxml.jackson.datatype:jackson-datatype-hibernate3 2.3.3 To 2.4.2
	From com.fasterxml.jackson.jaxrs:jackson-jaxrs-base 2.4.2 To 2.3.3
	From com.fasterxml.jackson.core:jackson-annotations 2.4.2 To 2.3.3
	From com.fasterxml.jackson.datatype:jackson-datatype-joda 2.4.2 To 2.3.3
	From com.fasterxml.jackson.jaxrs:jackson-jaxrs-smile-provider 2.3.3 To 2.4.2
	From com.fasterxml.jackson.module:jackson-module-jaxb-annotations 2.3.3 To 2.4.2
	From com.fasterxml.jackson.dataformat:jackson-dataformat-smile 2.4.2 To 2.3.3
	From com.fasterxml.jackson.module:jackson-module-scala_2.11 2.3.3 To 2.4.2
	From com.fasterxml.jackson.dataformat:jackson-dataformat-csv 2.4.2 To 2.3.3
	From com.fasterxml.jackson.module:jackson-module-jsonSchema 2.3.3 To 2.4.2
	From com.fasterxml.jackson.dataformat:jackson-dataformat-xml 2.3.3 To 2.4.2
	From com.fasterxml.jackson.module:jackson-module-mrbean 2.4.2 To 2.3.3
	From com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider 2.3.3 To 2.4.2
	From com.fasterxml.jackson.module:jackson-module-scala_2.10 2.4.2 To 2.3.3
	From com.fasterxml.jackson.datatype:jackson-datatype-jsr353 2.4.2 To 2.3.3
	From com.fasterxml.jackson.datatype:jackson-datatype-jdk8 2.3.3 To 2.4.2
	From com.fasterxml.jackson.jaxrs:jackson-jaxrs-base 2.3.3 To 2.4.2
	From com.fasterxml.jackson.dataformat:jackson-dataformat-csv 2.3.3 To 2.4.2
	From com.fasterxml.jackson.datatype:jackson-datatype-hppc 2.4.2 To 2.3.3
	From com.fasterxml.jackson.module:jackson-module-afterburner 2.4.2 To 2.3.3
	From com.fasterxml.jackson.module:jackson-module-guice 2.3.3 To 2.4.2
	From com.fasterxml.jackson.datatype:jackson-datatype-guava 2.3.3 To 2.4.2
	From com.fasterxml.jackson.module:jackson-module-parameter-names 2.4.2 To 2.3.3
	From com.fasterxml.jackson.dataformat:jackson-dataformat-avro 2.4.2 To 2.3.3
	From com.fasterxml.jackson.dataformat:jackson-dataformat-yaml 2.3.3 To 2.4.2
	From com.fasterxml.jackson.datatype:jackson-datatype-hibernate3 2.4.2 To 2.3.3
	From com.fasterxml.jackson.datatype:jackson-datatype-hibernate4 2.3.3 To 2.4.2
	From com.fasterxml.jackson.jaxrs:jackson-jaxrs-xml-provider 2.3.3 To 2.4.2
	From com.fasterxml.jackson.dataformat:jackson-dataformat-smile 2.3.3 To 2.4.2
	From com.fasterxml.jackson.module:jackson-module-scala_2.11 2.4.2 To 2.3.3
	From com.fasterxml.jackson.datatype:jackson-datatype-guava 2.4.2 To 2.3.3
	From com.fasterxml.jackson.module:jackson-module-jaxb-annotations 2.4.2 To 2.3.3
	From com.fasterxml.jackson.datatype:jackson-datatype-jsr310 2.4.2 To 2.3.3
	From com.fasterxml.jackson.core:jackson-databind 2.3.3 To 2.4.2
	From com.fasterxml.jackson.datatype:jackson-datatype-json-org 2.3.3 To 2.4.2
	From com.fasterxml.jackson.datatype:jackson-datatype-jdk7 2.4.2 To 2.3.3
	From com.fasterxml.jackson.module:jackson-module-kotlin 2.3.3 To 2.4.2
	From com.fasterxml.jackson.jaxrs:jackson-jaxrs-cbor-provider 2.4.2 To 2.3.3
	From com.fasterxml.jackson.dataformat:jackson-dataformat-xml 2.4.2 To 2.3.3

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	1
Change Parameter Type configuration : SingularityExecutorConfiguration to baseConfiguration : SingularityRunnerBaseConfiguration in method public SingularityExecutorTaskBuilder(jsonObjectMapper ObjectMapper, jsonObjectFileHelper JsonObjectFileHelper, templateManager TemplateManager, executorLogging SingularityExecutorLogging, baseConfiguration SingularityRunnerBaseConfiguration, executorConfiguration SingularityExecutorConfiguration, executorPid String, executorUtils ExecutorUtils, artifactFetcher SingularityExecutorArtifactFetcher) in class com.hubspot.singularity.executor.config.SingularityExecutorTaskBuilder	From	To
Move Method	1
Move Method public obfuscateValue(value String) : String from class com.hubspot.singularity.runner.base.config.SingularityRunnerBaseLogging to public obfuscateValue(value String) : String from class com.hubspot.singularity.runner.base.jackson.ObfuscateAnnotationIntrospector.ObfuscateSerializer	From	To
Change Return Type	6
Change Return Type String to Optional<String> in method public getRootLogPath() : Optional<String> in class com.hubspot.singularity.runner.base.config.SingularityRunnerBaseLogging	From	To
Change Return Type String to int in method public getLogrotateMaxageDays() : int in class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Change Return Type String to int in method public getLogrotateCount() : int in class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Change Return Type Path to String in method public getLogrotateConfDirectory() : String in class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Change Return Type String to int in method public getMaxageDays() : int in class com.hubspot.singularity.executor.models.LogrotateTemplateContext	From	To
Change Return Type String to int in method public getRotateCount() : int in class com.hubspot.singularity.executor.models.LogrotateTemplateContext	From	To
Move Attribute	62
Move Attribute public CHECK_FOR_UPLOADS_EVERY_SECONDS : String from class com.hubspot.singularity.s3uploader.config.SingularityS3UploaderConfigurationLoader to public CHECK_FOR_UPLOADS_EVERY_SECONDS : String from class com.hubspot.singularity.s3uploader.config.SingularityS3UploaderConfiguration	From	To
Move Attribute public HTTP_SERVER_TIMEOUT : String from class com.hubspot.singularity.s3downloader.config.SingularityS3DownloaderConfigurationLoader to public HTTP_SERVER_TIMEOUT : String from class com.hubspot.singularity.s3downloader.config.SingularityS3DownloaderConfiguration	From	To
Move Attribute public CHECK_THREADS_EVERY_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public CHECK_THREADS_EVERY_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public BYTE_BUFFER_CAPACITY : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfigurationLoader to public BYTE_BUFFER_CAPACITY : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfiguration	From	To
Move Attribute public EXECUTOR_MAX_UPLOAD_THREADS : String from class com.hubspot.singularity.s3uploader.config.SingularityS3UploaderConfigurationLoader to public EXECUTOR_MAX_UPLOAD_THREADS : String from class com.hubspot.singularity.s3uploader.config.SingularityS3UploaderConfiguration	From	To
Move Attribute public KILL_PROCESS_DIRECTLY_THRESHOLD_RATIO : String from class com.hubspot.singularity.oomkiller.config.SingularityOOMKillerConfigurationLoader to public KILL_PROCESS_DIRECTLY_THRESHOLD_RATIO : String from class com.hubspot.singularity.oomkiller.config.SingularityOOMKillerConfiguration	From	To
Move Attribute public LOCAL_DOWNLOAD_HTTP_DOWNLOAD_PATH : String from class com.hubspot.singularity.s3.base.config.SingularityS3ConfigurationLoader to public LOCAL_DOWNLOAD_HTTP_DOWNLOAD_PATH : String from class com.hubspot.singularity.s3.base.config.SingularityS3Configuration	From	To
Move Attribute public STORE_SUFFIX : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfigurationLoader to public STORE_SUFFIX : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfiguration	From	To
Move Attribute public S3_DOWNLOAD_TIMEOUT_MILLIS : String from class com.hubspot.singularity.s3.base.config.SingularityS3ConfigurationLoader to public S3_DOWNLOAD_TIMEOUT_MILLIS : String from class com.hubspot.singularity.s3.base.config.SingularityS3Configuration	From	To
Move Attribute public LOGROTATE_EXTRAS_DATEFORMAT : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public LOGROTATE_EXTRAS_DATEFORMAT : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public NUM_CORE_KILL_THREADS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public NUM_CORE_KILL_THREADS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public LOCAL_DOWNLOAD_SERVICE_TIMEOUT_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public LOCAL_DOWNLOAD_SERVICE_TIMEOUT_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public TAIL_LOG_FILENAME : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public TAIL_LOG_FILENAME : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public MAX_TASK_THREADS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public MAX_TASK_THREADS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public POLL_MILLIS : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfigurationLoader to public POLL_MILLIS : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfiguration	From	To
Move Attribute public S3_SECRET_KEY : String from class com.hubspot.singularity.s3.base.config.SingularityS3ConfigurationLoader to public S3_SECRET_KEY : String from class com.hubspot.singularity.s3.base.config.SingularityS3Configuration	From	To
Move Attribute public REQUEST_KILL_THRESHOLD_RATIO : String from class com.hubspot.singularity.oomkiller.config.SingularityOOMKillerConfigurationLoader to public REQUEST_KILL_THRESHOLD_RATIO : String from class com.hubspot.singularity.oomkiller.config.SingularityOOMKillerConfiguration	From	To
Move Attribute public TASK_SERVICE_LOG_PATH : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public TASK_SERVICE_LOG_PATH : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public LOCAL_DOWNLOAD_HTTP_PORT : String from class com.hubspot.singularity.s3.base.config.SingularityS3ConfigurationLoader to public LOCAL_DOWNLOAD_HTTP_PORT : String from class com.hubspot.singularity.s3.base.config.SingularityS3Configuration	From	To
Move Attribute public STORE_DIRECTORY : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfigurationLoader to public STORE_DIRECTORY : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfiguration	From	To
Move Attribute public GLOBAL_TASK_DEFINITION_SUFFIX : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public GLOBAL_TASK_DEFINITION_SUFFIX : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public IDLE_EXECUTOR_SHUTDOWN_AFTER_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public IDLE_EXECUTOR_SHUTDOWN_AFTER_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public LOGROTATE_DATEFORMAT : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public LOGROTATE_DATEFORMAT : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public STOP_CHECKING_AFTER_HOURS_WITHOUT_NEW_FILE : String from class com.hubspot.singularity.s3uploader.config.SingularityS3UploaderConfigurationLoader to public STOP_CHECKING_AFTER_HOURS_WITHOUT_NEW_FILE : String from class com.hubspot.singularity.s3uploader.config.SingularityS3UploaderConfiguration	From	To
Move Attribute public CGROUP_PROCS_PATH_FORMAT : String from class com.hubspot.singularity.oomkiller.config.SingularityOOMKillerConfigurationLoader to public CGROUP_PROCS_PATH_FORMAT : String from class com.hubspot.singularity.oomkiller.config.SingularityOOMKillerConfiguration	From	To
Move Attribute public TAIL_LOG_LINES_TO_SAVE : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public TAIL_LOG_LINES_TO_SAVE : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public LOGROTATE_COUNT : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public LOGROTATE_COUNT : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public HARD_KILL_AFTER_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public HARD_KILL_AFTER_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public FLUENTD_HOSTS : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfigurationLoader to public FLUENTD_HOSTS : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfiguration	From	To
Move Attribute public SLAVE_HOSTNAME : String from class com.hubspot.singularity.oomkiller.config.SingularityOOMKillerConfigurationLoader to public SLAVE_HOSTNAME : String from class com.hubspot.singularity.oomkiller.config.SingularityOOMKillerConfiguration	From	To
Move Attribute public POLL_MILLIS : String from class com.hubspot.singularity.s3uploader.config.SingularityS3UploaderConfigurationLoader to public POLL_MILLIS : String from class com.hubspot.singularity.s3uploader.config.SingularityS3UploaderConfiguration	From	To
Move Attribute public DEFAULT_USER : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public DEFAULT_USER : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public SAFE_MODE_WONT_RUN_WITH_NO_TASKS : String from class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfigurationLoader to public SAFE_MODE_WONT_RUN_WITH_NO_TASKS : String from class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfiguration	From	To
Move Attribute public EXECUTOR_CLEANUP_RESULTS_SUFFIX : String from class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfigurationLoader to public EXECUTOR_CLEANUP_RESULTS_SUFFIX : String from class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfiguration	From	To
Move Attribute public SHUTDOWN_STOP_DRIVER_AFTER_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public SHUTDOWN_STOP_DRIVER_AFTER_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public NUM_CORE_THREAD_CHECK_THREADS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public NUM_CORE_THREAD_CHECK_THREADS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public S3_FILES_TO_BACKUP : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public S3_FILES_TO_BACKUP : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public S3_CHUNK_SIZE : String from class com.hubspot.singularity.s3.base.config.SingularityS3ConfigurationLoader to public S3_CHUNK_SIZE : String from class com.hubspot.singularity.s3.base.config.SingularityS3Configuration	From	To
Move Attribute public LOGROTATE_MAXAGE_DAYS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public LOGROTATE_MAXAGE_DAYS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public TASK_EXECUTOR_BASH_LOG_PATH : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public TASK_EXECUTOR_BASH_LOG_PATH : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public USE_LOCAL_DOWNLOAD_SERVICE : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public USE_LOCAL_DOWNLOAD_SERVICE : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public EXECUTOR_CLEANUP_CLEANUP_APP_DIRECTORY_OF_FAILED_TASKS_AFTER_MILLIS : String from class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfigurationLoader to public EXECUTOR_CLEANUP_CLEANUP_APP_DIRECTORY_OF_FAILED_TASKS_AFTER_MILLIS : String from class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfiguration	From	To
Move Attribute public LOGROTATE_CONFIG_DIRECTORY : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public LOGROTATE_CONFIG_DIRECTORY : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public LOGROTATE_DIRECTORY : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public LOGROTATE_DIRECTORY : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public GLOBAL_TASK_DEFINITION_DIRECTORY : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public GLOBAL_TASK_DEFINITION_DIRECTORY : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public CHECK_FOR_OOM_EVERY_MILLIS : String from class com.hubspot.singularity.oomkiller.config.SingularityOOMKillerConfigurationLoader to public CHECK_FOR_OOM_EVERY_MILLIS : String from class com.hubspot.singularity.oomkiller.config.SingularityOOMKillerConfiguration	From	To
Move Attribute public FLUENTD_TAG_PREFIX : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfigurationLoader to public FLUENTD_TAG_PREFIX : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfiguration	From	To
Move Attribute public ARTIFACT_CACHE_DIRECTORY : String from class com.hubspot.singularity.s3.base.config.SingularityS3ConfigurationLoader to public ARTIFACT_CACHE_DIRECTORY : String from class com.hubspot.singularity.s3.base.config.SingularityS3Configuration	From	To
Move Attribute public S3_ACCESS_KEY : String from class com.hubspot.singularity.s3.base.config.SingularityS3ConfigurationLoader to public S3_ACCESS_KEY : String from class com.hubspot.singularity.s3.base.config.SingularityS3Configuration	From	To
Move Attribute public MAX_TASK_MESSAGE_LENGTH : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public MAX_TASK_MESSAGE_LENGTH : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public RETRY_DELAY_SECONDS : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfigurationLoader to public RETRY_DELAY_SECONDS : String from class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfiguration	From	To
Move Attribute public LOGROTATE_EXTRAS_FILES : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public LOGROTATE_EXTRAS_FILES : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public LOGROTATE_COMMAND : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public LOGROTATE_COMMAND : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public S3_UPLOADER_BUCKET : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public S3_UPLOADER_BUCKET : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public EXECUTOR_CLEANUP_RESULTS_DIRECTORY : String from class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfigurationLoader to public EXECUTOR_CLEANUP_RESULTS_DIRECTORY : String from class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfiguration	From	To
Move Attribute public NUM_DOWNLOADER_THREADS : String from class com.hubspot.singularity.s3downloader.config.SingularityS3DownloaderConfigurationLoader to public NUM_DOWNLOADER_THREADS : String from class com.hubspot.singularity.s3downloader.config.SingularityS3DownloaderConfiguration	From	To
Move Attribute public LOGROTATE_AFTER_BYTES : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public LOGROTATE_AFTER_BYTES : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public LOGROTATE_STATE_FILE : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public LOGROTATE_STATE_FILE : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public TASK_EXECUTOR_JAVA_LOG_PATH : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public TASK_EXECUTOR_JAVA_LOG_PATH : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public SHUTDOWN_TIMEOUT_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public SHUTDOWN_TIMEOUT_MILLIS : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public S3_UPLOADER_PATTERN : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public S3_UPLOADER_PATTERN : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Move Attribute public TASK_APP_DIRECTORY : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfigurationLoader to public TASK_APP_DIRECTORY : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Extract Superclass	1
Extract Superclass com.hubspot.singularity.runner.base.configuration.BaseRunnerConfiguration from classes [com.hubspot.singularity.executor.config.SingularityExecutorConfiguration, com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfiguration, com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfiguration, com.hubspot.singularity.oomkiller.config.SingularityOOMKillerConfiguration, com.hubspot.singularity.s3.base.config.SingularityS3Configuration, com.hubspot.singularity.s3downloader.config.SingularityS3DownloaderConfiguration, com.hubspot.singularity.s3uploader.config.SingularityS3UploaderConfiguration]	From	To
Rename Attribute	4
Rename Attribute configurations : SingularityConfigurationLoader[] to additionalConfigurationClasses : Set<Class<? extends BaseRunnerConfiguration>> in class com.hubspot.singularity.runner.base.config.SingularityRunnerBaseModule	From	To
Rename Attribute properties : Properties to validator : Validator in class com.hubspot.singularity.runner.base.config.SingularityRunnerBaseLogging	From	To
Rename Attribute rootLogPath : String to loggingConfiguration : SingularityRunnerBaseLoggingConfiguration in class com.hubspot.singularity.runner.base.config.SingularityRunnerBaseLogging	From	To
Rename Attribute hubSpotLogLevel : String to baseConfiguration : SingularityRunnerBaseConfiguration in class com.hubspot.singularity.runner.base.config.SingularityRunnerBaseLogging	From	To
Inline Variable	1
Inline Variable rootLogger : Logger in method public SingularityRunnerBaseLogging(rootLogDirectory String, rootLogFilename String, loggingPattern String, rootLogLevel String, hubSpotLogLevel String, obfuscateKeys String, properties Properties) from class com.hubspot.singularity.runner.base.config.SingularityRunnerBaseLogging	From	To
Split Attribute	1
Split Attribute configuration : SingularityExecutorConfiguration to [executorConfiguration : SingularityExecutorConfiguration, baseConfiguration : SingularityRunnerBaseConfiguration] in class com.hubspot.singularity.executor.config.SingularityExecutorTaskBuilder	From	To
Change Attribute Type	10
Change Attribute Type rootLogPath : String to loggingConfiguration : SingularityRunnerBaseLoggingConfiguration in class com.hubspot.singularity.runner.base.config.SingularityRunnerBaseLogging	From	To
Change Attribute Type executorCleanupResultsDirectory : Path to executorCleanupResultsDirectory : String in class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfiguration	From	To
Change Attribute Type logrotateConfDirectory : Path to logrotateConfDirectory : String in class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Change Attribute Type configurations : SingularityConfigurationLoader[] to additionalConfigurationClasses : Set<Class<? extends BaseRunnerConfiguration>> in class com.hubspot.singularity.runner.base.config.SingularityRunnerBaseModule	From	To
Change Attribute Type storeDirectory : Path to storeDirectory : String in class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfiguration	From	To
Change Attribute Type logrotateMaxageDays : String to logrotateMaxageDays : int in class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Change Attribute Type hubSpotLogLevel : String to baseConfiguration : SingularityRunnerBaseConfiguration in class com.hubspot.singularity.runner.base.config.SingularityRunnerBaseLogging	From	To
Change Attribute Type logrotateCount : String to logrotateCount : int in class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration	From	To
Change Attribute Type fluentdHosts : List<FluentdHost> to fluentdHosts : String in class com.hubspot.singularity.logwatcher.config.SingularityLogWatcherConfiguration	From	To
Change Attribute Type properties : Properties to validator : Validator in class com.hubspot.singularity.runner.base.config.SingularityRunnerBaseLogging	From	To
Rename Parameter	3
Rename Parameter configuration : SingularityExecutorConfiguration to baseConfiguration : SingularityRunnerBaseConfiguration in method public SingularityExecutorTaskBuilder(jsonObjectMapper ObjectMapper, jsonObjectFileHelper JsonObjectFileHelper, templateManager TemplateManager, executorLogging SingularityExecutorLogging, baseConfiguration SingularityRunnerBaseConfiguration, executorConfiguration SingularityExecutorConfiguration, executorPid String, executorUtils ExecutorUtils, artifactFetcher SingularityExecutorArtifactFetcher) in class com.hubspot.singularity.executor.config.SingularityExecutorTaskBuilder	From	To
Rename Parameter configuration : SingularityExecutorConfiguration to executorConfiguration : SingularityExecutorConfiguration in method public SingularityExecutorTaskBuilder(jsonObjectMapper ObjectMapper, jsonObjectFileHelper JsonObjectFileHelper, templateManager TemplateManager, executorLogging SingularityExecutorLogging, baseConfiguration SingularityRunnerBaseConfiguration, executorConfiguration SingularityExecutorConfiguration, executorPid String, executorUtils ExecutorUtils, artifactFetcher SingularityExecutorArtifactFetcher) in class com.hubspot.singularity.executor.config.SingularityExecutorTaskBuilder	From	To
Rename Parameter configuration : SingularityExecutorConfiguration to executorConfiguration : SingularityExecutorConfiguration in method public SingularityExecutorTask(driver ExecutorDriver, executorUtils ExecutorUtils, baseConfiguration SingularityRunnerBaseConfiguration, executorConfiguration SingularityExecutorConfiguration, taskDefinition SingularityExecutorTaskDefinition, executorPid String, artifactFetcher SingularityExecutorArtifactFetcher, taskInfo Protos.TaskInfo, templateManager TemplateManager, objectMapper ObjectMapper, log Logger, jsonObjectFileHelper JsonObjectFileHelper) in class com.hubspot.singularity.executor.task.SingularityExecutorTask	From	To

198df4e01597bd3dff48dbeb822d0a5cea103043

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: