19cd0fe43bff0480e8d459f43f51eaad4e7b4b1f
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public getDefaultDeployStepWaitTimeSeconds() : int renamed to public getDefaultDeployStepWaitTimeMs() : int in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Method public getDeployStepWaitTimeSeconds() : Optional<Integer> renamed to public getDeployStepWaitTimeMs() : Optional<Integer> in class com.hubspot.singularity.SingularityDeploy | From | To | |
| Rename Method public getDeployStepWaitTimeSeconds() : long renamed to public getDeployStepWaitTimeMs() : long in class com.hubspot.singularity.SingularityDeployProgress | From | To | |
| Rename Method public setDefaultDeployStepWaitTimeSeconds(defaultDeployStepWaitTimeSeconds int) : void renamed to public setDefaultDeployStepWaitTimeMs(defaultDeployStepWaitTimeMs int) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute defaultDeployStepWaitTimeSeconds : int to defaultDeployStepWaitTimeMs : int in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Attribute deployStepWaitTimeSeconds : Optional<Integer> to deployStepWaitTimeMs : Optional<Integer> in class com.hubspot.singularity.SingularityDeploy | From | To | |
| Rename Attribute deployStepWaitTimeSeconds : long to deployStepWaitTimeMs : long in class com.hubspot.singularity.SingularityDeployProgress | From | To | |
| Inline Variable | 1 | ||
| Inline Variable isCancelRequestPresent : boolean in method private checkDeployProgress(request SingularityRequest, cancelRequest Optional<SingularityDeployMarker>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>, deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>) : SingularityDeployResult from class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract Method | 2 | ||
| Extract Method private checkMoveToNextDeployStep(request SingularityRequest, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>) : SingularityDeployResult extracted from private checkDeployProgress(request SingularityRequest, cancelRequest Optional<SingularityDeployMarker>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>, deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract Method private processLbState(request SingularityRequest, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>, lbUpdate SingularityLoadBalancerUpdate) : SingularityDeployResult extracted from private checkDeployProgress(request SingularityRequest, cancelRequest Optional<SingularityDeployMarker>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>, deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public withNewInstances(instances int) : SingularityDeployProgress extracted from private maybeUpdatePendingRequest(pendingDeploy SingularityPendingDeploy, deploy Optional<SingularityDeploy>, request SingularityRequest, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>, lbUpdate Optional<SingularityLoadBalancerUpdate>) : void in class com.hubspot.singularity.scheduler.SingularityDeployChecker & moved to class com.hubspot.singularity.SingularityDeployProgress | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter deployStepWaitTimeSeconds : Optional<Integer> to deployStepWaitTimeMs : Optional<Integer> in method public SingularityDeploy(requestId String, id String, command Optional<String>, arguments Optional<List<String>>, containerInfo Optional<SingularityContainerInfo>, customExecutorCmd Optional<String>, customExecutorId Optional<String>, customExecutorSource Optional<String>, customExecutorResources Optional<Resources>, customExecutorUser Optional<String>, resources Optional<Resources>, env Optional<Map<String,String>>, uris Optional<List<String>>, metadata Optional<Map<String,String>>, executorData Optional<ExecutorData>, version Optional<String>, timestamp Optional<Long>, labels Optional<Map<String,String>>, deployHealthTimeoutSeconds Optional<Long>, healthcheckUri Optional<String>, healthcheckIntervalSeconds Optional<Long>, healthcheckTimeoutSeconds Optional<Long>, healthcheckMaxRetries Optional<Integer>, healthcheckMaxTotalTimeoutSeconds Optional<Long>, serviceBasePath Optional<String>, loadBalancerGroups Optional<Set<String>>, considerHealthyAfterRunningForSeconds Optional<Long>, loadBalancerOptions Optional<Map<String,Object>>, skipHealthchecksOnDeploy Optional<Boolean>, healthcheckProtocol Optional<HealthcheckProtocol>, deployInstanceCountPerStep Optional<Integer>, deployStepWaitTimeMs Optional<Integer>, autoAdvanceDeploySteps Optional<Boolean>) in class com.hubspot.singularity.SingularityDeploy | From | To | |
| Rename Parameter defaultDeployStepWaitTimeSeconds : int to defaultDeployStepWaitTimeMs : int in method public setDefaultDeployStepWaitTimeMs(defaultDeployStepWaitTimeMs int) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Parameter deployStepWaitTimeSeconds : long to deployStepWaitTimeMs : long in method public SingularityDeployProgress(targetActiveInstances int, deployInstanceCountPerStep int, deployStepWaitTimeMs long, stepComplete boolean, autoAdvanceDeploySteps boolean, timestamp long) in class com.hubspot.singularity.SingularityDeployProgress | From | To |