1c246046ac35952f5c7686b1362b210182d99fd1
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 19
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 1 | ||
Change Parameter Type commandLineArgs : String to commandLineArgs : List<String> in method public scheduleImmediately(requestId String, user Optional<String>, commandLineArgs List<String>) : SingularityRequestParent in class com.hubspot.singularity.resources.RequestResource | From | To | |
Change Return Type | 1 | ||
Change Return Type SingularityPendingTask to Optional<SingularityPendingTask> in method public getPendingTask(pendingTaskId SingularityPendingTaskId) : Optional<SingularityPendingTask> in class com.hubspot.singularity.data.TaskManager | From | To | |
Move Attribute | 1 | ||
Move Attribute private cmdLineArgs : Optional<String> from class com.hubspot.singularity.SingularityPendingRequest to private cmdLineArgs : Optional<String> from class com.hubspot.singularity.data.zkmigrations.SingularityCmdLineArgsMigration.SingularityPendingRequestPrevious | From | To | |
Rename Attribute | 3 | ||
Rename Attribute taskId : SingularityPendingTaskId to pendingTaskId : SingularityPendingTaskId in class com.hubspot.singularity.SingularityPendingTask | From | To | |
Rename Attribute maybeCmdLineArgs : Optional<String> to cmdLineArgs : List<String> in class com.hubspot.singularity.SingularityPendingTask | From | To | |
Rename Attribute cmdLineArgs : Optional<String> to cmdLineArgsList : List<String> in class com.hubspot.singularity.SingularityPendingRequest | From | To | |
Change Variable Type | 1 | ||
Change Variable Type pendingTask : SingularityPendingTask to pendingTask : Optional<SingularityPendingTask> in method public getPendingTask(pendingTaskIdStr String) : SingularityTaskRequest in class com.hubspot.singularity.resources.TaskResource | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type maybeCmdLineArgs : Optional<String> to cmdLineArgs : List<String> in class com.hubspot.singularity.SingularityPendingTask | From | To | |
Change Attribute Type cmdLineArgs : Optional<String> to cmdLineArgsList : List<String> in class com.hubspot.singularity.SingularityPendingRequest | From | To | |
Rename Parameter | 1 | ||
Rename Parameter taskId : SingularityPendingTaskId to pendingTaskId : SingularityPendingTaskId in method public SingularityPendingTask(pendingTaskId SingularityPendingTaskId, cmdLineArgs List<String>) in class com.hubspot.singularity.SingularityPendingTask | From | To |