1f84d1f70574137cd9e066e68ddabd73c760c48c
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 3
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 2 | ||
Rename Method public getNumHealthyTasks(request SingularityRequest, deploy Optional<SingularityDeploy>, activeTasks Collection<SingularityTaskId>, isDeployPending boolean) : int renamed to public getHealthyTasks(request SingularityRequest, deploy Optional<SingularityDeploy>, activeTasks Collection<SingularityTaskId>, isDeployPending boolean) : List<SingularityTaskId> in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To | |
Rename Method private getNumHealthcheckedHealthyTasks(deploy SingularityDeploy, matchingActiveTasks Collection<SingularityTaskId>, isDeployPending boolean) : int renamed to private getHealthcheckedHealthyTasks(deploy SingularityDeploy, matchingActiveTasks Collection<SingularityTaskId>, isDeployPending boolean) : List<SingularityTaskId> in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To | |
Rename Variable | 1 | ||
Rename Variable healthyReplaceMentTasks : int to healthyReplacementTasks : int in method private shouldKillTask(taskCleanup SingularityTaskCleanup, activeTaskIds List<SingularityTaskId>, cleaningTasks List<SingularityTaskId>, incrementalBounceCleaningTasks Multiset<SingularityDeployKey>) : boolean in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
Change Return Type | 3 | ||
Change Return Type int to List<SingularityTaskId> in method private getHealthcheckedHealthyTasks(deploy SingularityDeploy, matchingActiveTasks Collection<SingularityTaskId>, isDeployPending boolean) : List<SingularityTaskId> in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To | |
Change Return Type int to List<SingularityTaskId> in method public getHealthyTasks(request SingularityRequest, deploy Optional<SingularityDeploy>, activeTasks Collection<SingularityTaskId>, isDeployPending boolean) : List<SingularityTaskId> in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To | |
Change Return Type int to List<SingularityTaskId> in method private getNoHealthcheckHealthyTasks(deploy Optional<SingularityDeploy>, matchingActiveTasks Collection<SingularityTaskId>) : List<SingularityTaskId> in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To |