20bdd4fb88c0717b4e25ef4812b833ff9046427d
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private performUploadCallable(uploader SingularityUploader, finished boolean, immediate boolean) : Callable<Integer> renamed to private performUploadSupplier(uploader SingularityUploader, finished boolean, immediate boolean) : Supplier<Integer> in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Callable<Integer> to Supplier<Integer> in method private performUploadSupplier(uploader SingularityUploader, finished boolean, immediate boolean) : Supplier<Integer> in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver | From | To | |
| Change Return Type void to int in method package uploadBatch(toUpload List<Path>) : int in class com.hubspot.singularity.s3uploader.SingularityUploader | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute immediateUploaders : ConcurrentMap<SingularityUploader,Future<Integer>> to immediateUploadersFutures : Map<S3UploadMetadata,CompletableFuture<Integer>> in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type futures : Map<SingularityUploader,Future<Integer>> to futures : Map<SingularityUploader,CompletableFuture<Integer>> in method private checkUploads() : int in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver | From | To | |
| Change Variable Type toRemove : List<SingularityUploader> to toRemove : List<S3UploadMetadata> in method private checkUploads() : int in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver | From | To | |
| Change Variable Type uploaderToFuture : Entry<SingularityUploader,Future<Integer>> to uploaderToFuture : Entry<SingularityUploader,CompletableFuture<Integer>> in method private checkUploads() : int in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver | From | To | |
| Change Variable Type toRetry : List<SingularityUploader> to toRetry : List<S3UploadMetadata> in method private checkUploads() : int in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver | From | To | |
| Change Variable Type entry : Map.Entry<SingularityUploader,Future<Integer>> to entry : Map.Entry<S3UploadMetadata,CompletableFuture<Integer>> in method private checkUploads() : int in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver | From | To | |
| Extract Method | 1 | ||
| Extract Method package filesToUpload(isFinished boolean) : List<Path> extracted from package upload(isFinished boolean) : int in class com.hubspot.singularity.s3uploader.SingularityUploader | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type immediateUploaders : ConcurrentMap<SingularityUploader,Future<Integer>> to immediateUploadersFutures : Map<S3UploadMetadata,CompletableFuture<Integer>> in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver | From | To |