224dfead599c85d1b02bb5b04bf31edd3478c376
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [currentStats : Optional<SingularityDisasterStats>, lastStats : Optional<SingularityDisasterStats>] to stats : List<SingularityDisasterDataPoint> in class com.hubspot.singularity.SingularityDisastersData | From | To | |
| Rename Method | 3 | ||
| Rename Method private collectNewStats() : SingularityDisasterStats renamed to private collectDisasterStats() : SingularityDisasterDataPoint in class com.hubspot.singularity.scheduler.SingularityDisasterDetectionPoller | From | To | |
| Rename Method public isautomatedActionsDisabled() : boolean renamed to public isAutomatedActionsDisabled() : boolean in class com.hubspot.singularity.SingularityDisastersData | From | To | |
| Rename Method private checkStats(lastStats Optional<SingularityDisasterStats>, newStats SingularityDisasterStats) : List<SingularityDisasterType> renamed to private checkDataPoints(dataPoints List<SingularityDisasterDataPoint>) : List<SingularityDisasterType> in class com.hubspot.singularity.scheduler.SingularityDisasterDetectionPoller | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type disasterStatsTranscoder : Transcoder<SingularityDisasterStats> to disasterStatsTranscoder : Transcoder<SingularityDisasterDataPoints> in method public DisasterManager(curator CuratorFramework, configuration SingularityConfiguration, metricRegistry MetricRegistry, disabledActionTranscoder Transcoder<SingularityDisabledAction>, disasterStatsTranscoder Transcoder<SingularityDisasterDataPoints>) in class com.hubspot.singularity.data.DisasterManager | From | To | |
| Change Parameter Type stats : SingularityDisasterStats to stats : SingularityDisasterDataPoints in method public saveDisasterStats(stats SingularityDisasterDataPoints) : void in class com.hubspot.singularity.data.DisasterManager | From | To | |
| Rename Variable | 1 | ||
| Rename Variable lastStats : Optional<SingularityDisasterStats> to dataPoints : List<SingularityDisasterDataPoint> in method public runActionOnPoll() : void in class com.hubspot.singularity.scheduler.SingularityDisasterDetectionPoller | From | To | |
| Change Return Type | 2 | ||
| Change Return Type SingularityDisasterStats to SingularityDisasterDataPoint in method private collectDisasterStats() : SingularityDisasterDataPoint in class com.hubspot.singularity.scheduler.SingularityDisasterDetectionPoller | From | To | |
| Change Return Type Optional<SingularityDisasterStats> to SingularityDisasterDataPoints in method public getDisasterStats() : SingularityDisasterDataPoints in class com.hubspot.singularity.data.DisasterManager | From | To | |
| Rename Class | 1 | ||
| Rename Class com.hubspot.singularity.SingularityDisasterStats renamed to com.hubspot.singularity.SingularityDisasterDataPoint | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type pendingTasks : List<SingularityPendingTask> to pendingTasks : List<SingularityPendingTaskId> in method private collectDisasterStats() : SingularityDisasterDataPoint in class com.hubspot.singularity.scheduler.SingularityDisasterDetectionPoller | From | To | |
| Change Variable Type lastStats : Optional<SingularityDisasterStats> to dataPoints : List<SingularityDisasterDataPoint> in method public runActionOnPoll() : void in class com.hubspot.singularity.scheduler.SingularityDisasterDetectionPoller | From | To | |
| Change Variable Type newStats : SingularityDisasterStats to newStats : SingularityDisasterDataPoint in method public runActionOnPoll() : void in class com.hubspot.singularity.scheduler.SingularityDisasterDetectionPoller | From | To | |
| Change Variable Type that : SingularityDisasterStats to that : SingularityDisasterDataPoint in method public equals(o Object) : boolean in class com.hubspot.singularity.SingularityDisasterDataPoint | From | To | |
| Change Variable Type pendingTask : SingularityPendingTask to pendingTask : SingularityPendingTaskId in method private collectDisasterStats() : SingularityDisasterDataPoint in class com.hubspot.singularity.scheduler.SingularityDisasterDetectionPoller | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type disasterStatsTranscoder : Transcoder<SingularityDisasterStats> to disasterStatsTranscoder : Transcoder<SingularityDisasterDataPoints> in class com.hubspot.singularity.data.DisasterManager | From | To |