2ed3bbacf18c6e71a4cd132a3ef236a3fb94f3b0
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type healthcheckTimeoutSeconds : long to healthcheckTimeoutSeconds : int in method public setHealthcheckTimeoutSeconds(healthcheckTimeoutSeconds int) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Parameter Type healthcheckIntervalSeconds : long to healthcheckIntervalSeconds : int in method public setHealthcheckIntervalSeconds(healthcheckIntervalSeconds int) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Variable | 2 | ||
| Rename Variable healthcheckMaxTotalTimeoutSeconds : Optional<Long> to startupTime : int in method public getMaxHealthcheckTimeoutSeconds(options HealthcheckOptions) : int in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To | |
| Rename Variable healthcheckMaxRetries : Optional<Integer> to intervalSeconds : int in method public getMaxHealthcheckTimeoutSeconds(options HealthcheckOptions) : int in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To | |
| Change Return Type | 2 | ||
| Change Return Type long to int in method public getHealthcheckIntervalSeconds() : int in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Return Type long to int in method public getHealthcheckTimeoutSeconds() : int in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Extract Variable | 1 | ||
| Extract Variable inStartup : boolean in method public saveResult(statusCode Optional<Integer>, responseBody Optional<String>, errorMessage Optional<String>, throwable Optional<Throwable>) : void from class com.hubspot.singularity.scheduler.SingularityHealthcheckAsyncHandler | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type healthcheckMaxTotalTimeoutSeconds : Optional<Long> to startupTime : int in method public getMaxHealthcheckTimeoutSeconds(options HealthcheckOptions) : int in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To | |
| Change Variable Type timeoutSeconds : Long to timeoutSeconds : Integer in method private asyncHealthcheck(task SingularityTask) : void in class com.hubspot.singularity.scheduler.SingularityHealthchecker | From | To | |
| Change Variable Type healthcheckMaxRetries : Optional<Integer> to intervalSeconds : int in method public getMaxHealthcheckTimeoutSeconds(options HealthcheckOptions) : int in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To | |
| Extract Method | 1 | ||
| Extract Method public getMaxHealthcheckTimeoutSeconds(options HealthcheckOptions) : int extracted from public getTaskHealth(deploy SingularityDeploy, isDeployPending boolean, healthcheckResult Optional<SingularityTaskHealthcheckResult>, taskId SingularityTaskId) : DeployHealth in class com.hubspot.singularity.scheduler.SingularityDeployHealthHelper | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type healthcheckIntervalSeconds : long to healthcheckIntervalSeconds : int in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Attribute Type healthcheckTimeoutSeconds : long to healthcheckTimeoutSeconds : int in class com.hubspot.singularity.config.SingularityConfiguration | From | To |