3345776757e6ebd57419a67760309dba49039777
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method private assertScoreIs(expectedScore double, actualScore double) : void renamed to private assertValueIs(expectedValue double, actualValue double) : void in class com.hubspot.singularity.mesos.SingularityMesosOfferSchedulerTest | From | To | |
| Rename Method public getMaxTaskLag() : long renamed to public getMaxTaskLagMillis() : long in class com.hubspot.singularity.SingularityState | From | To | |
| Rename Method public getMaxTaskLag() : long renamed to public getMaxTaskLagMillis() : long in class com.hubspot.singularity.SingularityScheduledTasksInfo | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute maxTaskLag : long to maxTaskLagMillis : long in class com.hubspot.singularity.SingularityState | From | To | |
| Extract Method | 10 | ||
| Extract Method private getMinScore(now long) : double extracted from public itGetsTheCorrectMinScore() : void in class com.hubspot.singularity.mesos.SingularityMesosOfferSchedulerTest | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter maxTaskLag : long to maxTaskLagMillis : long in method public SingularityState(activeTasks int, launchingTasks int, activeRequests int, cooldownRequests int, pausedRequests int, scheduledTasks int, pendingRequests int, lbCleanupTasks int, lbCleanupRequests int, cleaningRequests int, activeSlaves int, deadSlaves int, decommissioningSlaves int, activeRacks int, deadRacks int, decommissioningRacks int, cleaningTasks int, hostStates List<SingularityHostState>, oldestDeploy long, numDeploys int, oldestDeployStep long, activeDeploys List<SingularityDeployMarker>, lateTasks int, futureTasks int, maxTaskLagMillis long, generatedAt long, overProvisionedRequestIds List<String>, underProvisionedRequestIds List<String>, overProvisionedRequests int, underProvisionedRequests int, finishedRequests int, unknownRacks int, unknownSlaves int, authDatastoreHealthy Optional<Boolean>, minimumPriorityLevel Optional<Double>, avgStatusUpdateDelayMs long) in class com.hubspot.singularity.SingularityState | From | To | |
| Rename Parameter actualScore : double to actualValue : double in method private assertValueIs(expectedValue double, actualValue double) : void in class com.hubspot.singularity.mesos.SingularityMesosOfferSchedulerTest | From | To | |
| Rename Parameter expectedScore : double to expectedValue : double in method private assertValueIs(expectedValue double, actualValue double) : void in class com.hubspot.singularity.mesos.SingularityMesosOfferSchedulerTest | From | To |