35a7c1c3b749d6d4fb3a544e1f7cc4cc8bc5a6e0
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 2 | ||
| Pull Up Method private startFileReporter() : void from class com.hubspot.singularity.s3uploader.SingularityS3UploaderMetrics to private startFileReporter() : void from class com.hubspot.singularity.s3.base.AbstractFileMetricsReporter | From | To | |
| Pull Up Method private startFileReporter() : void from class com.hubspot.singularity.s3downloader.SingularityS3DownloaderMetrics to private startFileReporter() : void from class com.hubspot.singularity.s3.base.AbstractFileMetricsReporter | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type downloaderConfiguration : SingularityS3DownloaderConfiguration to baseConfiguration : SingularityS3Configuration in method public SingularityS3DownloaderMetrics(registry MetricRegistry, mapper ObjectMapper, asyncDownloadService ThreadPoolExecutor, baseConfiguration SingularityS3Configuration) in class com.hubspot.singularity.s3downloader.SingularityS3DownloaderMetrics | From | To | |
| Change Parameter Type uploaderConfiguration : SingularityS3UploaderConfiguration to baseConfiguration : SingularityS3Configuration in method public SingularityS3UploaderMetrics(registry MetricRegistry, mapper ObjectMapper, baseConfiguration SingularityS3Configuration) in class com.hubspot.singularity.s3uploader.SingularityS3UploaderMetrics | From | To | |
| Move Method | 4 | ||
| Move Method public getMetricsFilePath() : Optional<String> from class com.hubspot.singularity.s3uploader.config.SingularityS3UploaderConfiguration to public getMetricsFilePath() : Optional<String> from class com.hubspot.singularity.s3.base.config.SingularityS3Configuration | From | To | |
| Move Method public getMetricsFilePath() : Optional<String> from class com.hubspot.singularity.s3downloader.config.SingularityS3DownloaderConfiguration to public getMetricsFilePath() : Optional<String> from class com.hubspot.singularity.s3.base.config.SingularityS3Configuration | From | To | |
| Move Method public setMetricsFilePath(metricsFilePath Optional<String>) : void from class com.hubspot.singularity.s3uploader.config.SingularityS3UploaderConfiguration to public setMetricsFilePath(metricsFilePath Optional<String>) : void from class com.hubspot.singularity.s3.base.config.SingularityS3Configuration | From | To | |
| Move Method public setMetricsFilePath(metricsFilePath Optional<String>) : void from class com.hubspot.singularity.s3downloader.config.SingularityS3DownloaderConfiguration to public setMetricsFilePath(metricsFilePath Optional<String>) : void from class com.hubspot.singularity.s3.base.config.SingularityS3Configuration | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute private fileReporterExecutor : ScheduledExecutorService from class com.hubspot.singularity.s3downloader.SingularityS3DownloaderMetrics to protected fileReporterExecutor : ScheduledExecutorService from class com.hubspot.singularity.s3.base.AbstractFileMetricsReporter | From | To | |
| Pull Up Attribute private fileReporterExecutor : ScheduledExecutorService from class com.hubspot.singularity.s3uploader.SingularityS3UploaderMetrics to protected fileReporterExecutor : ScheduledExecutorService from class com.hubspot.singularity.s3.base.AbstractFileMetricsReporter | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.hubspot.singularity.s3.base.AbstractFileMetricsReporter from classes [com.hubspot.singularity.s3downloader.SingularityS3DownloaderMetrics, com.hubspot.singularity.s3uploader.SingularityS3UploaderMetrics] | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter downloaderConfiguration : SingularityS3DownloaderConfiguration to baseConfiguration : SingularityS3Configuration in method public SingularityS3DownloaderMetrics(registry MetricRegistry, mapper ObjectMapper, asyncDownloadService ThreadPoolExecutor, baseConfiguration SingularityS3Configuration) in class com.hubspot.singularity.s3downloader.SingularityS3DownloaderMetrics | From | To | |
| Rename Parameter uploaderConfiguration : SingularityS3UploaderConfiguration to baseConfiguration : SingularityS3Configuration in method public SingularityS3UploaderMetrics(registry MetricRegistry, mapper ObjectMapper, baseConfiguration SingularityS3Configuration) in class com.hubspot.singularity.s3uploader.SingularityS3UploaderMetrics | From | To |