|
Change Parameter Type defaultCredentials : AWSCredentials to defaultCredentials : BasicAWSCredentials in method public SingularityS3Uploader(defaultCredentials BasicAWSCredentials, uploadMetadata S3UploadMetadata, fileSystem FileSystem, metrics SingularityS3UploaderMetrics, metadataPath Path, configuration SingularityS3UploaderConfiguration, hostname String, exceptionNotifier SingularityRunnerExceptionNotifier) in class com.hubspot.singularity.s3uploader.SingularityS3Uploader |
From |
To |
|
Change Parameter Type s3 : S3Service to s3 : AmazonS3 in method public S3ArtifactChunkDownloader(configuration SingularityS3Configuration, log Logger, s3 AmazonS3, s3Artifact S3Artifact, downloadTo Path, chunk int, chunkSize long, length long, exceptionNotifier SingularityRunnerExceptionNotifier) in class com.hubspot.singularity.s3.base.S3ArtifactChunkDownloader |
From |
To |
|
Change Parameter Type s3UploaderAdditionalFiles : List<SingularityExecutorS3UploaderAdditionalFile> to s3UploaderAdditionalFiles : List<SingularityS3UploaderFile> in method public setS3UploaderAdditionalFiles(s3UploaderAdditionalFiles List<SingularityS3UploaderFile>) : SingularityExecutorCleanupConfiguration in class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfiguration |
From |
To |
|
Change Parameter Type excludeMetadata : Optional<Boolean> to excludeMetadata : boolean in method public getS3LogsForTask(taskId String, start Optional<Long>, end Optional<Long>, excludeMetadata boolean, listOnly boolean) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource |
From |
To |
|
Change Parameter Type excludeMetadata : Optional<Boolean> to excludeMetadata : boolean in method public getS3LogsForDeploy(requestId String, deployId String, start Optional<Long>, end Optional<Long>, excludeMetadata boolean, listOnly boolean, maxPerPage Optional<Integer>) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource |
From |
To |
|
Change Parameter Type objectMetadata : Map<String,Object> to objectMetadata : Map<String,String> in method private getMetadataAsLong(objectMetadata Map<String,String>, keyName String) : Optional<Long> in class com.hubspot.singularity.resources.S3LogResource |
From |
To |
|
Change Parameter Type groupOverrides : Map<String,S3GroupOverrideConfiguration> to groupOverrides : Map<String,S3GroupConfiguration> in method public setGroupOverrides(groupOverrides Map<String,S3GroupConfiguration>) : void in class com.hubspot.singularity.config.S3Configuration |
From |
To |
|
Change Parameter Type excludeMetadata : Optional<Boolean> to excludeMetadata : boolean in method public getS3LogsForRequest(requestId String, start Optional<Long>, end Optional<Long>, excludeMetadata boolean, listOnly boolean, maxPerPage Optional<Integer>) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource |
From |
To |
|
Change Parameter Type s3ChunkDownloadTimeoutMillis : long to s3ChunkDownloadTimeoutMillis : int in method public setS3ChunkDownloadTimeoutMillis(s3ChunkDownloadTimeoutMillis int) : void in class com.hubspot.singularity.s3.base.config.SingularityS3Configuration |
From |
To |
|
Change Parameter Type executorData : ExecutorData to executorData : SingularityTaskExecutorData in method public SingularityExecutorTaskDefinition(taskId String, executorData SingularityTaskExecutorData, taskDirectory String, executorPid String, serviceLogOut String, serviceLogOutExtension String, serviceFinishedTailLog String, taskAppDirectory String, executorBashOut String, logrotateStateFile String, signatureVerifyOut String) in class com.hubspot.singularity.executor.task.SingularityExecutorTaskDefinition |
From |
To |
|
Move Method public getS3UploaderKeyPattern() : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration to public getS3UploaderKeyPattern() : String from class com.hubspot.singularity.SingularityTaskExecutorData |
From |
To |
|
Move Method public setS3UploaderAdditionalFiles(s3UploaderAdditionalFiles List<SingularityExecutorS3UploaderAdditionalFile>) : void from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration to public setS3UploaderAdditionalFiles(s3UploaderAdditionalFiles List<SingularityS3UploaderFile>) : SingularityExecutorCleanupConfiguration from class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfiguration |
From |
To |
|
Move Method public setServiceLog(serviceLog String) : void from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration to public setServiceLog(serviceLog String) : void from class com.hubspot.singularity.config.CustomExecutorConfiguration |
From |
To |
|
Move Method public setServiceFinishedTailLog(serviceFinishedTailLog String) : void from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration to public setServiceFinishedTailLog(serviceFinishedTailLog String) : void from class com.hubspot.singularity.config.CustomExecutorConfiguration |
From |
To |
|
Move Method public getServiceLog() : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration to public getServiceLog() : String from class com.hubspot.singularity.SingularityTaskExecutorData |
From |
To |
|
Move Method public getServiceFinishedTailLog() : String from class com.hubspot.singularity.executor.config.SingularityExecutorConfiguration to public getServiceFinishedTailLog() : String from class com.hubspot.singularity.SingularityTaskExecutorData |
From |
To |
|
Pull Up Attribute public LOG_START_S3_ATTR : String from class com.hubspot.singularity.SingularityS3Log to public LOG_START_S3_ATTR : String from class com.hubspot.singularity.SingularityS3LogMetadata |
From |
To |
|
Pull Up Attribute private lastModified : long from class com.hubspot.singularity.SingularityS3Log to private lastModified : long from class com.hubspot.singularity.SingularityS3LogMetadata |
From |
To |
|
Pull Up Attribute private size : long from class com.hubspot.singularity.SingularityS3Log to private size : long from class com.hubspot.singularity.SingularityS3LogMetadata |
From |
To |
|
Pull Up Attribute private key : String from class com.hubspot.singularity.SingularityS3Log to private key : String from class com.hubspot.singularity.SingularityS3LogMetadata |
From |
To |
|
Pull Up Attribute private startTime : Optional<Long> from class com.hubspot.singularity.SingularityS3Log to private startTime : Optional<Long> from class com.hubspot.singularity.SingularityS3LogMetadata |
From |
To |
|
Pull Up Attribute private endTime : Optional<Long> from class com.hubspot.singularity.SingularityS3Log to private endTime : Optional<Long> from class com.hubspot.singularity.SingularityS3LogMetadata |
From |
To |
|
Pull Up Attribute public LOG_END_S3_ATTR : String from class com.hubspot.singularity.SingularityS3Log to public LOG_END_S3_ATTR : String from class com.hubspot.singularity.SingularityS3LogMetadata |
From |
To |
|
Change Variable Type object : S3Object to objectMetadata : ObjectMetadata in method public call() : Boolean in class com.hubspot.singularity.s3uploader.SingularityS3Uploader.Uploader |
From |
To |
|
Change Variable Type bucketCreds : Optional<AWSCredentials> to bucketCreds : Optional<BasicAWSCredentials> in method private handleNewOrModifiedS3Metadata(filename Path) : boolean in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver |
From |
To |
|
Change Variable Type loggingS3Bucket : Optional<String> to defaultS3Bucket : String in method private prepareCustomExecutor(bldr TaskInfo.Builder, taskId SingularityTaskId, task SingularityTaskRequest, offer Protos.Offer, ports Optional<long[]>, desiredExecutorResources Resources) : void in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilder |
From |
To |
|
Change Variable Type credentials : AWSCredentials to credentials : BasicAWSCredentials in method public SingularityS3Uploader(defaultCredentials BasicAWSCredentials, uploadMetadata S3UploadMetadata, fileSystem FileSystem, metrics SingularityS3UploaderMetrics, metadataPath Path, configuration SingularityS3UploaderConfiguration, hostname String, exceptionNotifier SingularityRunnerExceptionNotifier) in class com.hubspot.singularity.s3uploader.SingularityS3Uploader |
From |
To |
|
Change Variable Type s3 : S3Service to s3Client : AmazonS3 in method private downloadThrows(s3Artifact S3Artifact, downloadTo Path) : void in class com.hubspot.singularity.s3.base.S3ArtifactDownloader |
From |
To |
|
Change Variable Type executorData : ExecutorData to taskExecutorData : SingularityTaskExecutorData in method public buildTask(taskId String, driver ExecutorDriver, taskInfo TaskInfo, log Logger) : SingularityExecutorTask in class com.hubspot.singularity.executor.config.SingularityExecutorTaskBuilder |
From |
To |
|
Change Variable Type that : S3GroupOverrideConfiguration to that : S3GroupConfiguration in method public equals(o Object) : boolean in class com.hubspot.singularity.config.S3GroupConfiguration |
From |
To |
|
Change Variable Type defaultCredentials : AWSCredentials to defaultCredentials : BasicAWSCredentials in method private handleNewOrModifiedS3Metadata(filename Path) : boolean in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver |
From |
To |
|
Change Variable Type additionalFile : SingularityExecutorS3UploaderAdditionalFile to additionalFile : SingularityS3UploaderFile in method private writeS3MetadataFileForRotatedFiles(finished boolean) : boolean in class com.hubspot.singularity.executor.task.SingularityExecutorTaskLogManager |
From |
To |
|
Rename Variable object : S3Object to objectMetadata : ObjectMetadata in method public call() : Boolean in class com.hubspot.singularity.s3uploader.SingularityS3Uploader.Uploader |
From |
To |
|
Rename Variable loggingS3Bucket : Optional<String> to defaultS3Bucket : String in method private prepareCustomExecutor(bldr TaskInfo.Builder, taskId SingularityTaskId, task SingularityTaskRequest, offer Protos.Offer, ports Optional<long[]>, desiredExecutorResources Resources) : void in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilder |
From |
To |
|
Rename Variable taskDefinition : Optional<SingularityExecutorTaskDefinition> to maybeTaskDefinition : Optional<SingularityExecutorTaskDefinition> in method public clean() : SingularityExecutorCleanupStatistics in class com.hubspot.singularity.executor.cleanup.SingularityExecutorCleanup |
From |
To |
|
Rename Variable s3 : S3Service to s3Client : AmazonS3 in method private downloadThrows(s3Artifact S3Artifact, downloadTo Path) : void in class com.hubspot.singularity.s3.base.S3ArtifactDownloader |
From |
To |
|
Rename Variable executorData : ExecutorData to taskExecutorData : SingularityTaskExecutorData in method public buildTask(taskId String, driver ExecutorDriver, taskInfo TaskInfo, log Logger) : SingularityExecutorTask in class com.hubspot.singularity.executor.config.SingularityExecutorTaskBuilder |
From |
To |
|
Change Return Type List<SingularityS3Log> to List<SingularityS3LogMetadata> in method public getS3LogsForRequest(requestId String, start Optional<Long>, end Optional<Long>, excludeMetadata boolean, listOnly boolean, maxPerPage Optional<Integer>) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource |
From |
To |
|
Change Return Type void to SingularityExecutorCleanupConfiguration in method public setS3UploaderAdditionalFiles(s3UploaderAdditionalFiles List<SingularityS3UploaderFile>) : SingularityExecutorCleanupConfiguration in class com.hubspot.singularity.executor.cleanup.config.SingularityExecutorCleanupConfiguration |
From |
To |
|
Change Return Type AWSCredentials to BasicAWSCredentials in method public toAWSCredentials() : BasicAWSCredentials in class com.hubspot.singularity.s3.base.config.SingularityS3Credentials |
From |
To |
|
Change Return Type void to boolean in method private download() : boolean in class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderAsyncHandler |
From |
To |
|
Change Return Type List<Protos.Parameter> to List<String> in method public getDockerParameters() : List<String> in class com.hubspot.singularity.executor.models.EnvironmentContext |
From |
To |
|
Change Return Type List<SingularityS3Log> to List<SingularityS3LogMetadata> in method public getS3LogsForTask(taskId String, start Optional<Long>, end Optional<Long>, excludeMetadata boolean, listOnly boolean) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource |
From |
To |
|
Change Return Type long to int in method public getS3ChunkDownloadTimeoutMillis() : int in class com.hubspot.singularity.s3.base.config.SingularityS3Configuration |
From |
To |
|
Change Return Type List<SingularityS3Log> to List<SingularityS3LogMetadata> in method public getS3LogsForDeploy(requestId String, deployId String, start Optional<Long>, end Optional<Long>, excludeMetadata boolean, listOnly boolean, maxPerPage Optional<Integer>) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource |
From |
To |
|
Change Return Type SingularityExecutorS3UploaderAdditionalFile to SingularityS3UploaderFile in method public fromString(value String) : SingularityS3UploaderFile in class com.hubspot.singularity.SingularityS3UploaderFile |
From |
To |
|
Change Return Type ExecutorData to SingularityTaskExecutorData in method public getExecutorData() : SingularityTaskExecutorData in class com.hubspot.singularity.executor.task.SingularityExecutorTaskDefinition |
From |
To |
|
Change Return Type Map<String,S3GroupOverrideConfiguration> to Map<String,S3GroupConfiguration> in method public getGroupOverrides() : Map<String,S3GroupConfiguration> in class com.hubspot.singularity.config.S3Configuration |
From |
To |
|
Change Return Type ExecutorData to SingularityTaskExecutorData in method private readExecutorData(objectMapper ObjectMapper, taskInfo Protos.TaskInfo) : SingularityTaskExecutorData in class com.hubspot.singularity.executor.config.SingularityExecutorTaskBuilder |
From |
To |
|
Change Return Type AWSCredentials to BasicAWSCredentials in method private getCredentialsForBucket(bucketName String) : BasicAWSCredentials in class com.hubspot.singularity.s3.base.S3ArtifactDownloader |
From |
To |
|
Change Attribute Type LOG_COMPARATOR : Comparator<SingularityS3Log> to LOG_COMPARATOR : Comparator<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource |
From |
To |
|
Change Attribute Type s3ChunkDownloadTimeoutMillis : long to s3ChunkDownloadTimeoutMillis : int in class com.hubspot.singularity.s3.base.config.SingularityS3Configuration |
From |
To |
|
Change Attribute Type executorData : ExecutorData to executorData : SingularityTaskExecutorData in class com.hubspot.singularity.executor.task.SingularityExecutorTaskDefinition |
From |
To |
|
Change Attribute Type s3 : S3Service to s3 : AmazonS3 in class com.hubspot.singularity.s3.base.S3ArtifactChunkDownloader |
From |
To |
|
Change Attribute Type s3ServiceDefault : Optional<S3Service> to s3Services : SingularityS3Services in class com.hubspot.singularity.resources.S3LogResource |
From |
To |
|
Change Attribute Type s3Service : S3Service to s3Client : AmazonS3 in class com.hubspot.singularity.s3uploader.SingularityS3Uploader |
From |
To |
|
Change Attribute Type groupOverrides : Map<String,S3GroupOverrideConfiguration> to groupOverrides : Map<String,S3GroupConfiguration> in class com.hubspot.singularity.config.S3Configuration |
From |
To |