4c46c4a08f58677b9477d818820241240fd74bfd
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 6
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 2 | ||
Change Parameter Type taskId : SingularityTaskId to taskId : String in method public getSingularityTaskLink(taskId String) : String in class com.hubspot.singularity.smtp.JadeHelpers | From | To | |
Change Parameter Type type : EmailType to type : EmailConfigurationEnums.EmailType in method private getSubjectForTaskHistory(taskId SingularityTaskId, state ExtendedTaskState, type EmailConfigurationEnums.EmailType, history Collection<SingularityTaskHistoryUpdate>) : String in class com.hubspot.singularity.smtp.SingularityMailer | From | To | |
Move Method | 1 | ||
Move Method private getSingularityTaskLink(taskId SingularityTaskId) : String from class com.hubspot.singularity.smtp.SingularityMailer to public getSingularityTaskLink(taskId String) : String from class com.hubspot.singularity.smtp.JadeHelpers | From | To | |
Move Attribute | 2 | ||
Move Attribute private REQUEST_LINK_FORMAT : String from class com.hubspot.singularity.smtp.SingularityMailer to private REQUEST_LINK_FORMAT : String from class com.hubspot.singularity.smtp.JadeHelpers | From | To | |
Move Attribute private TASK_LINK_FORMAT : String from class com.hubspot.singularity.smtp.SingularityMailer to private TASK_LINK_FORMAT : String from class com.hubspot.singularity.smtp.JadeHelpers | From | To | |
Extract Class | 1 | ||
Extract Class com.hubspot.singularity.smtp.JadeHelpers from class com.hubspot.singularity.smtp.SingularityMailer | From | To | |
Change Variable Type | 1 | ||
Change Variable Type simplifiedTaskState : SimplifiedTaskState to simplifiedTaskState : SingularityTaskHistoryUpdate.SimplifiedTaskState in method private didTaskRun(history Collection<SingularityTaskHistoryUpdate>) : boolean in class com.hubspot.singularity.smtp.SingularityMailer | From | To |