57a321b7e374c67f254adff82fd2283c132e9e77
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 10
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public testDECOMMissioning() : void renamed to public testDecommissioning() : void in class com.hubspot.singularity.scheduler.SingularitySchedulerTest | From | To | |
| Rename Method public createCleanupTask(cleanupTask SingularityTaskCleanup) : SingularityCreateResult renamed to private saveTaskHistoryUpdate(cleanup SingularityTaskCleanup) : void in class com.hubspot.singularity.data.TaskManager | From | To | |
| Rename Method public testEmptyDECOMMissioning() : void renamed to public testEmptyDecommissioning() : void in class com.hubspot.singularity.scheduler.SingularitySchedulerTest | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type scheduledTasks : List<SingularityPendingTask> to scheduledTasks : Collection<SingularityPendingTask> in method private deleteScheduledTasks(scheduledTasks Collection<SingularityPendingTask>, pendingRequest SingularityPendingRequest) : void in class com.hubspot.singularity.scheduler.SingularityScheduler | From | To | |
| Change Parameter Type activeTaskIds : List<SingularityTaskId> to activeTaskIds : Collection<SingularityTaskId> in method public getTasksOnSlave(activeTaskIds Collection<SingularityTaskId>, slave SingularitySlave) : List<SingularityTask> in class com.hubspot.singularity.data.TaskManager | From | To | |
| Change Return Type | 4 | ||
| Change Return Type List<SingularityTaskId> to Collection<SingularityTaskId> in method public getCleaningTasks() : Collection<SingularityTaskId> in class com.hubspot.singularity.scheduler.SingularitySchedulerStateCache | From | To | |
| Change Return Type List<SingularityTaskId> to Collection<SingularityTaskId> in method public getActiveTaskIds() : Collection<SingularityTaskId> in class com.hubspot.singularity.scheduler.SingularitySchedulerStateCache | From | To | |
| Change Return Type List<SingularityPendingTask> to Collection<SingularityPendingTask> in method public getScheduledTasks() : Collection<SingularityPendingTask> in class com.hubspot.singularity.scheduler.SingularitySchedulerStateCache | From | To | |
| Change Return Type SingularityCreateResult to void in method private saveTaskHistoryUpdate(cleanup SingularityTaskCleanup) : void in class com.hubspot.singularity.data.TaskManager | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type activeTaskIds : List<SingularityTaskId> to activeTaskIds : Collection<SingularityTaskId> in method public checkForDecomissions(stateCache SingularitySchedulerStateCache) : void in class com.hubspot.singularity.scheduler.SingularityScheduler | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type activeTaskIds : Optional<List<SingularityTaskId>> to activeTaskIds : Optional<Collection<SingularityTaskId>> in class com.hubspot.singularity.scheduler.SingularitySchedulerStateCache | From | To | |
| Change Attribute Type cleaningTasks : Optional<List<SingularityTaskId>> to cleaningTasks : Optional<Collection<SingularityTaskId>> in class com.hubspot.singularity.scheduler.SingularitySchedulerStateCache | From | To | |
| Change Attribute Type scheduledTasks : Optional<List<SingularityPendingTask>> to scheduledTasks : Optional<Collection<SingularityPendingTask>> in class com.hubspot.singularity.scheduler.SingularitySchedulerStateCache | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter cleanupTask : SingularityTaskCleanup to cleanup : SingularityTaskCleanup in method private saveTaskHistoryUpdate(cleanup SingularityTaskCleanup) : void in class com.hubspot.singularity.data.TaskManager | From | To |