5b4c11c50a897252cd688a48311f715907f5be8d
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Inline Method | 2 | ||
| Inline Method private fromLbState(state DeployState, lbUpdate SingularityLoadBalancerUpdate) : SingularityDeployResult inlined to private cancelLoadBalancer(pendingDeploy SingularityPendingDeploy, deployFailures List<SingularityDeployFailure>) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Inline Method private fromLbState(state DeployState, lbUpdate SingularityLoadBalancerUpdate) : SingularityDeployResult inlined to private processLbState(request SingularityRequest, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>, lbUpdate SingularityLoadBalancerUpdate) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract Method | 3 | ||
| Extract Method private getDeployResultWithFailures(request SingularityRequest, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, state DeployState, message String, matchingTasks Collection<SingularityTaskId>) : SingularityDeployResult extracted from private checkDeployProgress(request SingularityRequest, cancelRequest Optional<SingularityDeployMarker>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>, deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract Method private getDeployResultWithFailures(request SingularityRequest, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, state DeployState, message String, matchingTasks Collection<SingularityTaskId>) : SingularityDeployResult extracted from private checkOverdue(deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, isOverdue boolean) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract Method private getDeployResultWithFailures(request SingularityRequest, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, state DeployState, message String, matchingTasks Collection<SingularityTaskId>) : SingularityDeployResult extracted from private getDeployResult(request SingularityRequest, cancelRequest Optional<SingularityDeployMarker>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>, deployKey SingularityDeployKey, deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>, inactiveDeployMatchingTasks Collection<SingularityTaskId>) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To |