5ee1602703a77edd8254e5ea6f676912adb9c306
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private callWithLock(function Runnable, name String) : void renamed to private callWithOffersLock(function Runnable, name String) : void in class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type requestIdToTaskIds : Map<String,List<String>> to taskIdsForDeletedRequest : List<String> in method private cleanupRequestIfNoRemainingTasks(cleanupTask SingularityTaskCleanup, taskIdsForDeletedRequest List<String>) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Rename Variable | 1 | ||
| Rename Variable deletedRequestIdToTaskIds : Map<String,List<String>> to taskIdsForDeletedRequest : List<String> in method private processTaskCleanupsForRequest(requestId String, cleanupTasks List<SingularityTaskCleanup>, killedTasks AtomicInteger) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Inline Method | 1 | ||
| Inline Method private callWithLock(function Runnable, name String, ignoreIfNotRunning boolean) : void inlined to private callWithOffersLock(function Runnable, name String) : void in class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable requestTasks : List<String> to taskIdsForDeletedRequest : List<String> in method private cleanupRequestIfNoRemainingTasks(cleanupTask SingularityTaskCleanup, taskIdsForDeletedRequest List<String>) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute lock : ReentrantLock to stateLock : ReentrantLock in class com.hubspot.singularity.mesos.SingularitySchedulerLock | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type deletedRequestIdToTaskIds : Map<String,List<String>> to taskIdsForDeletedRequest : List<String> in method private processTaskCleanupsForRequest(requestId String, cleanupTasks List<SingularityTaskCleanup>, killedTasks AtomicInteger) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Extract Method | 6 | ||
| Extract Method private callWithStateLock(function Runnable, name String, ignoreIfNotRunning boolean) : void extracted from public onConnectException(t Throwable) : void in class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl | From | To | |
| Extract Method private callWithStateLock(function Runnable, name String, ignoreIfNotRunning boolean) : void extracted from public error(message String) : void in class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl | From | To | |
| Extract Method private handleStatusUpdateAsync(status TaskStatus) : void extracted from public statusUpdate(status TaskStatus) : void in class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl | From | To | |
| Extract Method private callWithStateLock(function Runnable, name String, ignoreIfNotRunning boolean) : void extracted from public onUncaughtException(t Throwable) : void in class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl | From | To | |
| Extract Method private processTaskCleanupsForRequest(requestId String, cleanupTasks List<SingularityTaskCleanup>, killedTasks AtomicInteger) : void extracted from private drainTaskCleanupQueue() : int in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Extract Method private processRequestCleanup(start long, numTasksKilled AtomicInteger, numScheduledTasksRemoved AtomicInteger, requestCleanup SingularityRequestCleanup) : void extracted from private drainRequestCleanupQueue() : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public lockOffers(name String) : long extracted from public runActionOnPoll() : void in class com.hubspot.singularity.scheduler.SingularitySchedulerPoller & moved to class com.hubspot.singularity.mesos.SingularitySchedulerLock | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter requestIdToTaskIds : Map<String,List<String>> to taskIdsForDeletedRequest : List<String> in method private cleanupRequestIfNoRemainingTasks(cleanupTask SingularityTaskCleanup, taskIdsForDeletedRequest List<String>) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To |