62af91cd0bd78f7a0cb6c1388889d19dde01b6a2
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 2 | ||
| Rename Variable skipHealthChecks : Optional<Boolean> to maybePendingRequest : Optional<SingularityPendingRequest> in method private finishDeploy(requestWithState SingularityRequestWithState, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, tasksToKill Iterable<SingularityTaskId>, deployResult SingularityDeployResult) : void in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Rename Variable runNowRequest : SingularityRunNowRequest to maybePendingRequest : Optional<SingularityPendingRequest> in method private finishDeploy(requestWithState SingularityRequestWithState, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, tasksToKill Iterable<SingularityTaskId>, deployResult SingularityDeployResult) : void in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type runNowRequest : SingularityRunNowRequest to maybePendingRequest : Optional<SingularityPendingRequest> in method private finishDeploy(requestWithState SingularityRequestWithState, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, tasksToKill Iterable<SingularityTaskId>, deployResult SingularityDeployResult) : void in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Change Variable Type skipHealthChecks : Optional<Boolean> to maybePendingRequest : Optional<SingularityPendingRequest> in method private finishDeploy(requestWithState SingularityRequestWithState, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, tasksToKill Iterable<SingularityTaskId>, deployResult SingularityDeployResult) : void in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public checkRunNowRequest(deployId String, userEmail Optional<String>, request SingularityRequest, maybeRunNowRequest Optional<SingularityRunNowRequest>, activeTasks List<SingularityTaskId>, pendingTasks List<SingularityPendingTaskId>) : SingularityPendingRequest extracted from public scheduleImmediately(requestId String, runNowRequest Optional<SingularityRunNowRequest>) : SingularityPendingRequestParent in class com.hubspot.singularity.resources.RequestResource & moved to class com.hubspot.singularity.data.SingularityValidator | From | To |