6601fb1d8b7f54e2b5b23f666e09fdb5a42d7b6f
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 1
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private match(taskRequests Collection<SingularityTaskRequestHolder>, stateCache SingularitySchedulerStateCache, offerHolder SingularityOfferHolder, tasksPerOfferPerRequest Map<String,Map<String,Integer>>) : Optional<SingularityTask> renamed to private score(offerHolder SingularityOfferHolder, stateCache SingularitySchedulerStateCache, tasksPerOfferPerRequest Map<String,Map<String,Integer>>, taskRequestHolder SingularityTaskRequestHolder, usagesPerRequestTypePerSlave Map<String,Map<RequestType,Map<String,Integer>>>) : double in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Optional<SingularityTask> to double in method private score(offerHolder SingularityOfferHolder, stateCache SingularitySchedulerStateCache, tasksPerOfferPerRequest Map<String,Map<String,Integer>>, taskRequestHolder SingularityTaskRequestHolder, usagesPerRequestTypePerSlave Map<String,Map<RequestType,Map<String,Integer>>>) : double in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
| Replace Variable With Attribute | 2 | ||
| Replace Variable With Attribute memory : String to MEMORY_USED : String in method private getUsagesPerRequestTypePerSlave() : Map<String,Map<RequestType,Map<String,Integer>>> in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
| Replace Variable With Attribute cpus : String to CPU_USED : String in method private getUsagesPerRequestTypePerSlave() : Map<String,Map<RequestType,Map<String,Integer>>> in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
| Extract Method | 1 | ||
| Extract Method private isTooManyInstancesForRequest(taskRequest SingularityTaskRequest, stateCache SingularitySchedulerStateCache) : boolean extracted from private match(taskRequests Collection<SingularityTaskRequestHolder>, stateCache SingularitySchedulerStateCache, offerHolder SingularityOfferHolder, tasksPerOfferPerRequest Map<String,Map<String,Integer>>) : Optional<SingularityTask> in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To |