6b14edde1e05ae6b9fe3b525145dbf7fc46de29e
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Method | 4 | ||
| Move Method public getTaskPersistAfterFinishBufferMillis() : long from class com.hubspot.singularity.config.SingularityConfiguration to public getTaskPersistAfterFinishBufferMillis() : long from class com.hubspot.singularity.config.SingularityTaskMetadataConfiguration | From | To | |
| Move Method public setTaskPersistAfterFinishBufferMillis(taskPersistAfterFinishBufferMillis long) : void from class com.hubspot.singularity.config.SingularityConfiguration to public setTaskPersistAfterFinishBufferMillis(taskPersistAfterFinishBufferMillis long) : void from class com.hubspot.singularity.config.SingularityTaskMetadataConfiguration | From | To | |
| Move Method public getWaitToSendTaskCompletedMailBufferMillis() : long from class com.hubspot.singularity.config.SingularityConfiguration to public getWaitToSendTaskCompletedMailBufferMillis() : long from class com.hubspot.singularity.config.SingularityTaskMetadataConfiguration | From | To | |
| Move Method public setWaitToSendTaskCompletedMailBufferMillis(waitToSendTaskCompletedMailBufferMillis long) : void from class com.hubspot.singularity.config.SingularityConfiguration to public setWaitToSendTaskCompletedMailBufferMillis(waitToSendTaskCompletedMailBufferMillis long) : void from class com.hubspot.singularity.config.SingularityTaskMetadataConfiguration | From | To | |
| Change Return Type | 1 | ||
| Change Return Type CheckToSendTaskFinishedMailState to void in method private checkToSendTaskFinishedMail(taskId SingularityTaskId) : void in class com.hubspot.singularity.scheduler.SingularityMailPoller | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private waitToSendTaskCompletedMailBufferMillis : long from class com.hubspot.singularity.config.SingularityConfiguration to private waitToSendTaskCompletedMailBufferMillis : long from class com.hubspot.singularity.config.SingularityTaskMetadataConfiguration | From | To | |
| Move Attribute private taskPersistAfterFinishBufferMillis : long from class com.hubspot.singularity.config.SingularityConfiguration to private taskPersistAfterFinishBufferMillis : long from class com.hubspot.singularity.config.SingularityTaskMetadataConfiguration | From | To | |
| Extract Class | 1 | ||
| Extract Class com.hubspot.singularity.config.SingularityTaskMetadataConfiguration from class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Class | 1 | ||
| Rename Class com.hubspot.singularity.scheduler.SingularityMailPoller.CheckToSendTaskFinishedMailState renamed to com.hubspot.singularity.scheduler.SingularityMailPoller.ShouldSendMailState | From | To | |
| Extract Method | 1 | ||
| Extract Method private shouldSendTaskFinishedMail(taskId SingularityTaskId, requestWithState Optional<SingularityRequestWithState>, taskHistory Optional<SingularityTaskHistory>) : ShouldSendMailState extracted from private checkToSendTaskFinishedMail(taskId SingularityTaskId) : CheckToSendTaskFinishedMailState in class com.hubspot.singularity.scheduler.SingularityMailPoller | From | To |