Singularity 6b92d3e4cd83d9fc2e6b1648e09e0b61fd0db86e

6b92d3e4cd83d9fc2e6b1648e09e0b61fd0db86e

Files Diff

Added: 3
Removed: 27
Renamed: 0
Modified: 20

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method public resourcesFromProtos(resourcesProtos List<Resource>) : List<MesosResourceObject> renamed to public toResourceList(resourceObjects List<MesosResourceObject>) : List<Resource> in class com.hubspot.mesos.MesosProtosUtils	From	To
Change Parameter Type	4
Change Parameter Type executor : Optional<ExecutorInfo> to executor : Optional<MesosExecutorInfo> in method public MesosTaskObject(taskId MesosStringValue, executor Optional<MesosExecutorInfo>, labels MesosLabels, agentId MesosStringValue, slaveId MesosStringValue, resources List<MesosResourceObject>, name String) in class com.hubspot.mesos.protos.MesosTaskObject	From	To
Change Parameter Type resources : List<Resource> to resources : List<MesosResourceObject> in method public MesosTaskObject(taskId MesosStringValue, executor Optional<MesosExecutorInfo>, labels MesosLabels, agentId MesosStringValue, slaveId MesosStringValue, resources List<MesosResourceObject>, name String) in class com.hubspot.mesos.protos.MesosTaskObject	From	To
Change Parameter Type resourcesProtos : List<Resource> to resourceObjects : List<MesosResourceObject> in method public toResourceList(resourceObjects List<MesosResourceObject>) : List<Resource> in class com.hubspot.mesos.MesosProtosUtils	From	To
Change Parameter Type labels : Optional<Labels> to labels : MesosLabels in method public MesosTaskObject(taskId MesosStringValue, executor Optional<MesosExecutorInfo>, labels MesosLabels, agentId MesosStringValue, slaveId MesosStringValue, resources List<MesosResourceObject>, name String) in class com.hubspot.mesos.protos.MesosTaskObject	From	To
Move Method	53
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosVolumeSource to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosDoubleValue to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosRanges to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosURL to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosAppcImage to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosDockerImage to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosDiskSource to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosDoubleValue to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosAttributeObject to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosSet to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosCredential to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosMount to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosAddress to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosAppcImage to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosReservationInfo to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosRange to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosDiskInfo to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosVolumeSource to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosSet to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosSet to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosSandboxPath to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosDiskSource to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosAddress to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosSandboxPath to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosDoubleValue to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosAppcImage to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosRange to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosImage to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosDiskSource to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosDiskInfo to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosImage to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosDockerImage to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosAddress to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosDockerImage to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosVolumeSource to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosDiskPersistence to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosAttributeObject to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosVolume to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosRanges to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosDiskPersistence to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosCredential to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosMount to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosDiskInfo to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosReservationInfo to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosReservationInfo to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosCredential to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosURL to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosRange to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosVolume to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosRanges to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public toString() : String from class com.hubspot.mesos.protos.MesosMount to public toString() : String from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosSandboxPath to public equals(obj Object) : boolean from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Move Method public hashCode() : int from class com.hubspot.mesos.protos.MesosDiskPersistence to public hashCode() : int from class com.hubspot.mesos.protos.MesosResourceObject	From	To
Change Return Type	4
Change Return Type List<Resource> to List<MesosResourceObject> in method public getResources() : List<MesosResourceObject> in class com.hubspot.mesos.protos.MesosTaskObject	From	To
Change Return Type Labels to MesosLabels in method public getLabels() : MesosLabels in class com.hubspot.mesos.protos.MesosTaskObject	From	To
Change Return Type List<MesosResourceObject> to List<Resource> in method public toResourceList(resourceObjects List<MesosResourceObject>) : List<Resource> in class com.hubspot.mesos.MesosProtosUtils	From	To
Change Return Type ExecutorInfo to MesosExecutorInfo in method public getExecutor() : MesosExecutorInfo in class com.hubspot.mesos.protos.MesosTaskObject	From	To
Move Class	1
Move Class com.hubspot.mesos.SingularityMesosTaskHolder moved to com.hubspot.singularity.helpers.SingularityMesosTaskHolder	From	To
Change Variable Type	1
Change Variable Type label : Protos.Label to label : MesosParameter in method private tasksToUpstreams(tasks List<SingularityTask>, requestId String, loadBalancerUpstreamGroup Optional<String>) : List<UpstreamInfo> in class com.hubspot.singularity.hooks.LoadBalancerClientImpl	From	To
Change Attribute Type	3
Change Attribute Type executor : Optional<ExecutorInfo> to executor : Optional<MesosExecutorInfo> in class com.hubspot.mesos.protos.MesosTaskObject	From	To
Change Attribute Type resources : List<Resource> to resources : List<MesosResourceObject> in class com.hubspot.mesos.protos.MesosTaskObject	From	To
Change Attribute Type labels : Optional<Labels> to labels : MesosLabels in class com.hubspot.mesos.protos.MesosTaskObject	From	To
Rename Parameter	3
Rename Parameter o : Object to obj : Object in method public equals(obj Object) : boolean in class com.hubspot.mesos.protos.MesosOfferObject	From	To
Rename Parameter o : Object to obj : Object in method public equals(obj Object) : boolean in class com.hubspot.mesos.protos.MesosTaskObject	From	To
Rename Parameter resourcesProtos : List<Resource> to resourceObjects : List<MesosResourceObject> in method public toResourceList(resourceObjects List<MesosResourceObject>) : List<Resource> in class com.hubspot.mesos.MesosProtosUtils	From	To

6b92d3e4cd83d9fc2e6b1648e09e0b61fd0db86e

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: