78921eb664ef8fb903bb484813db066e09c32a50
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public getLoadBalancerState(requestId String) : Optional<SingularityLoadBalancerUpdate> renamed to public getLbCleanupRequest(requestId String) : Optional<SingularityRequestLbCleanup> in class com.hubspot.singularity.data.RequestManager | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type loadBalancerUpdateTranscoder : Transcoder<SingularityLoadBalancerUpdate> to requestLbCleanupTranscoder : Transcoder<SingularityRequestLbCleanup> in method public RequestManager(curator CuratorFramework, configuration SingularityConfiguration, metricRegistry MetricRegistry, singularityEventListener SingularityEventListener, requestCleanupTranscoder Transcoder<SingularityRequestCleanup>, requestTranscoder Transcoder<SingularityRequestWithState>, requestLbCleanupTranscoder Transcoder<SingularityRequestLbCleanup>, pendingRequestTranscoder Transcoder<SingularityPendingRequest>, requestHistoryTranscoder Transcoder<SingularityRequestHistory>) in class com.hubspot.singularity.data.RequestManager | From | To | |
| Rename Variable | 1 | ||
| Rename Variable requestId : String to cleanup : SingularityRequestLbCleanup in method private drainLBRequestCleanupQueue(lbCleanupTasks List<SingularityTaskId>) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Optional<SingularityLoadBalancerUpdate> to Optional<SingularityRequestLbCleanup> in method public getLbCleanupRequest(requestId String) : Optional<SingularityRequestLbCleanup> in class com.hubspot.singularity.data.RequestManager | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute loadBalancerUpdateTranscoder : Transcoder<SingularityLoadBalancerUpdate> to requestLbCleanupTranscoder : Transcoder<SingularityRequestLbCleanup> in class com.hubspot.singularity.data.RequestManager | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type lbCleanupRequests : List<String> to lbCleanupRequests : List<SingularityRequestLbCleanup> in method private drainLBRequestCleanupQueue(lbCleanupTasks List<SingularityTaskId>) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Change Variable Type requestId : String to cleanup : SingularityRequestLbCleanup in method private drainLBRequestCleanupQueue(lbCleanupTasks List<SingularityTaskId>) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Extract Variable | 1 | ||
| Extract Variable matchingActiveTaskIds : Iterable<SingularityTaskId> in method private drainRequestCleanupQueue() : void from class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type loadBalancerUpdateTranscoder : Transcoder<SingularityLoadBalancerUpdate> to requestLbCleanupTranscoder : Transcoder<SingularityRequestLbCleanup> in class com.hubspot.singularity.data.RequestManager | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter loadBalancerUpdateTranscoder : Transcoder<SingularityLoadBalancerUpdate> to requestLbCleanupTranscoder : Transcoder<SingularityRequestLbCleanup> in method public RequestManager(curator CuratorFramework, configuration SingularityConfiguration, metricRegistry MetricRegistry, singularityEventListener SingularityEventListener, requestCleanupTranscoder Transcoder<SingularityRequestCleanup>, requestTranscoder Transcoder<SingularityRequestWithState>, requestLbCleanupTranscoder Transcoder<SingularityRequestLbCleanup>, pendingRequestTranscoder Transcoder<SingularityPendingRequest>, requestHistoryTranscoder Transcoder<SingularityRequestHistory>) in class com.hubspot.singularity.data.RequestManager | From | To |