7cc9eea559298a4e9cb3907ec7413a2224e5064a
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method private checkMoveToNextDeployStep(request SingularityRequest, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>) : SingularityDeployResult renamed to private checkCanMoveToNextDeployStep(request SingularityRequest, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Rename Method public setDeployStepWaitTimeSeconds(deployStepWaitTimeSeconds Optional<Integer>) : SingularityDeployBuilder renamed to public setDeployStepWaitTimeMs(deployStepWaitTimeMs Optional<Integer>) : SingularityDeployBuilder in class com.hubspot.singularity.SingularityDeployBuilder | From | To | |
| Rename Method public getDeployStepWaitTimeSeconds() : Optional<Integer> renamed to public getDeployStepWaitTimeMs() : Optional<Integer> in class com.hubspot.singularity.SingularityDeployBuilder | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute deployStepWaitTimeSeconds : Optional<Integer> to deployStepWaitTimeMs : Optional<Integer> in class com.hubspot.singularity.SingularityDeployBuilder | From | To | |
| Extract Method | 2 | ||
| Extract Method private enqueueAndProcessLbRequest(request SingularityRequest, deploy Optional<SingularityDeploy>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>) : SingularityDeployResult extracted from private checkDeployProgress(request SingularityRequest, cancelRequest Optional<SingularityDeployMarker>, pendingDeploy SingularityPendingDeploy, updatePendingDeployRequest Optional<SingularityUpdatePendingDeployRequest>, deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract Method private numInstancesExpected(request SingularityRequest, pendingRequest SingularityPendingRequest, maybePendingDeploy Optional<SingularityPendingDeploy>) : int extracted from private getNumMissingInstances(matchingTaskIds List<SingularityTaskId>, request SingularityRequest, pendingRequest SingularityPendingRequest, maybePendingDeploy Optional<SingularityPendingDeploy>) : int in class com.hubspot.singularity.scheduler.SingularityScheduler | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter deployStepWaitTimeSeconds : Optional<Integer> to deployStepWaitTimeMs : Optional<Integer> in method public setDeployStepWaitTimeMs(deployStepWaitTimeMs Optional<Integer>) : SingularityDeployBuilder in class com.hubspot.singularity.SingularityDeployBuilder | From | To |