81c6b94be06803b45b45ecac7e3576d11f9ec157
Files Diff
- Added: 9
- Removed: 1
- Renamed: 0
- Modified: 27
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public submit(request SingularityRequest) : SingularityRequestParent renamed to private submitRequest(request SingularityRequest, requestState RequestState, skipHealthchecks Optional<Boolean>) : SingularityRequestParent in class com.hubspot.singularity.resources.RequestResource | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type requestIdsToReschedule : Set<String> to requestIdsToUserToReschedule : Map<String,Optional<String>> in method private cleanupTaskDueToDecomission(requestIdsToUserToReschedule Map<String,Optional<String>>, matchingTaskIds Set<SingularityTaskId>, task SingularityTask, decommissioningObject SingularityMachineAbstraction<?>) : void in class com.hubspot.singularity.scheduler.SingularityScheduler | From | To | |
| Change Parameter Type incremental : boolean to bounceRequest : Optional<SingularityBounceRequest> in method public bounce(requestId String, bounceRequest Optional<SingularityBounceRequest>) : SingularityRequestParent in class com.hubspot.singularity.resources.RequestResource | From | To | |
| Move Method | 2 | ||
| Move Method public getUser() : Optional<String> from class com.hubspot.singularity.api.SingularityDeployRequest to public getUser() : Optional<String> from class com.hubspot.singularity.expiring.SingularityExpiringParent | From | To | |
| Move Method public getUser() : Optional<String> from class com.hubspot.singularity.api.SingularityPauseRequest to public getUser() : Optional<String> from class com.hubspot.singularity.expiring.SingularityExpiringParent | From | To | |
| Rename Variable | 2 | ||
| Rename Variable incremental : boolean to isIncrementalBounce : boolean in method public bounce(requestId String, bounceRequest Optional<SingularityBounceRequest>) : SingularityRequestParent in class com.hubspot.singularity.resources.RequestResource | From | To | |
| Rename Variable requestIdsToReschedule : Set<String> to requestIdsToUserToReschedule : Map<String,Optional<String>> in method public checkForDecomissions(stateCache SingularitySchedulerStateCache) : void in class com.hubspot.singularity.scheduler.SingularityScheduler | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute user : Optional<String> to durationMillis : Optional<Long> in class com.hubspot.singularity.api.SingularityPauseRequest | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type requestIdsToReschedule : Set<String> to requestIdsToUserToReschedule : Map<String,Optional<String>> in method public checkForDecomissions(stateCache SingularitySchedulerStateCache) : void in class com.hubspot.singularity.scheduler.SingularityScheduler | From | To | |
| Extract Method | 3 | ||
| Extract Method private pendingTask(requestId String, deployId String, pendingType PendingType) : SingularityPendingTask extracted from public testSchedulerIsolatesPendingTasksBasedOnDeploy() : void in class com.hubspot.singularity.scheduler.SingularitySchedulerTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type user : Optional<String> to durationMillis : Optional<Long> in class com.hubspot.singularity.api.SingularityPauseRequest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter incremental : boolean to bounceRequest : Optional<SingularityBounceRequest> in method public bounce(requestId String, bounceRequest Optional<SingularityBounceRequest>) : SingularityRequestParent in class com.hubspot.singularity.resources.RequestResource | From | To | |
| Rename Parameter requestIdsToReschedule : Set<String> to requestIdsToUserToReschedule : Map<String,Optional<String>> in method private cleanupTaskDueToDecomission(requestIdsToUserToReschedule Map<String,Optional<String>>, matchingTaskIds Set<SingularityTaskId>, task SingularityTask, decommissioningObject SingularityMachineAbstraction<?>) : void in class com.hubspot.singularity.scheduler.SingularityScheduler | From | To |