84e112bf9ec4b9d04306ebb813a1dce2452e4fde
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 14
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Added | |
| com.amazonaws:aws-java-sdk-s3:1.10.77 | |
| Updated | |
| From com.fasterxml.jackson.module:jackson-module-mrbean 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.module:jackson-module-parameter-names 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-avro 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-joda 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.module:jackson-module-afterburner 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jsr353 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-mrbean 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.core:jackson-annotations 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-paranamer 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-afterburner 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.core:jackson-databind 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jsr310 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hppc 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hibernate4 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.core:jackson-core 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-yaml 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-smile-provider 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-csv 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hppc 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-guice 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jdk7 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-cbor-provider 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-avro 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-paranamer 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-base 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hibernate3 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jsr353 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-smile 2.4.2 To 2.6.4 | |
| From com.amazonaws:aws-java-sdk-elasticloadbalancing 1.9.37 To 1.10.77 | |
| From com.fasterxml.jackson.module:jackson-module-jaxb-annotations 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-jsonSchema 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.core:jackson-annotations 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-cbor 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-json-org 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jdk8 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-base 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.core:jackson-core 2.4.2 To 2.6.4 | |
| From com.amazonaws:aws-java-sdk-core 1.9.37 To 1.10.77 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-csv 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-xml 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jdk8 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-kotlin 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.module:jackson-module-jsonSchema 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-cbor 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-xml-provider 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-smile-provider 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-guava 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-json-org 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-smile 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-guava 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.module:jackson-module-jaxb-annotations 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.module:jackson-module-parameter-names 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hibernate3 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-xml-provider 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jsr310 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.core:jackson-databind 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jdk7 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hibernate4 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-cbor-provider 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-joda 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-xml 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.module:jackson-module-kotlin 2.6.4 To 2.4.2 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-yaml 2.4.2 To 2.6.4 | |
| From com.fasterxml.jackson.module:jackson-module-guice 2.4.2 To 2.6.4 |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public getS3Service() : S3Service renamed to public getS3Client() : AmazonS3 in class com.hubspot.singularity.helpers.SingularityS3Service | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type defaultCredentials : AWSCredentials to defaultCredentials : BasicAWSCredentials in method public SingularityS3Uploader(defaultCredentials BasicAWSCredentials, uploadMetadata S3UploadMetadata, fileSystem FileSystem, metrics SingularityS3UploaderMetrics, metadataPath Path, configuration SingularityS3UploaderConfiguration, hostname String, exceptionNotifier SingularityRunnerExceptionNotifier) in class com.hubspot.singularity.s3uploader.SingularityS3Uploader | From | To | |
| Change Parameter Type s3 : S3Service to s3 : AmazonS3 in method public S3ArtifactChunkDownloader(configuration SingularityS3Configuration, log Logger, s3 AmazonS3, s3Artifact S3Artifact, downloadTo Path, chunk int, chunkSize long, length long, exceptionNotifier SingularityRunnerExceptionNotifier) in class com.hubspot.singularity.s3.base.S3ArtifactChunkDownloader | From | To | |
| Change Parameter Type s3Service : S3Service to s3Client : AmazonS3 in method public SingularityS3Service(group String, bucket String, s3Client AmazonS3) in class com.hubspot.singularity.helpers.SingularityS3Service | From | To | |
| Rename Variable | 4 | ||
| Rename Variable s3Service : S3Service to s3Client : AmazonS3 in method private getS3LogsWithExecutorService(s3Configuration S3Configuration, group Optional<String>, executorService ListeningExecutorService, prefixes Collection<String>, excludeMetadata boolean, listOnly boolean) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource | From | To | |
| Rename Variable object : S3Object to objectMetadata : ObjectMetadata in method public call() : Boolean in class com.hubspot.singularity.s3uploader.SingularityS3Uploader.Uploader | From | To | |
| Rename Variable s3 : S3Service to s3Client : AmazonS3 in method private downloadThrows(s3Artifact S3Artifact, downloadTo Path) : void in class com.hubspot.singularity.s3.base.S3ArtifactDownloader | From | To | |
| Change Return Type | 5 | ||
| Change Return Type S3Service to AmazonS3 in method public getServiceByGroupAndBucketOrDefault(group String, bucket String) : AmazonS3 in class com.hubspot.singularity.helpers.SingularityS3Services | From | To | |
| Change Return Type S3Service to AmazonS3 in method public getS3Client() : AmazonS3 in class com.hubspot.singularity.helpers.SingularityS3Service | From | To | |
| Change Return Type AWSCredentials to BasicAWSCredentials in method public toAWSCredentials() : BasicAWSCredentials in class com.hubspot.singularity.s3.base.config.SingularityS3Credentials | From | To | |
| Change Return Type AWSCredentials to BasicAWSCredentials in method private getCredentialsForBucket(bucketName String) : BasicAWSCredentials in class com.hubspot.singularity.s3.base.S3ArtifactDownloader | From | To | |
| Change Return Type long to Long in method public getS3ChunkDownloadTimeoutMillis() : Long in class com.hubspot.singularity.s3.base.config.SingularityS3Configuration | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute s3Service : S3Service to s3Client : AmazonS3 in class com.hubspot.singularity.helpers.SingularityS3Service | From | To | |
| Rename Attribute s3Service : S3Service to s3Client : AmazonS3 in class com.hubspot.singularity.s3uploader.SingularityS3Uploader | From | To | |
| Change Variable Type | 13 | ||
| Change Variable Type objects : List<S3Object> to objects : List<S3ObjectSummary> in method private getS3LogsWithExecutorService(s3Configuration S3Configuration, group Optional<String>, executorService ListeningExecutorService, prefixes Collection<String>, excludeMetadata boolean, listOnly boolean) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource | From | To | |
| Change Variable Type results : List<S3Object[]> to results : List<List<S3ObjectSummary>> in method private getS3LogsWithExecutorService(s3Configuration S3Configuration, group Optional<String>, executorService ListeningExecutorService, prefixes Collection<String>, excludeMetadata boolean, listOnly boolean) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource | From | To | |
| Change Variable Type object : S3Object to objectMetadata : ObjectMetadata in method public call() : Boolean in class com.hubspot.singularity.s3uploader.SingularityS3Uploader.Uploader | From | To | |
| Change Variable Type bucketCreds : Optional<AWSCredentials> to bucketCreds : Optional<BasicAWSCredentials> in method private handleNewOrModifiedS3Metadata(filename Path) : boolean in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver | From | To | |
| Change Variable Type s3Object : S3Object to s3Object : S3ObjectSummary in method private getS3LogsWithExecutorService(s3Configuration S3Configuration, group Optional<String>, executorService ListeningExecutorService, prefixes Collection<String>, excludeMetadata boolean, listOnly boolean) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource | From | To | |
| Change Variable Type credentials : AWSCredentials to credentials : BasicAWSCredentials in method public SingularityS3Uploader(defaultCredentials BasicAWSCredentials, uploadMetadata S3UploadMetadata, fileSystem FileSystem, metrics SingularityS3UploaderMetrics, metadataPath Path, configuration SingularityS3UploaderConfiguration, hostname String, exceptionNotifier SingularityRunnerExceptionNotifier) in class com.hubspot.singularity.s3uploader.SingularityS3Uploader | From | To | |
| Change Variable Type s3 : S3Service to s3Client : AmazonS3 in method private downloadThrows(s3Artifact S3Artifact, downloadTo Path) : void in class com.hubspot.singularity.s3.base.S3ArtifactDownloader | From | To | |
| Change Variable Type defaultCredentials : AWSCredentials to defaultCredentials : BasicAWSCredentials in method private handleNewOrModifiedS3Metadata(filename Path) : boolean in class com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver | From | To | |
| Change Variable Type futures : List<ListenableFuture<S3Object[]>> to futures : List<ListenableFuture<List<S3ObjectSummary>>> in method private getS3LogsWithExecutorService(s3Configuration S3Configuration, group Optional<String>, executorService ListeningExecutorService, prefixes Collection<String>, excludeMetadata boolean, listOnly boolean) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource | From | To | |
| Change Variable Type s3Objects : S3Object[] to s3Objects : List<S3ObjectSummary> in method private getS3LogsWithExecutorService(s3Configuration S3Configuration, group Optional<String>, executorService ListeningExecutorService, prefixes Collection<String>, excludeMetadata boolean, listOnly boolean) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource | From | To | |
| Change Variable Type s3Service : S3Service to s3Client : AmazonS3 in method private getS3LogsWithExecutorService(s3Configuration S3Configuration, group Optional<String>, executorService ListeningExecutorService, prefixes Collection<String>, excludeMetadata boolean, listOnly boolean) : List<SingularityS3LogMetadata> in class com.hubspot.singularity.resources.S3LogResource | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type s3Service : S3Service to s3Client : AmazonS3 in class com.hubspot.singularity.helpers.SingularityS3Service | From | To | |
| Change Attribute Type s3Service : S3Service to s3Client : AmazonS3 in class com.hubspot.singularity.s3uploader.SingularityS3Uploader | From | To | |
| Change Attribute Type s3 : S3Service to s3 : AmazonS3 in class com.hubspot.singularity.s3.base.S3ArtifactChunkDownloader | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter s3Service : S3Service to s3Client : AmazonS3 in method public SingularityS3Service(group String, bucket String, s3Client AmazonS3) in class com.hubspot.singularity.helpers.SingularityS3Service | From | To |