Singularity 84f739a58b46bd17853768d8f2fbc9c37a071957

84f739a58b46bd17853768d8f2fbc9c37a071957

Files Diff

Added: 2
Removed: 2
Renamed: 0
Modified: 22

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	3
Change Parameter Type executorService : ScheduledExecutorService to executorServiceFactory : SingularityManagedScheduledExecutorServiceFactory in method public SingularityHealthchecker(executorServiceFactory SingularityManagedScheduledExecutorServiceFactory, http AsyncHttpClient, configuration SingularityConfiguration, newTaskChecker SingularityNewTaskChecker, taskManager TaskManager, abort SingularityAbort, exceptionNotifier SingularityExceptionNotifier, disasterManager DisasterManager, mesosProtosUtils MesosProtosUtils) in class com.hubspot.singularity.scheduler.SingularityHealthchecker	From	To
Change Parameter Type listenerExecutorService : ScheduledExecutorService to scheduledExecutorServiceFactory : SingularityManagedScheduledExecutorServiceFactory in method package SingularityEventController(eventListeners Set<SingularityEventListener>, configuration SingularityConfiguration, scheduledExecutorServiceFactory SingularityManagedScheduledExecutorServiceFactory) in class com.hubspot.singularity.event.SingularityEventController	From	To
Change Parameter Type executorService : ScheduledExecutorService to executorServiceFactory : SingularityManagedScheduledExecutorServiceFactory in method public SingularityNewTaskChecker(executorServiceFactory SingularityManagedScheduledExecutorServiceFactory, requestManager RequestManager, configuration SingularityConfiguration, lbClient LoadBalancerClient, taskManager TaskManager, exceptionNotifier SingularityExceptionNotifier, abort SingularityAbort, deployHealthHelper SingularityDeployHealthHelper, disasterManager DisasterManager, mailer SingularityMailer) in class com.hubspot.singularity.scheduler.SingularityNewTaskChecker	From	To
Move Method	3
Move Method public start() : void from class com.hubspot.singularity.SingularityCuratorProvider to public start() : void from class com.hubspot.singularity.managed.SingularityLifecycleManaged	From	To
Move Method public stop() : void from class com.hubspot.singularity.SingularityCuratorProvider to public stop() : void from class com.hubspot.singularity.managed.SingularityLifecycleManaged	From	To
Move Method public get() : ScheduledExecutorService from class com.hubspot.singularity.SingularityManagedScheduledExecutorServiceProvider to public get(name String, poolSize int) : ScheduledExecutorService from class com.hubspot.singularity.SingularityManagedScheduledExecutorServiceFactory	From	To
Move Attribute	3
Move Attribute private started : AtomicBoolean from class com.hubspot.singularity.SingularityCuratorProvider to private started : AtomicBoolean from class com.hubspot.singularity.managed.SingularityLifecycleManaged	From	To
Move Attribute private stopped : AtomicBoolean from class com.hubspot.singularity.SingularityCuratorProvider to private stopped : AtomicBoolean from class com.hubspot.singularity.managed.SingularityLifecycleManaged	From	To
Move Attribute private flushingExecutor : ScheduledExecutorService from class com.hubspot.singularity.async.AsyncSemaphore to private flushingExecutor : ScheduledExecutorService from class com.hubspot.singularity.async.AsyncSemaphoreBuilder	From	To
Extract Class	1
Extract Class com.hubspot.singularity.managed.SingularityLifecycleManaged from class com.hubspot.singularity.SingularityCuratorProvider	From	To
Rename Class	1
Rename Class com.hubspot.singularity.metrics.SingularityGraphiteReporterManaged renamed to com.hubspot.singularity.metrics.SingularityGraphiteReporter	From	To
Extract Method	3
Extract Method private stopCurator() : void extracted from public stop() : void in class com.hubspot.singularity.managed.SingularityLifecycleManaged	From	To
Extract Method private startCurator() : void extracted from public start() : void in class com.hubspot.singularity.managed.SingularityLifecycleManaged	From	To
Extract Method public get(name String, poolSize int) : ScheduledExecutorService extracted from public get(name String) : ScheduledExecutorService in class com.hubspot.singularity.SingularityManagedScheduledExecutorServiceFactory	From	To
Rename Parameter	3
Rename Parameter executorService : ScheduledExecutorService to executorServiceFactory : SingularityManagedScheduledExecutorServiceFactory in method public SingularityHealthchecker(executorServiceFactory SingularityManagedScheduledExecutorServiceFactory, http AsyncHttpClient, configuration SingularityConfiguration, newTaskChecker SingularityNewTaskChecker, taskManager TaskManager, abort SingularityAbort, exceptionNotifier SingularityExceptionNotifier, disasterManager DisasterManager, mesosProtosUtils MesosProtosUtils) in class com.hubspot.singularity.scheduler.SingularityHealthchecker	From	To
Rename Parameter listenerExecutorService : ScheduledExecutorService to scheduledExecutorServiceFactory : SingularityManagedScheduledExecutorServiceFactory in method package SingularityEventController(eventListeners Set<SingularityEventListener>, configuration SingularityConfiguration, scheduledExecutorServiceFactory SingularityManagedScheduledExecutorServiceFactory) in class com.hubspot.singularity.event.SingularityEventController	From	To
Rename Parameter executorService : ScheduledExecutorService to executorServiceFactory : SingularityManagedScheduledExecutorServiceFactory in method public SingularityNewTaskChecker(executorServiceFactory SingularityManagedScheduledExecutorServiceFactory, requestManager RequestManager, configuration SingularityConfiguration, lbClient LoadBalancerClient, taskManager TaskManager, exceptionNotifier SingularityExceptionNotifier, abort SingularityAbort, deployHealthHelper SingularityDeployHealthHelper, disasterManager DisasterManager, mailer SingularityMailer) in class com.hubspot.singularity.scheduler.SingularityNewTaskChecker	From	To

84f739a58b46bd17853768d8f2fbc9c37a071957

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: