8fd2c279c0d2ad319b309c8adc5df3faef56e041
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type asyncDownloadService : ThreadPoolExecutor to downloaderCoordinator : SingularityS3DownloaderCoordinator in method public SingularityS3DownloaderHandler(artifactManagerProvider Provider<ArtifactManager>, s3Configuration SingularityS3Configuration, objectMapper ObjectMapper, downloaderCoordinator SingularityS3DownloaderCoordinator, metrics SingularityS3DownloaderMetrics) in class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderHandler | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private artifactManagerProvider : Provider<ArtifactManager> from class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderHandler to private artifactManagerProvider : Provider<ArtifactManager> from class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderCoordinator | From | To | |
| Move Attribute private continuation : Continuation from class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderAsyncHandler to private continuation : Continuation from class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderCoordinator.DownloadJoiner | From | To | |
| Move Attribute private LOG : Logger from class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderHandler to private LOG : Logger from class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderCoordinator | From | To | |
| Extract Class | 1 | ||
| Extract Class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderCoordinator from class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderHandler | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute continuation : Continuation to continuations : List<Continuation> in class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderAsyncHandler | From | To | |
| Rename Attribute asyncDownloadService : ThreadPoolExecutor to downloaderCoordinator : SingularityS3DownloaderCoordinator in class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderHandler | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type continuation : Continuation to continuations : List<Continuation> in class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderAsyncHandler | From | To | |
| Change Attribute Type asyncDownloadService : ThreadPoolExecutor to downloaderCoordinator : SingularityS3DownloaderCoordinator in class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderHandler | From | To | |
| Extract Method | 1 | ||
| Extract Method private completeContinuations() : void extracted from public run() : void in class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderAsyncHandler | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter asyncDownloadService : ThreadPoolExecutor to downloaderCoordinator : SingularityS3DownloaderCoordinator in method public SingularityS3DownloaderHandler(artifactManagerProvider Provider<ArtifactManager>, s3Configuration SingularityS3Configuration, objectMapper ObjectMapper, downloaderCoordinator SingularityS3DownloaderCoordinator, metrics SingularityS3DownloaderMetrics) in class com.hubspot.singularity.s3downloader.server.SingularityS3DownloaderHandler | From | To |