a1cfb1d0d51f53c06a250651fdd4751d3ebfea66
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 2
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public getDeleteTaskHistoryBytesInsteadOfEntireRow() : Optional<Boolean> renamed to public getDeleteTaskHistoryBytesAfterDays() : Optional<Integer> in class com.hubspot.singularity.config.HistoryPurgeRequestSettings | From | To | |
| Rename Method public setDeleteTaskHistoryBytesInsteadOfEntireRow(deleteTaskHistoryBytesInsteadOfEntireRow Optional<Boolean>) : HistoryPurgeRequestOverride renamed to public setDeleteTaskHistoryBytesAfterDays(deleteTaskHistoryBytesAfterDays Optional<Integer>) : void in class com.hubspot.singularity.config.HistoryPurgeRequestSettings | From | To | |
| Rename Method public setDeleteTaskHistoryBytesInsteadOfEntireRow(deleteTaskHistoryBytesInsteadOfEntireRow boolean) : void renamed to public setDeleteTaskHistoryBytesAfterDays(deleteTaskHistoryBytesAfterDays int) : void in class com.hubspot.singularity.config.HistoryPurgingConfiguration | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type requestOverrides : Map<String,HistoryPurgeRequestOverride> to requestOverrides : Map<String,HistoryPurgeRequestSettings> in method public setRequestOverrides(requestOverrides Map<String,HistoryPurgeRequestSettings>) : void in class com.hubspot.singularity.config.HistoryPurgingConfiguration | From | To | |
| Change Parameter Type deleteTaskHistoryBytesInsteadOfEntireRow : Optional<Boolean> to deleteTaskHistoryBytesAfterDays : Optional<Integer> in method public setDeleteTaskHistoryBytesAfterDays(deleteTaskHistoryBytesAfterDays Optional<Integer>) : void in class com.hubspot.singularity.config.HistoryPurgeRequestSettings | From | To | |
| Change Parameter Type deleteTaskHistoryBytesInsteadOfEntireRow : boolean to deleteTaskHistoryBytesAfterDays : int in method public setDeleteTaskHistoryBytesAfterDays(deleteTaskHistoryBytesAfterDays int) : void in class com.hubspot.singularity.config.HistoryPurgingConfiguration | From | To | |
| Rename Variable | 1 | ||
| Rename Variable override : HistoryPurgeRequestOverride to settings : HistoryPurgeRequestSettings in method public runActionOnPoll() : void in class com.hubspot.singularity.data.history.SingularityHistoryPurger | From | To | |
| Change Return Type | 5 | ||
| Change Return Type HistoryPurgeRequestOverride to void in method public setDeleteTaskHistoryBytesAfterDays(deleteTaskHistoryBytesAfterDays Optional<Integer>) : void in class com.hubspot.singularity.config.HistoryPurgeRequestSettings | From | To | |
| Change Return Type Map<String,HistoryPurgeRequestOverride> to Map<String,HistoryPurgeRequestSettings> in method public getRequestOverrides() : Map<String,HistoryPurgeRequestSettings> in class com.hubspot.singularity.config.HistoryPurgingConfiguration | From | To | |
| Change Return Type Optional<Boolean> to Optional<Integer> in method public getDeleteTaskHistoryBytesAfterDays() : Optional<Integer> in class com.hubspot.singularity.config.HistoryPurgeRequestSettings | From | To | |
| Change Return Type HistoryPurgeRequestOverride to HistoryPurgeRequestSettings in method public setDeleteTaskHistoryAfterDays(deleteTaskHistoryAfterDays Optional<Integer>) : HistoryPurgeRequestSettings in class com.hubspot.singularity.config.HistoryPurgeRequestSettings | From | To | |
| Change Return Type HistoryPurgeRequestOverride to void in method public setDeleteTaskHistoryAfterTasksPerRequest(deleteTaskHistoryAfterTasksPerRequest Optional<Integer>) : void in class com.hubspot.singularity.config.HistoryPurgeRequestSettings | From | To | |
| Rename Class | 1 | ||
| Rename Class com.hubspot.singularity.config.HistoryPurgeRequestOverride renamed to com.hubspot.singularity.config.HistoryPurgeRequestSettings | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute deleteTaskHistoryBytesInsteadOfEntireRow : Optional<Boolean> to deleteTaskHistoryBytesAfterDays : Optional<Integer> in class com.hubspot.singularity.config.HistoryPurgeRequestSettings | From | To | |
| Rename Attribute deleteTaskHistoryBytesInsteadOfEntireRow : boolean to deleteTaskHistoryBytesAfterDays : int in class com.hubspot.singularity.config.HistoryPurgingConfiguration | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type override : HistoryPurgeRequestOverride to override : HistoryPurgeRequestSettings in method private getRequestPurgeSettings(requestId String) : HistoryPurgeRequestSettings in class com.hubspot.singularity.data.history.SingularityHistoryPurger | From | To | |
| Change Variable Type override : HistoryPurgeRequestOverride to settings : HistoryPurgeRequestSettings in method public runActionOnPoll() : void in class com.hubspot.singularity.data.history.SingularityHistoryPurger | From | To | |
| Extract Method | 2 | ||
| Extract Method private purge(requestId String, start long, afterTasksPerRequest Optional<Integer>, afterDays Optional<Integer>, deleteRow boolean) : void extracted from public runActionOnPoll() : void in class com.hubspot.singularity.data.history.SingularityHistoryPurger | From | To | |
| Extract Method private getRequestPurgeSettings(requestId String) : HistoryPurgeRequestSettings extracted from public runActionOnPoll() : void in class com.hubspot.singularity.data.history.SingularityHistoryPurger | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type deleteTaskHistoryBytesInsteadOfEntireRow : Optional<Boolean> to deleteTaskHistoryBytesAfterDays : Optional<Integer> in class com.hubspot.singularity.config.HistoryPurgeRequestSettings | From | To | |
| Change Attribute Type deleteTaskHistoryBytesInsteadOfEntireRow : boolean to deleteTaskHistoryBytesAfterDays : int in class com.hubspot.singularity.config.HistoryPurgingConfiguration | From | To | |
| Change Attribute Type requestOverrides : Map<String,HistoryPurgeRequestOverride> to requestOverrides : Map<String,HistoryPurgeRequestSettings> in class com.hubspot.singularity.config.HistoryPurgingConfiguration | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter deleteTaskHistoryBytesInsteadOfEntireRow : boolean to deleteTaskHistoryBytesAfterDays : int in method public setDeleteTaskHistoryBytesAfterDays(deleteTaskHistoryBytesAfterDays int) : void in class com.hubspot.singularity.config.HistoryPurgingConfiguration | From | To | |
| Rename Parameter deleteTaskHistoryBytesInsteadOfEntireRow : Optional<Boolean> to deleteTaskHistoryBytesAfterDays : Optional<Integer> in method public setDeleteTaskHistoryBytesAfterDays(deleteTaskHistoryBytesAfterDays Optional<Integer>) : void in class com.hubspot.singularity.config.HistoryPurgeRequestSettings | From | To |