a34ca3de126a40c8956a5e60f5a441b992a78241
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 6 | ||
| Rename Method public setDeleteAfterDeploysPerRequestWhenNoDatabase(deleteAfterDeploysPerRequestWhenNoDatabase Optional<Long>) : void renamed to public setMaxStaleDeploysPerRequestWhenNoDatabase(maxStaleDeploysPerRequestWhenNoDatabase Optional<Integer>) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Method public setDeleteAfterTasksPerRequestWhenNoDatabase(deleteAfterTasksPerRequestWhenNoDatabase Optional<Long>) : void renamed to public setMaxStaleTasksPerRequestWhenNoDatabase(maxStaleTasksPerRequestWhenNoDatabase Optional<Integer>) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Method public testRequestPurging() : void renamed to public testRequestAgePurging() : void in class com.hubspot.singularity.scheduler.HistoryPersisterTest | From | To | |
| Rename Method public getDeleteAfterTasksPerRequestWhenNoDatabase() : Optional<Long> renamed to public getMaxStaleTasksPerRequestWhenNoDatabase() : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Method public testTaskPurging() : void renamed to public testTaskAgePurging() : void in class com.hubspot.singularity.scheduler.HistoryPersisterTest | From | To | |
| Rename Method public getDeleteAfterDeploysPerRequestWhenNoDatabase() : Optional<Long> renamed to public getMaxStaleDeploysPerRequestWhenNoDatabase() : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type deleteAfterTasksPerRequestWhenNoDatabase : Optional<Long> to maxStaleTasksPerRequestWhenNoDatabase : Optional<Integer> in method public setMaxStaleTasksPerRequestWhenNoDatabase(maxStaleTasksPerRequestWhenNoDatabase Optional<Integer>) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Parameter Type deleteAfterDeploysPerRequestWhenNoDatabase : Optional<Long> to maxStaleDeploysPerRequestWhenNoDatabase : Optional<Integer> in method public setMaxStaleDeploysPerRequestWhenNoDatabase(maxStaleDeploysPerRequestWhenNoDatabase Optional<Integer>) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Parameter Type maxStaleRequestsInZkWhenNoDatabase : Optional<Long> to maxStaleRequestsInZkWhenNoDatabase : Optional<Integer> in method public setMaxStaleRequestsInZkWhenNoDatabase(maxStaleRequestsInZkWhenNoDatabase Optional<Integer>) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Variable | 1 | ||
| Rename Variable eligbleTaskIdByRequest : Map<String,List<SingularityTaskId>> to eligibleTaskIdByRequestId : Multimap<String,SingularityTaskId> in method public runActionOnPoll() : void in class com.hubspot.singularity.data.history.SingularityTaskHistoryPersister | From | To | |
| Change Return Type | 7 | ||
| Change Return Type Optional<Long> to Optional<Integer> in method public getMaxStaleTasksPerRequestWhenNoDatabase() : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Return Type Optional<Long> to Optional<Integer> in method public getMaxStaleDeploysPerRequestWhenNoDatabase() : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Return Type Optional<Long> to Optional<Integer> in method protected getMaxNumberOfItems() : Optional<Integer> in class com.hubspot.singularity.data.history.SingularityTaskHistoryPersister | From | To | |
| Change Return Type Optional<Long> to Optional<Integer> in method protected abstract getMaxNumberOfItems() : Optional<Integer> in class com.hubspot.singularity.data.history.SingularityHistoryPersister | From | To | |
| Change Return Type Optional<Long> to Optional<Integer> in method protected getMaxNumberOfItems() : Optional<Integer> in class com.hubspot.singularity.data.history.SingularityDeployHistoryPersister | From | To | |
| Change Return Type Optional<Long> to Optional<Integer> in method public getMaxStaleRequestsInZkWhenNoDatabase() : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Return Type Optional<Long> to Optional<Integer> in method protected getMaxNumberOfItems() : Optional<Integer> in class com.hubspot.singularity.data.history.SingularityRequestHistoryPersister | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute deleteAfterDeploysPerRequestWhenNoDatabase : Optional<Long> to maxStaleDeploysPerRequestWhenNoDatabase : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Attribute deleteAfterTasksPerRequestWhenNoDatabase : Optional<Long> to maxStaleTasksPerRequestWhenNoDatabase : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type entry : Map.Entry<String,List<SingularityTaskId>> to entry : Map.Entry<String,Collection<SingularityTaskId>> in method public runActionOnPoll() : void in class com.hubspot.singularity.data.history.SingularityTaskHistoryPersister | From | To | |
| Change Variable Type eligbleTaskIdByRequest : Map<String,List<SingularityTaskId>> to eligibleTaskIdByRequestId : Multimap<String,SingularityTaskId> in method public runActionOnPoll() : void in class com.hubspot.singularity.data.history.SingularityTaskHistoryPersister | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type deleteAfterDeploysPerRequestWhenNoDatabase : Optional<Long> to maxStaleDeploysPerRequestWhenNoDatabase : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Attribute Type maxStaleRequestsInZkWhenNoDatabase : Optional<Long> to maxStaleRequestsInZkWhenNoDatabase : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Attribute Type deleteAfterTasksPerRequestWhenNoDatabase : Optional<Long> to maxStaleTasksPerRequestWhenNoDatabase : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter deleteAfterDeploysPerRequestWhenNoDatabase : Optional<Long> to maxStaleDeploysPerRequestWhenNoDatabase : Optional<Integer> in method public setMaxStaleDeploysPerRequestWhenNoDatabase(maxStaleDeploysPerRequestWhenNoDatabase Optional<Integer>) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Parameter deleteAfterTasksPerRequestWhenNoDatabase : Optional<Long> to maxStaleTasksPerRequestWhenNoDatabase : Optional<Integer> in method public setMaxStaleTasksPerRequestWhenNoDatabase(maxStaleTasksPerRequestWhenNoDatabase Optional<Integer>) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To |