a7458b54a4bd863f9b695d4fac86e79bccc067a9
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public getCooldownAfterFailures() : int renamed to public getFastFailureCooldownCount() : int in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Method public getCooldownExpiresAfterMinutes() : long renamed to public getSlowFailureCooldownMs() : long in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Variable | 1 | ||
| Rename Variable numFailuresInsideCooldown : int to failureCount : long in method private hasFastFailureLoop(deployStatistics SingularityDeployStatistics, recentFailureTimestamp Optional<Long>) : boolean in class com.hubspot.singularity.scheduler.SingularityCooldown | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type numFailuresInsideCooldown : int to failureCount : long in method private hasFastFailureLoop(deployStatistics SingularityDeployStatistics, recentFailureTimestamp Optional<Long>) : boolean in class com.hubspot.singularity.scheduler.SingularityCooldown | From | To | |
| Extract Method | 2 | ||
| Extract Method private hasSlowFailureLoop(deployStatistics SingularityDeployStatistics, recentFailureTimestamp Optional<Long>) : boolean extracted from private hasFailedTooManyTimes(request SingularityRequest, deployStatistics SingularityDeployStatistics, instanceNo Optional<Integer>, recentFailureTimestamp Optional<Long>) : boolean in class com.hubspot.singularity.scheduler.SingularityCooldown | From | To | |
| Extract Method private hasFastFailureLoop(deployStatistics SingularityDeployStatistics, recentFailureTimestamp Optional<Long>) : boolean extracted from private hasFailedTooManyTimes(request SingularityRequest, deployStatistics SingularityDeployStatistics, instanceNo Optional<Integer>, recentFailureTimestamp Optional<Long>) : boolean in class com.hubspot.singularity.scheduler.SingularityCooldown | From | To |