b5dde258f8b498de6fbd3f42a6e4a91a42180908
Files Diff
- Added: 4
- Removed: 1
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type requestManager : RequestManager to adminHelper : SingularityAuthorizationHelper in method public HistoryResource(historyManager HistoryManager, taskManager TaskManager, deployManager DeployManager, deployHistoryHelper DeployHistoryHelper, taskHistoryHelper TaskHistoryHelper, requestHistoryHelper RequestHistoryHelper, adminHelper SingularityAuthorizationHelper, validator SingularityValidator, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.HistoryResource | From | To | |
| Change Return Type | 3 | ||
| Change Return Type Iterable<SingularityPendingRequest> to List<SingularityPendingRequest> in method public getPendingRequests() : List<SingularityPendingRequest> in class com.hubspot.singularity.resources.RequestResource | From | To | |
| Change Return Type Iterable<SingularityPendingDeploy> to List<SingularityPendingDeploy> in method public getPendingDeploys() : List<SingularityPendingDeploy> in class com.hubspot.singularity.resources.DeployResource | From | To | |
| Change Return Type List<SingularityTaskRequest> to Iterable<SingularityTaskRequest> in method public getScheduledTasks() : Iterable<SingularityTaskRequest> in class com.hubspot.singularity.resources.TaskResource | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private requestManager : RequestManager from class com.hubspot.singularity.resources.HistoryResource to private requestManager : RequestManager from class com.hubspot.singularity.auth.SingularityAuthorizationHelper | From | To | |
| Move Attribute private requestManager : RequestManager from class com.hubspot.singularity.resources.TaskResource to private requestManager : RequestManager from class com.hubspot.singularity.auth.SingularityAuthorizationHelper | From | To | |
| Extract Class | 2 | ||
| Extract Class com.hubspot.singularity.auth.SingularityAuthorizationHelper from class com.hubspot.singularity.resources.HistoryResource | From | To | |
| Extract Class com.hubspot.singularity.auth.SingularityAuthorizationHelper from class com.hubspot.singularity.resources.TaskResource | From | To | |
| Move Class | 1 | ||
| Move Class com.hubspot.singularity.ldap.SingularityLDAPManager moved to com.hubspot.singularity.auth.SingularityLDAPManager | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable authorizedRequests : Iterable<SingularityRequestWithState> to requests : Iterable<SingularityRequestWithState> in method private getRequestsWithDeployState(requests Iterable<SingularityRequestWithState>) : List<SingularityRequestParent> in class com.hubspot.singularity.resources.RequestResource | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute requestManager : RequestManager to adminHelper : SingularityAuthorizationHelper in class com.hubspot.singularity.resources.HistoryResource | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type requestManager : RequestManager to adminHelper : SingularityAuthorizationHelper in class com.hubspot.singularity.resources.HistoryResource | From | To | |
| Extract Method | 1 | ||
| Extract Method public hasAdminAuthorization(user Optional<SingularityUser>) : boolean extracted from public checkForAdminAuthorization(user Optional<SingularityUser>) : void in class com.hubspot.singularity.data.SingularityValidator | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter requestManager : RequestManager to adminHelper : SingularityAuthorizationHelper in method public HistoryResource(historyManager HistoryManager, taskManager TaskManager, deployManager DeployManager, deployHistoryHelper DeployHistoryHelper, taskHistoryHelper TaskHistoryHelper, requestHistoryHelper RequestHistoryHelper, adminHelper SingularityAuthorizationHelper, validator SingularityValidator, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.HistoryResource | From | To |