b778e64183812f2c26dc51734ab24653dad6e657
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 49
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Added | |
| io.dropwizard:dropwizard-auth:1.0.6 | |
| Updated | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jsr353 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hppc 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-csv 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.core:jackson-databind 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-avro 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hibernate3 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-joda 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-afterburner 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-json-org 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.module:jackson-module-jaxb-annotations 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jsr353 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-avro 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-csv 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hppc 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-paranamer 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-joda 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-base 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-smile 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-smile 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-mrbean 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.module:jackson-module-mrbean 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.core:jackson-annotations 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.core:jackson-annotations 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jdk8 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-xml-provider 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-base 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-paranamer 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-xml 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-smile-provider 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.module:jackson-module-parameter-names 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-json-org 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-cbor 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-cbor 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.core:jackson-core 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.module:jackson-module-jaxb-annotations 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.core:jackson-core 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-jsonSchema 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-smile-provider 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-kotlin 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.module:jackson-module-kotlin 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-jsonSchema 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.core:jackson-databind 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-xml 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hibernate3 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-xml-provider 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-afterburner 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jdk8 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.module:jackson-module-parameter-names 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-cbor-provider 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hibernate4 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-guava 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jdk7 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-guice 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-hibernate4 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-cbor-provider 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.module:jackson-module-guice 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jdk7 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-guava 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jsr310 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.datatype:jackson-datatype-jsr310 2.7.9 To 2.4.2 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-yaml 2.4.2 To 2.7.9 | |
| From com.fasterxml.jackson.dataformat:jackson-dataformat-yaml 2.7.9 To 2.4.2 |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public get() : Optional<SingularityUser> renamed to public getUser(context ContainerRequestContext) : Optional<SingularityUser> in class com.hubspot.singularity.SingularityTestAuthenticator | From | To | |
| Rename Method public get() : Optional<SingularityUser> renamed to private extractAuthHeader(context ContainerRequestContext) : String in class com.hubspot.singularity.auth.authenticator.SingularityWebhookAuthenticator | From | To | |
| Rename Method public get() : Optional<SingularityUser> renamed to public getUser(context ContainerRequestContext) : Optional<SingularityUser> in class com.hubspot.singularity.auth.authenticator.SingularityDisabledAuthenticator | From | To | |
| Change Parameter Type | 14 | ||
| Change Parameter Type user : Optional<SingularityUser> to user : SingularityUser in method public hasAdminAuthorization(user SingularityUser) : boolean in class com.hubspot.singularity.auth.SingularityAuthorizationHelper | From | To | |
| Change Parameter Type user : Optional<SingularityUser> to user : SingularityUser in method public checkForAuthorizationByRequestId(requestId String, user SingularityUser, scope SingularityAuthorizationScope) : void in class com.hubspot.singularity.auth.SingularityAuthorizationHelper | From | To | |
| Change Parameter Type user : Optional<SingularityUser> to user : SingularityUser in method public filterAuthorizedRequestIds(user SingularityUser, requestIds List<String>, scope SingularityAuthorizationScope, useWebCache boolean) : Iterable<String> in class com.hubspot.singularity.auth.SingularityAuthorizationHelper | From | To | |
| Change Parameter Type queryUser : Optional<String> to user : SingularityUser in method protected decommission(objectId String, decommissionRequest Optional<SingularityMachineChangeRequest>, user SingularityUser, action SingularityAction) : void in class com.hubspot.singularity.resources.AbstractMachineResource | From | To | |
| Change Parameter Type request : HttpServletRequest to user : SingularityUser in method public disableTaskCredits(user SingularityUser) : void in class com.hubspot.singularity.resources.DisastersResource | From | To | |
| Change Parameter Type user : Optional<SingularityUser> to user : SingularityUser in method public checkAdminAuthorization(user SingularityUser) : void in class com.hubspot.singularity.auth.SingularityAuthorizationHelper | From | To | |
| Change Parameter Type user : Optional<SingularityUser> to user : SingularityUser in method public filterByAuthorizedRequests(user SingularityUser, objects List<T>, requestIdFunction Function<T,String>, scope SingularityAuthorizationScope) : Iterable<T> in class com.hubspot.singularity.auth.SingularityAuthorizationHelper | From | To | |
| Change Parameter Type queryUser : Optional<String> to user : SingularityUser in method protected freeze(objectId String, freezeRequest Optional<SingularityMachineChangeRequest>, user SingularityUser, action SingularityAction) : void in class com.hubspot.singularity.resources.AbstractMachineResource | From | To | |
| Change Parameter Type queryUser : Optional<String> to user : SingularityUser in method protected activate(objectId String, activateRequest Optional<SingularityMachineChangeRequest>, user SingularityUser, action SingularityAction) : void in class com.hubspot.singularity.resources.AbstractMachineResource | From | To | |
| Change Parameter Type user : Optional<SingularityUser> to user : SingularityUser in method public isAuthorizedForRequest(request SingularityRequest, user SingularityUser, scope SingularityAuthorizationScope) : boolean in class com.hubspot.singularity.auth.SingularityAuthorizationHelper | From | To | |
| Change Parameter Type user : Optional<SingularityUser> to user : SingularityUser in method public checkForAuthorizedChanges(request SingularityRequest, oldRequest SingularityRequest, user SingularityUser) : void in class com.hubspot.singularity.auth.SingularityAuthorizationHelper | From | To | |
| Change Parameter Type user : Optional<SingularityUser> to user : SingularityUser in method public checkForAuthorization(request SingularityRequest, user SingularityUser, scope SingularityAuthorizationScope) : void in class com.hubspot.singularity.auth.SingularityAuthorizationHelper | From | To | |
| Change Parameter Type user : Optional<SingularityUser> to user : SingularityUser in method public checkForAuthorizationByTaskId(taskId String, user SingularityUser, scope SingularityAuthorizationScope) : void in class com.hubspot.singularity.auth.SingularityAuthorizationHelper | From | To | |
| Change Parameter Type queryUser : Optional<String> to user : SingularityUser in method private saveExpiring(changeRequest Optional<SingularityMachineChangeRequest>, user SingularityUser, objectId String) : void in class com.hubspot.singularity.resources.AbstractMachineResource | From | To | |
| Inline Method | 2 | ||
| Inline Method private extractAuthHeader(request HttpServletRequest) : String inlined to private extractAuthHeader(context ContainerRequestContext) : String in class com.hubspot.singularity.auth.authenticator.SingularityWebhookAuthenticator | From | To | |
| Change Return Type | 6 | ||
| Change Return Type Optional<String> to String in method public getName() : String in class com.hubspot.singularity.SingularityUser | From | To | |
| Change Return Type Optional<SingularityUser> to String in method private extractAuthHeader(context ContainerRequestContext) : String in class com.hubspot.singularity.auth.authenticator.SingularityWebhookAuthenticator | From | To | |
| Change Return Type Optional<Boolean> to com.google.common.base.Optional<Boolean> in method public isHealthy() : com.google.common.base.Optional<Boolean> in class com.hubspot.singularity.auth.datastore.SingularityAuthDatastore | From | To | |
| Change Return Type Optional<SingularityUser> to java.util.Optional<SingularityUser> in method public getUser(username String) : java.util.Optional<SingularityUser> in class com.hubspot.singularity.auth.datastore.SingularityDummyDatastore | From | To | |
| Change Return Type Optional<Boolean> to com.google.common.base.Optional<Boolean> in method public isHealthy() : com.google.common.base.Optional<Boolean> in class com.hubspot.singularity.auth.datastore.SingularityDisabledAuthDatastore | From | To | |
| Change Return Type Optional<Boolean> to com.google.common.base.Optional<Boolean> in method public isHealthy() : com.google.common.base.Optional<Boolean> in class com.hubspot.singularity.auth.datastore.SingularityLDAPDatastore | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private authorizationHelper : SingularityAuthorizationHelper from class com.hubspot.singularity.resources.UserResource to private authorizationHelper : SingularityAuthorizationHelper from class com.hubspot.singularity.resources.UsageResource | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute datastore : SingularityAuthDatastore to authDatastore : SingularityAuthDatastore in class com.hubspot.singularity.auth.authenticator.SingularityHeaderPassthroughAuthenticator | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type NOT_LOGGED_IN : Optional<SingularityUser> to NOT_LOGGED_IN : SingularityUser in class com.hubspot.singularity.SingularityAuthorizationHelperTest | From | To | |
| Change Attribute Type USER_GROUP_A : Optional<SingularityUser> to USER_GROUP_A : SingularityUser in class com.hubspot.singularity.SingularityAuthorizationHelperTest | From | To | |
| Change Attribute Type USER_GROUP_ADMIN : Optional<SingularityUser> to USER_GROUP_ADMIN : SingularityUser in class com.hubspot.singularity.SingularityAuthorizationHelperTest | From | To | |
| Change Attribute Type USER_GROUP_B : Optional<SingularityUser> to USER_GROUP_B : SingularityUser in class com.hubspot.singularity.SingularityAuthorizationHelperTest | From | To | |
| Change Attribute Type USER_GROUP_AB : Optional<SingularityUser> to USER_GROUP_AB : SingularityUser in class com.hubspot.singularity.SingularityAuthorizationHelperTest | From | To | |
| Rename Parameter | 7 | ||
| Rename Parameter queryUser : Optional<String> to user : SingularityUser in method protected freeze(objectId String, freezeRequest Optional<SingularityMachineChangeRequest>, user SingularityUser, action SingularityAction) : void in class com.hubspot.singularity.resources.AbstractMachineResource | From | To | |
| Rename Parameter queryUser : Optional<String> to user : SingularityUser in method protected activate(objectId String, activateRequest Optional<SingularityMachineChangeRequest>, user SingularityUser, action SingularityAction) : void in class com.hubspot.singularity.resources.AbstractMachineResource | From | To | |
| Rename Parameter queryUser : Optional<String> to user : SingularityUser in method private saveExpiring(changeRequest Optional<SingularityMachineChangeRequest>, user SingularityUser, objectId String) : void in class com.hubspot.singularity.resources.AbstractMachineResource | From | To | |
| Rename Parameter datastore : SingularityAuthDatastore to authDatastore : SingularityAuthDatastore in method public SingularityHeaderPassthroughAuthenticator(authDatastore SingularityAuthDatastore, configuration SingularityConfiguration) in class com.hubspot.singularity.auth.authenticator.SingularityHeaderPassthroughAuthenticator | From | To | |
| Rename Parameter request : HttpServletRequest to user : SingularityUser in method public disableTaskCredits(user SingularityUser) : void in class com.hubspot.singularity.resources.DisastersResource | From | To | |
| Rename Parameter queryUser : Optional<String> to user : SingularityUser in method protected decommission(objectId String, decommissionRequest Optional<SingularityMachineChangeRequest>, user SingularityUser, action SingularityAction) : void in class com.hubspot.singularity.resources.AbstractMachineResource | From | To | |
| Rename Parameter o : Object to obj : Object in method public equals(obj Object) : boolean in class com.hubspot.singularity.SingularityUser | From | To |