b8dbbb2a3aa26699df7e4065728288bd3de5b03b
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Move Method | 1 | ||
Move Method private isValidOffer(offer Offer) : boolean from class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl to private isValidOffer(offer Offer) : boolean from class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
Change Return Type | 1 | ||
Change Return Type Void to void in method private calculateScore(requestUtilizations Map<String,RequestUtilization>, currentSlaveUsagesBySlaveId Map<String,SingularitySlaveUsageWithCalculatedScores>, tasksPerOfferHost Map<String,Integer>, taskRequestHolder SingularityTaskRequestHolder, scorePerOffer Map<String,Double>, activeTaskIdsForRequest List<SingularityTaskId>, scoringException AtomicReference<Throwable>, offerHolder SingularityOfferHolder) : void in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
Move Attribute | 6 | ||
Move Attribute private disasterManager : DisasterManager from class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl to private disasterManager : DisasterManager from class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
Move Attribute private offerCacheEnabled : boolean from class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl to private offerCacheEnabled : boolean from class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
Move Attribute private offerCache : OfferCache from class com.hubspot.singularity.scheduler.SingularitySchedulerPoller to private offerCache : OfferCache from class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
Move Attribute private delayWhenStatusUpdateDeltaTooLarge : boolean from class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl to private delayWhenStatusUpdateDeltaTooLarge : boolean from class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
Move Attribute private delayWhenDeltaOverMs : long from class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl to private delayWhenDeltaOverMs : long from class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
Move Attribute private statusUpdateDeltaAvg : AtomicLong from class com.hubspot.singularity.mesos.SingularityMesosSchedulerImpl to private statusUpdateDeltaAvg : AtomicLong from class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
Rename Attribute | 2 | ||
Rename Attribute offerCache : OfferCache to scheduler : SingularityScheduler in class com.hubspot.singularity.scheduler.SingularitySchedulerPoller | From | To | |
Rename Attribute schedulerClient : SingularityMesosSchedulerClient to taskManager : TaskManager in class com.hubspot.singularity.scheduler.SingularitySchedulerPoller | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type offerCache : OfferCache to scheduler : SingularityScheduler in class com.hubspot.singularity.scheduler.SingularitySchedulerPoller | From | To | |
Change Attribute Type schedulerClient : SingularityMesosSchedulerClient to taskManager : TaskManager in class com.hubspot.singularity.scheduler.SingularitySchedulerPoller | From | To | |
Extract Method | 2 | ||
Extract Method private runAsync(runnable Runnable) : CompletableFuture<Void> extracted from public checkOffers(offers Collection<Offer>) : Collection<SingularityOfferHolder> in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To |