bbe6f7deb4ba000c6dcde3a5e10fa03b6966925f
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method private transferToHistoryDB(inactiveTaskId SingularityTaskId) : boolean renamed to protected moveToHistory(object SingularityTaskId) : boolean in class com.hubspot.singularity.data.history.SingularityTaskHistoryPersister | From | To | |
Inline Method | 1 | ||
Inline Method private transferToHistoryDB(deployKey SingularityDeployKey) : boolean inlined to public runActionOnPoll() : void in class com.hubspot.singularity.data.history.SingularityDeployHistoryPersister | From | To | |
Change Return Type | 3 | ||
Change Return Type void to SingularityDeleteResult in method public deleteHistoryItem(history SingularityRequestHistory) : SingularityDeleteResult in class com.hubspot.singularity.data.RequestManager | From | To | |
Change Return Type void to SingularityDeleteResult in method public deleteHistoryParent(requestId String) : SingularityDeleteResult in class com.hubspot.singularity.data.RequestManager | From | To | |
Change Return Type void to SingularityDeleteResult in method public deletePendingRequest(pendingRequest SingularityPendingRequest) : SingularityDeleteResult in class com.hubspot.singularity.data.RequestManager | From | To | |
Extract Method | 1 | ||
Extract Method protected persistsHistoryInsteadOfPurging() : boolean extracted from protected isEnabled() : boolean in class com.hubspot.singularity.data.history.SingularityHistoryPersister | From | To | |
Rename Parameter | 1 | ||
Rename Parameter inactiveTaskId : SingularityTaskId to object : SingularityTaskId in method protected moveToHistory(object SingularityTaskId) : boolean in class com.hubspot.singularity.data.history.SingularityTaskHistoryPersister | From | To |