be368946580e9f8f0c1d0dd1c42d840c1ca5eee0
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 3 | ||
| Move And Rename Method private getHost(hostname String) : String from class com.hubspot.singularity.mesos.SingularitySlaveAndRackManager to public getMaybeTruncatedHost(hostname String) : String from class com.hubspot.singularity.mesos.SingularitySlaveAndRackHelper | From | To | |
| Move And Rename Method public getSafeString(string String) : String from class com.hubspot.singularity.mesos.SingularitySlaveAndRackManager to public getReplaceHyphensWithUnderscores(string String) : String from class com.hubspot.mesos.JavaUtils | From | To | |
| Move And Rename Method private getRackName(offer Offer) : String from class com.hubspot.singularity.mesos.SingularitySlaveAndRackManager to public getRackId(offer Offer) : String from class com.hubspot.singularity.mesos.SingularitySlaveAndRackHelper | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type slaveAndRackManager : SingularitySlaveAndRackManager to slaveAndRackHelper : SingularitySlaveAndRackHelper in method package SingularityMesosTaskBuilder(objectMapper ObjectMapper, slaveAndRackHelper SingularitySlaveAndRackHelper, idGenerator ExecutorIdGenerator) in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilder | From | To | |
| Move Method | 1 | ||
| Move Method public getRackId(offer Offer) : String from class com.hubspot.singularity.mesos.SingularitySlaveAndRackManager to public getRackId(offer Offer) : String from class com.hubspot.singularity.mesos.SingularitySlaveAndRackHelper | From | To | |
| Rename Variable | 3 | ||
| Rename Variable slaveAndRackManager : SingularitySlaveAndRackManager to slaveAndRackHelper : SingularitySlaveAndRackHelper in method public createMocks() : void in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilderTest | From | To | |
| Rename Variable host : String to sanitizedHost : String in method public buildTask(offer Protos.Offer, availableResources List<Resource>, taskRequest SingularityTaskRequest, desiredTaskResources Resources, desiredExecutorResources Resources) : SingularityTask in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilder | From | To | |
| Rename Variable rackId : String to sanitizedRackId : String in method public buildTask(offer Protos.Offer, availableResources List<Resource>, taskRequest SingularityTaskRequest, desiredTaskResources Resources, desiredExecutorResources Resources) : SingularityTask in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilder | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private rackIdAttributeKey : String from class com.hubspot.singularity.mesos.SingularitySlaveAndRackManager to private rackIdAttributeKey : String from class com.hubspot.singularity.mesos.SingularitySlaveAndRackHelper | From | To | |
| Move Attribute private defaultRackId : String from class com.hubspot.singularity.mesos.SingularitySlaveAndRackManager to private defaultRackId : String from class com.hubspot.singularity.mesos.SingularitySlaveAndRackHelper | From | To | |
| Extract Class | 1 | ||
| Extract Class com.hubspot.singularity.mesos.SingularitySlaveAndRackHelper from class com.hubspot.singularity.mesos.SingularitySlaveAndRackManager | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute slaveAndRackManager : SingularitySlaveAndRackManager to slaveAndRackHelper : SingularitySlaveAndRackHelper in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilder | From | To | |
| Rename Attribute host : String to sanitizedHost : String in class com.hubspot.singularity.SingularityTaskId | From | To | |
| Rename Attribute rackId : String to sanitizedRackId : String in class com.hubspot.singularity.SingularityTaskId | From | To | |
| Rename Attribute defaultRackId : String to slaveAndRackHelper : SingularitySlaveAndRackHelper in class com.hubspot.singularity.mesos.SingularitySlaveAndRackManager | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type slaveAndRackManager : SingularitySlaveAndRackManager to slaveAndRackHelper : SingularitySlaveAndRackHelper in method public createMocks() : void in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilderTest | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type slaveAndRackManager : SingularitySlaveAndRackManager to slaveAndRackHelper : SingularitySlaveAndRackHelper in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilder | From | To | |
| Change Attribute Type defaultRackId : String to slaveAndRackHelper : SingularitySlaveAndRackHelper in class com.hubspot.singularity.mesos.SingularitySlaveAndRackManager | From | To | |
| Extract Method | 2 | ||
| Extract Method public getSanitizedRackId() : String extracted from public getRackId() : String in class com.hubspot.singularity.SingularityTaskId | From | To | |
| Extract Method public getSanitizedHost() : String extracted from public getHost() : String in class com.hubspot.singularity.SingularityTaskId | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter host : String to sanitizedHost : String in method public SingularityTaskId(requestId String, deployId String, startedAt long, instanceNo int, sanitizedHost String, sanitizedRackId String) in class com.hubspot.singularity.SingularityTaskId | From | To | |
| Rename Parameter rackId : String to sanitizedRackId : String in method public SingularityTaskId(requestId String, deployId String, startedAt long, instanceNo int, sanitizedHost String, sanitizedRackId String) in class com.hubspot.singularity.SingularityTaskId | From | To | |
| Rename Parameter slaveAndRackManager : SingularitySlaveAndRackManager to slaveAndRackHelper : SingularitySlaveAndRackHelper in method package SingularityMesosTaskBuilder(objectMapper ObjectMapper, slaveAndRackHelper SingularitySlaveAndRackHelper, idGenerator ExecutorIdGenerator) in class com.hubspot.singularity.mesos.SingularityMesosTaskBuilder | From | To |